From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12881 invoked by alias); 14 Jan 2013 18:06:12 -0000 Received: (qmail 12870 invoked by uid 22791); 14 Jan 2013 18:06:11 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,TW_PX X-Spam-Check-By: sourceware.org Received: from one.firstfloor.org (HELO one.firstfloor.org) (213.235.205.2) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 14 Jan 2013 18:06:02 +0000 Received: by one.firstfloor.org (Postfix, from userid 503) id 27C4E1ED8025; Mon, 14 Jan 2013 19:06:01 +0100 (CET) Date: Mon, 14 Jan 2013 18:06:00 -0000 From: Andi Kleen To: Uros Bizjak Cc: Andi Kleen , gcc-patches@gcc.gnu.org Subject: Re: [PATCH 2/2] Support __ATOMIC_HLE_RELEASE for __atomic_clear/store_n Message-ID: <20130114180601.GA30577@one.firstfloor.org> References: <20130113203603.GS30577@one.firstfloor.org> <20130113221251.GW30577@one.firstfloor.org> <20130113222946.GX30577@one.firstfloor.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.2i Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2013-01/txt/msg00719.txt.bz2 > This cannot happen, we reject code that sets both __HLE* flags. Good thanks. BTW I found more HLE bugs, it looks like some of the fetch_op_* patterns do not match always and fall back to cmpxchg, which does not generate HLE code correctly. Not fully sure what's wrong, can you spot any obvious problems? You changed the (define_insn "atomic_" pattern last. The only one that should really fallback to cmpxchg is nand, all the others can be generated directly. This can be seen by commenting in the #if 0 case in the libstdc++ HLE patch test case I sent yesterday. http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55966 -Andi