From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30319 invoked by alias); 15 Jan 2013 10:56:51 -0000 Received: (qmail 30307 invoked by uid 22791); 15 Jan 2013 10:56:49 -0000 X-SWARE-Spam-Status: No, hits=-6.2 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS,TW_CF X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 15 Jan 2013 10:56:44 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r0FAui4K002974 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 15 Jan 2013 05:56:44 -0500 Received: from zalov.redhat.com (vpn1-5-224.ams2.redhat.com [10.36.5.224]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r0FAugii014893 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 15 Jan 2013 05:56:43 -0500 Received: from zalov.cz (localhost [127.0.0.1]) by zalov.redhat.com (8.14.5/8.14.5) with ESMTP id r0FAuff0028210; Tue, 15 Jan 2013 11:56:41 +0100 Received: (from jakub@localhost) by zalov.cz (8.14.5/8.14.5/Submit) id r0FAueNF028209; Tue, 15 Jan 2013 11:56:40 +0100 Date: Tue, 15 Jan 2013 10:56:00 -0000 From: Jakub Jelinek To: Richard Biener Cc: Richard Henderson , gcc-patches@gcc.gnu.org Subject: Re: [PATCH][RFC] Fix PR55964 Message-ID: <20130115105640.GV7269@tucnak.redhat.com> Reply-To: Jakub Jelinek References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2013-01/txt/msg00771.txt.bz2 On Mon, Jan 14, 2013 at 04:58:09PM +0100, Richard Biener wrote: > I happen to have a patch for PR55964 around - preparatory work > to make loop distribution (and vectorization) handle nested loops. > It mostly kills the broken way loop distribution copies loops > (which is where we ICE in this PR). So instead of trying to > make that old logic slightly less broken I consider to simply > apply this work now ... (I've posted this before in December). > > I'm re-bootstrapping and testing this on x86_64-unknown-linux-gnu. > > So ... ok at this stage? Ok, if nobody complains in the next 24 hours. > 2013-01-14 Richard Biener > > PR tree-optimization/55964 > * tree-flow.h (rename_variables_in_loop): Remove. > (rename_variables_in_bb): Likewise. > * tree-loop-distribution.c (update_phis_for_loop_copy): Remove. > (copy_loop_before): Adjust and delete update-ssa status. > * tree-vect-loop-manip.c (rename_variables_in_bb): Make static. > (rename_variables_in_bb): Likewise. Properly walk over > predecessors. > (rename_variables_in_loop): Remove. > (slpeel_update_phis_for_duplicate_loop): Likewise. > (slpeel_tree_duplicate_loop_to_edge_cfg): Handle nested loops, > use available cfg machinery instead of duplicating it. > Update PHI nodes and perform poor-mans SSA update here. > (slpeel_tree_peel_loop_to_edge): Adjust. > > * gcc.dg/torture/pr55964.c: New testcase. Jakub