public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jan Hubicka <hubicka@ucw.cz>
To: Jan Hubicka <hubicka@ucw.cz>
Cc: Richard Biener <richard.guenther@gmail.com>,
	GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH, PR 55264] Do not remove as unreachable any virtual methods before inlining
Date: Wed, 16 Jan 2013 12:44:00 -0000	[thread overview]
Message-ID: <20130116124420.GA26629@kam.mff.cuni.cz> (raw)
In-Reply-To: <20130116112121.GA11708@kam.mff.cuni.cz>

> Perhaps could you first change cgraph_non_local_node_p_1 and try to check some code
> if codegen differs significantly? It should not at all.
> ipa-cp is the sole user of this flag in IPA passes, so you should know what it does.

Thinking deeper of ipa-cp and local virtuals, I think this is all slipperly.
Local means that all calls to the functions are explicit and known. Obviously
if function is virutal and new calls may appear by devirtualization, the local
flag is bogus.  I guess the external functions are the only that may be local
and virtual because somewhere there must be a vtable reference, but to play
safe, I would suggest marking all virtuals non-local.

Honza

  reply	other threads:[~2013-01-16 12:44 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-16 10:01 Martin Jambor
2013-01-16 10:30 ` Richard Biener
2013-01-16 11:21   ` Jan Hubicka
2013-01-16 12:44     ` Jan Hubicka [this message]
2013-01-16 18:42       ` Martin Jambor
2013-01-16 21:24         ` Jan Hubicka
2013-01-18 17:46           ` Martin Jambor
2013-01-18 17:48           ` Martin Jambor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130116124420.GA26629@kam.mff.cuni.cz \
    --to=hubicka@ucw.cz \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=richard.guenther@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).