* [google 4.7] Fix for PR 8013197 (issue7140044)
@ 2013-01-16 21:37 Sterling Augustine
2013-01-17 0:21 ` Cary Coutant
0 siblings, 1 reply; 4+ messages in thread
From: Sterling Augustine @ 2013-01-16 21:37 UTC (permalink / raw)
To: gcc-patches, reply
commit 257910a4dd56ac0c95ad79053a4364a3ff34a674
Author: Sterling Augustine <saugustine@google.com>
Date: Wed Jan 16 13:22:59 2013 -0800
Fix for PR 8013197.
Address table entries will already have been removed at this point in
resolve_addr, so no need to call again.
M gcc/dwarf2out.c
Tested:
With full bootstrap and regression test.
ChangeLog:
<Split this into multiple sections if you're touching directories
covered by multiple ChangeLog files.>
2013-01-16 Sterling Augustine <saugustine@google.com>
* gcc/dwarf2out.c (resolve_addr): Delete call to
remove_addr_table_entry.
diff --git a/gcc/dwarf2out.c b/gcc/dwarf2out.c
index 026991b..5ca22b2 100644
--- a/gcc/dwarf2out.c
+++ b/gcc/dwarf2out.c
@@ -23234,8 +23234,6 @@ resolve_addr (dw_die_ref die)
else
{
loc->replaced = 1;
- if (dwarf_split_debug_info)
- remove_loc_list_addr_table_entries (loc->expr);
loc->dw_loc_next = *start;
}
}
--
This patch is available for review at http://codereview.appspot.com/7140044
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [google 4.7] Fix for PR 8013197 (issue7140044)
2013-01-16 21:37 [google 4.7] Fix for PR 8013197 (issue7140044) Sterling Augustine
@ 2013-01-17 0:21 ` Cary Coutant
2013-01-17 22:01 ` Sterling Augustine
2013-01-18 19:05 ` Cary Coutant
0 siblings, 2 replies; 4+ messages in thread
From: Cary Coutant @ 2013-01-17 0:21 UTC (permalink / raw)
To: Sterling Augustine; +Cc: gcc-patches, reply
> 2013-01-16 Sterling Augustine <saugustine@google.com>
>
> * gcc/dwarf2out.c (resolve_addr): Delete call to
> remove_addr_table_entry.
OK for google/gcc-4_7. The commit log entry should say "Google ref:
b/8013197" instead of "PR ...".
Thanks!
-cary
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [google 4.7] Fix for PR 8013197 (issue7140044)
2013-01-17 0:21 ` Cary Coutant
@ 2013-01-17 22:01 ` Sterling Augustine
2013-01-18 19:05 ` Cary Coutant
1 sibling, 0 replies; 4+ messages in thread
From: Sterling Augustine @ 2013-01-17 22:01 UTC (permalink / raw)
To: Cary Coutant; +Cc: gcc-patches, reply
On Wed, Jan 16, 2013 at 4:21 PM, Cary Coutant <ccoutant@google.com> wrote:
>
> > 2013-01-16 Sterling Augustine <saugustine@google.com>
> >
> > * gcc/dwarf2out.c (resolve_addr): Delete call to
> > remove_addr_table_entry.
>
> OK for google/gcc-4_7. The commit log entry should say "Google ref:
> b/8013197" instead of "PR ...".
>
> Thanks!
>
> -cary
Committed with your suggestion. Thanks.
Sterling
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [google 4.7] Fix for PR 8013197 (issue7140044)
2013-01-17 0:21 ` Cary Coutant
2013-01-17 22:01 ` Sterling Augustine
@ 2013-01-18 19:05 ` Cary Coutant
1 sibling, 0 replies; 4+ messages in thread
From: Cary Coutant @ 2013-01-18 19:05 UTC (permalink / raw)
To: Sterling Augustine; +Cc: gcc-patches, reply
>> 2013-01-16 Sterling Augustine <saugustine@google.com>
>>
>> * gcc/dwarf2out.c (resolve_addr): Delete call to
>> remove_addr_table_entry.
>
> OK for google/gcc-4_7. The commit log entry should say "Google ref:
> b/8013197" instead of "PR ...".
I'll file an upstream bug for this as well (as soon as I can get the
test case reduced enough), and I'd like to get this fix into 4.8.
-cary
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-01-18 19:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-01-16 21:37 [google 4.7] Fix for PR 8013197 (issue7140044) Sterling Augustine
2013-01-17 0:21 ` Cary Coutant
2013-01-17 22:01 ` Sterling Augustine
2013-01-18 19:05 ` Cary Coutant
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).