From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13215 invoked by alias); 21 Jan 2013 14:06:19 -0000 Received: (qmail 13191 invoked by uid 22791); 21 Jan 2013 14:06:17 -0000 X-SWARE-Spam-Status: No, hits=-6.4 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 21 Jan 2013 14:05:58 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r0LE5oC5010460 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 21 Jan 2013 09:05:50 -0500 Received: from zalov.redhat.com (vpn1-6-248.ams2.redhat.com [10.36.6.248]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r0LE5mRM001943 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 21 Jan 2013 09:05:50 -0500 Received: from zalov.cz (localhost [127.0.0.1]) by zalov.redhat.com (8.14.5/8.14.5) with ESMTP id r0LE5lli029486; Mon, 21 Jan 2013 15:05:48 +0100 Received: (from jakub@localhost) by zalov.cz (8.14.5/8.14.5/Submit) id r0LE5k9K029485; Mon, 21 Jan 2013 15:05:46 +0100 Date: Mon, 21 Jan 2013 14:06:00 -0000 From: Jakub Jelinek To: Andi Kleen Cc: gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org, jwakely.gcc@gmail.com, Andi Kleen Subject: Re: [PATCH] libstdc++: Add mem_order_hle_acquire/release to atomic.h v2 Message-ID: <20130121140545.GK7269@tucnak.redhat.com> Reply-To: Jakub Jelinek References: <1358143565-29558-1-git-send-email-andi@firstfloor.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1358143565-29558-1-git-send-email-andi@firstfloor.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2013-01/txt/msg01054.txt.bz2 On Sun, Jan 13, 2013 at 10:06:05PM -0800, Andi Kleen wrote: > 2013-01-12 Andi Kleen > Jonathan Wakely > > PR libstdc++/55223 > * testsuite/29_atomics/atomic_flag/test_and_set/explicit-hle.cc: > Add. The test is broken on i?86-linux, > --- /dev/null > +++ b/libstdc++-v3/testsuite/29_atomics/atomic_flag/test_and_set/explicit-hle.cc > @@ -0,0 +1,120 @@ > +// { dg-options "-std=gnu++0x" } 1) you need // { dg-additional-options "-march=i486" { target ia32 } } or something similar, otherwise for a pure i386 target it will not work right > +// { dg-do compile { target i?86-*-* x86_64-*-* } } > +// { dg-final { scan-assembler-times "\(xacquire\|\.byte.*0xf2\)" 14 } } > +// { dg-final { scan-assembler-times "\(xrelease\|\.byte.*0xf3\)" 14 } } 2) \.byte.*0xf needs to be replaced by \.byte\[^\n\r]*0xf otherwise it will happily match say .byte 0 .uleb128 0x2d .long 0xf23 in .debug_info 3) I guess you want to add "-g0 -fno-exceptions -fno-asynchronous-unwind-tables" to double check that .byte 0xf2 or .byte 0xf3 won't suddenly appear in .debug_* or .eh_frame sections. Jakub