From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4016 invoked by alias); 22 Jan 2013 11:19:37 -0000 Received: (qmail 3999 invoked by uid 22791); 22 Jan 2013 11:19:36 -0000 X-SWARE-Spam-Status: No, hits=-6.4 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 22 Jan 2013 11:19:25 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r0MBJOs9027443 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 22 Jan 2013 06:19:24 -0500 Received: from zalov.redhat.com (vpn1-4-254.ams2.redhat.com [10.36.4.254]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r0MBJMFl023951 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 22 Jan 2013 06:19:24 -0500 Received: from zalov.cz (localhost [127.0.0.1]) by zalov.redhat.com (8.14.5/8.14.5) with ESMTP id r0MBJMuJ012952; Tue, 22 Jan 2013 12:19:22 +0100 Received: (from jakub@localhost) by zalov.cz (8.14.5/8.14.5/Submit) id r0MBJLFQ012951; Tue, 22 Jan 2013 12:19:21 +0100 Date: Tue, 22 Jan 2013 11:19:00 -0000 From: Jakub Jelinek To: gcc-patches@gcc.gnu.org Cc: Torvald Riegel , Richard Henderson Subject: Re: PR libgomp/56073: benchmark regression due to PR libgomp/51376 fix Message-ID: <20130122111921.GR7269@tucnak.redhat.com> Reply-To: Jakub Jelinek References: <20130122110324.GL3244@bubble.grove.modra.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130122110324.GL3244@bubble.grove.modra.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2013-01/txt/msg01086.txt.bz2 On Tue, Jan 22, 2013 at 09:33:25PM +1030, Alan Modra wrote: > Bootstrapped and regression tested powerpc64-linux. OK to apply? > > PR libgomp/51376 > PR libgomp/56073 > * task.c (GOMP_task): Revert 2011-12-09 change. > (GOMP_taskwait): Likewise. Instead use atomic load with acquire > barrier to read task->children.. > (gomp_barrier_handle_tasks): ..and matching atomic store with > release barrier here when setting parent->children to NULL. Looks good to me. Jakub