From: Jakub Jelinek <jakub@redhat.com>
To: gcc-patches@gcc.gnu.org, Torvald Riegel <triegel@redhat.com>,
Richard Henderson <rth@redhat.com>
Subject: Re: PR libgomp/56073: benchmark regression due to PR libgomp/51376 fix
Date: Tue, 22 Jan 2013 14:27:00 -0000 [thread overview]
Message-ID: <20130122142733.GU7269@tucnak.redhat.com> (raw)
In-Reply-To: <20130122120124.GT7269@tucnak.redhat.com>
On Tue, Jan 22, 2013 at 01:01:24PM +0100, Jakub Jelinek wrote:
> On Tue, Jan 22, 2013 at 10:22:00PM +1030, Alan Modra wrote:
> > On Tue, Jan 22, 2013 at 12:19:21PM +0100, Jakub Jelinek wrote:
> > > Looks good to me.
> >
> > Thanks for the amazingly quick review! Committed revision 195370.
>
> Actually, there is one thing I'm worried about, -lgomp doesn't link against
> -latomic, and for !HAVE_SYNC_BUILTINS targets supposedly __atomic_load_n
> resp. __atomic_store_n might not be supported. Not sure what targets
> are still !HAVE_SYNC_BUILTIN targets, but if there are any that support
> libgomp, either we should use normal loads/stores for those (on the
> assumption that targets without sync builtins supposedly don't have very
> relaxed consistency model), or would need to take the lock always for
> !HAVE_SYNC_BUILTINS and use normal loads/stores.
Seems for loads/stores <= wordsize we just assume they are atomic and expand
it as normal load or store (with optional barriers if target has any).
So supposedly it can work as is.
Jakub
next prev parent reply other threads:[~2013-01-22 14:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-22 11:03 Alan Modra
2013-01-22 11:19 ` Jakub Jelinek
2013-01-22 11:52 ` Alan Modra
2013-01-22 12:01 ` Jakub Jelinek
2013-01-22 14:27 ` Jakub Jelinek [this message]
2013-01-22 13:53 ` Torvald Riegel
2013-01-23 1:12 ` Alan Modra
2013-01-23 10:39 ` Torvald Riegel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130122142733.GU7269@tucnak.redhat.com \
--to=jakub@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=rth@redhat.com \
--cc=triegel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).