From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16953 invoked by alias); 26 Jan 2013 03:21:33 -0000 Received: (qmail 16942 invoked by uid 22791); 26 Jan 2013 03:21:32 -0000 X-SWARE-Spam-Status: No, hits=-8.9 required=5.0 tests=AWL,BAYES_00,KHOP_PGP_SIGNED,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 26 Jan 2013 03:20:41 +0000 Received: from vapier.localnet (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id DCF0033DE44; Sat, 26 Jan 2013 03:20:40 +0000 (UTC) From: Mike Frysinger To: Ian Lance Taylor Subject: Re: [PATCH 1/2] [pr53679] libgo: add a --enable-werror configure flag Date: Sat, 26 Jan 2013 03:21:00 -0000 User-Agent: KMail/1.13.7 (Linux/3.7.1; KDE/4.6.5; x86_64; ; ) Cc: gcc-patches@gcc.gnu.org References: <1356305421-13533-1-git-send-email-vapier@gentoo.org> <201301151245.14337.vapier@gentoo.org> In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart1976633.uneBUDuZ17"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201301252220.39972.vapier@gentoo.org> Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2013-01/txt/msg01266.txt.bz2 --nextPart1976633.uneBUDuZ17 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-length: 2124 On Friday 25 January 2013 19:13:55 Ian Lance Taylor wrote: > On Tue, Jan 15, 2013 at 9:45 AM, Mike Frysinger wrote: > > On Tuesday 15 January 2013 09:56:06 Ian Lance Taylor wrote: > >> On Sun, Dec 23, 2012 at 3:30 PM, Mike Frysinger wrote: > >> > diff --git a/libgo/configure.ac b/libgo/configure.ac > >> > index 8cde50b..63d8cbc 100644 > >> > --- a/libgo/configure.ac > >> > +++ b/libgo/configure.ac > >> > @@ -50,8 +50,11 @@ AC_PROG_AWK > >> >=20 > >> > WARN_FLAGS=3D'-Wall -Wextra -Wwrite-strings -Wcast-qual' > >> > AC_SUBST(WARN_FLAGS) > >> >=20 > >> > -dnl FIXME: This should be controlled by --enable-maintainer-mode. > >> > -WERROR=3D"-Werror" > >> > +AC_ARG_ENABLE(werror, [AS_HELP_STRING([--enable-werror], > >> > + [turns on -Werror > >> > @<:@default=3Dyes@:>@])]) +if test "x$enable_werror" !=3D "xno"; then > >> > + WERROR=3D"-Werror" > >> > +fi > >> >=20 > >> > AC_SUBST(WERROR) > >> >=20=20 > >> > glibgo_toolexecdir=3Dno > >>=20 > >> Can you say something about when you needed this? What errors were you > >> seeing? > >=20 > > the referenced PR describes one: > > /build/src/gcc-4.7.1/libgo/runtime/print.c: In function 'gwrite': > > /build/src/gcc-4.7.1/libgo/runtime/print.c:20:3: error: ignoring return > > value of 'write', declared with attribute warn_unused_result > > [-Werror=3Dunused-result] cc1: all warnings being treated as errors > >=20 > > this bites distros that enable security settings by default (such as > > fortify and ssp). but ignoring even that, i don't believe releases > > should build all the time with -Werror -- i'm fine with defaulting to on > > as long as there is a configure flag to turn it off which is what this > > does like is already handled in much of the sourceware tree. -Werror is > > great for development, but sucks when deployed on actual systems. the > > assumptions made at time of checkin rarely stay constant forever (in > > this case, a changing lib C can easily break it). -mike >=20 > Thanks for the explanation. >=20 > Committed to mainline. thanks! mind if i commit it to gcc-4.6 and gcc-4.7 too ? -mike --nextPart1976633.uneBUDuZ17 Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. Content-length: 836 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (GNU/Linux) iQIcBAABAgAGBQJRA0uHAAoJEEFjO5/oN/WBBhkP+wRMihzDoOPzhhJ65G4wZmOc F5RSq1z2iuZih/Ot+jCAAZau14jsQvM1QCEomYKgJ1soH/kt/7uid7BkwGG+N48E KOSy766o8QzDio+2xr4uSuyx9n8Jyeba8KTLhwj50MKE1RfqDe+jqbM/opS6xTrW vASUdYnEJ91me3NybiFw77t0Vw2hWjxw27sA42RkwzDEAVxmvFl8tZm1JyEXL0yf OGM1l2ECaA372xqUpk5JFcLhNuA99b/DR7KAmgf+A+0uooWKjsG+cIQT9hjQtsUn 8U7tk9D5cTAdAgcYx+cwaQVBKdtLHshPzAObdKooqZnY/axwZrlZuGmxQBf/JLnm rqVgpVNxXS4Lc+WgFT86BcTRWxdAiHprxIC+yijovGoDxAbucoF6S6LLGuruYtM6 BvQNw3ORSpde73RlUqc9OZ1qndbscLaE1xjP6BDJUdMrxE5grknhOFokWoczajAn nfIJ/kz1ChUmXf/06zCaQ36gtW+E6RlkcKiVaNUckEQgRMWbVrG+Qjwy5QgZciIn /xwd6OFIZFRUrSPgIfP3NCzuAxKr/vQFTlvkCcICNZmiZgggS2bdMuMbBah9GKRV VmDa6FHNV/KVJoq7KnHQ60ac7ei6MC7cN81Til4pJPSO2CmtAAY2coZBEER2qrSl x3lupDWeb3nnB/6IIlGM =eEBR -----END PGP SIGNATURE----- --nextPart1976633.uneBUDuZ17--