public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Hans-Peter Nilsson <hans-peter.nilsson@axis.com>
To: zadeck@naturalbridge.com
Cc: gcc-patches@gcc.gnu.org, rdsandiford@googlemail.com,
	marc.glisse@inria.fr
Subject: Re: question about section 10.12
Date: Mon, 28 Jan 2013 22:14:00 -0000	[thread overview]
Message-ID: <201301282214.r0SMELBx013976@ignucius.se.axis.com> (raw)
In-Reply-To: <5105CE31.7040307@naturalbridge.com> (message from Kenneth Zadeck	on Mon, 28 Jan 2013 02:02:41 +0100)

> From: Kenneth Zadeck <zadeck@naturalbridge.com>
> Date: Mon, 28 Jan 2013 02:02:41 +0100

> this looks good to me.  does your patch also address the vec_concat 
> issue that marc raised?

You mean the issue being "same thing there"?  I can confirm that
(I've stumbled upon) the same issue being there (i.e. similarly
applies to scalars).  But nope, there's no cross-reference, so
the effective wording needs to be added there too.  I also
noticed the parameter/s misleadingly being keyed to "vec" and
fill-paragraphed the paragraph.  Something like this seems
obvious:

(Oops, noticed gcc@ was in CC, changing to gcc-patches@.)

	* doc/rtl.texi (vec_concat, vec_duplicate): Mention that
	scalars are valid operands.

Index: doc/rtl.texi
===================================================================
--- doc/rtl.texi	(revision 195514)
+++ doc/rtl.texi	(working copy)
@@ -2627,17 +2627,18 @@ The result mode @var{m} is either the su
 with that element submode (if multiple subparts are selected).
 
 @findex vec_concat
-@item (vec_concat:@var{m} @var{vec1} @var{vec2})
+@item (vec_concat:@var{m} @var{x1} @var{x2})
 Describes a vector concat operation.  The result is a concatenation of the
-vectors @var{vec1} and @var{vec2}; its length is the sum of the lengths of
-the two inputs.
+vectors or scalars @var{x1} and @var{x2}; its length is the sum of the
+lengths of the two inputs.
 
 @findex vec_duplicate
-@item (vec_duplicate:@var{m} @var{vec})
-This operation converts a small vector into a larger one by duplicating the
-input values.  The output vector mode must have the same submodes as the
-input vector mode, and the number of output parts must be an integer multiple
-of the number of input parts.
+@item (vec_duplicate:@var{m} @var{x})
+This operation converts a scalar into a vector or a small vector into a
+larger one by duplicating the input values.  The output vector mode must have
+the same submodes as the input vector mode or the scalar modes, and the
+number of output parts must be an integer multiple of the number of input
+parts.
 
 @end table
 
brgds, H-P

       reply	other threads:[~2013-01-28 22:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <5105CE31.7040307@naturalbridge.com>
2013-01-28 22:14 ` Hans-Peter Nilsson [this message]
2013-02-21 16:43   ` vec_concat, vec_duplicate doc updated (was: Re: question about section 10.12) Hans-Peter Nilsson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201301282214.r0SMELBx013976@ignucius.se.axis.com \
    --to=hans-peter.nilsson@axis.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=marc.glisse@inria.fr \
    --cc=rdsandiford@googlemail.com \
    --cc=zadeck@naturalbridge.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).