From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11156 invoked by alias); 29 Jan 2013 14:46:26 -0000 Received: (qmail 11147 invoked by uid 22791); 29 Jan 2013 14:46:25 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,KHOP_SPAMHAUS_DROP,RCVD_IN_HOSTKARMA_NO X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 29 Jan 2013 14:46:12 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 9D5C82E716 for ; Tue, 29 Jan 2013 09:46:11 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id pr-WboRY9-O5 for ; Tue, 29 Jan 2013 09:46:11 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 6C66B2E2AC for ; Tue, 29 Jan 2013 09:46:11 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id BF54FC33DE; Tue, 29 Jan 2013 06:46:09 -0800 (PST) Date: Tue, 29 Jan 2013 14:46:00 -0000 From: Joel Brobecker To: gcc-patches@gcc.gnu.org Subject: Ping: [RFA/dwarf] Add DW_AT_use_GNAT_descriptive_type flag for Ada units. Message-ID: <20130129144609.GE3532@adacore.com> References: <1357647854-27196-1-git-send-email-brobecker@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1357647854-27196-1-git-send-email-brobecker@adacore.com> User-Agent: Mutt/1.5.21 (2010-09-15) Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2013-01/txt/msg01391.txt.bz2 Hello, I was hoping someone would kindly review this patch? It is an important part for debugging Ada code, helping with performance. Thank you! On Tue, Jan 08, 2013 at 07:24:14AM -0500, Joel Brobecker wrote: > Hello, > > I just noticed that part of the proposal we made for... > http://gcc.gnu.org/wiki/DW_AT_GNAT_descriptive_type > > ... got missed in the patch that got checked in: > http://gcc.gnu.org/ml/gcc-patches/2011-04/msg00099.html > > In particular, we're missing the second part, where we are > expected to generate a DW_AT_use_GNAT_descriptive_type flag > in the CU in order to tell the consumers that we are providing > the descriptive type. > > gcc/ChangeLog: > > * dwarf2out.c (gen_compile_unit_die): Add > DW_AT_use_GNAT_descriptive_type attribute for Ada units. > > Tested on x86_64-linux, no regression. I also tested against > the GDB testsuite, before and after, and no regression. This > is expected, since GDB currently does not look for this attribute > (but I would like it to). > > OK to apply for HEAD and 4.7? > > Thanks, > -- > Joel > > --- > gcc/dwarf2out.c | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/gcc/dwarf2out.c b/gcc/dwarf2out.c > index a865250..8117ce9 100644 > --- a/gcc/dwarf2out.c > +++ b/gcc/dwarf2out.c > @@ -18940,6 +18940,10 @@ gen_compile_unit_die (const char *filename) > /* The default DW_ID_case_sensitive doesn't need to be specified. */ > break; > } > + > + if (language == DW_LANG_Ada95) > + add_AT_flag (die, DW_AT_use_GNAT_descriptive_type, 1); > + > return die; > } > > -- > 1.7.0.4 -- Joel