From: Jakub Jelinek <jakub@redhat.com>
To: Steve Ellcey <Steve.Ellcey@imgtec.com>,
Aldy Hernandez <aldyh@redhat.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>,
"rdsandiford@googlemail.com" <rdsandiford@googlemail.com>
Subject: Re: PR target/52555: attribute optimize is overriding command line options
Date: Fri, 22 Feb 2013 10:03:00 -0000 [thread overview]
Message-ID: <20130222100311.GJ1215@tucnak.zalov.cz> (raw)
In-Reply-To: <1C0E790D7E4C75418622FD04CC2A1172015D5C06@bamail02.ba.imgtec.org>
On Thu, Feb 21, 2013 at 11:02:56PM +0000, Steve Ellcey wrote:
> Have you gotten any reports of problems with this patch? It seems to be sending cc1 into an infinite
> loop during the GCC testsuite for me. I am testing the mips-mti-linux-gnu target and tests like
> gcc.target/mips/call-saved-1.c are causing cc1 to suck up all my memory and swap space before the
> test times out.
>
> I will keep digging and see if I can figure out what is going on but I wanted to see if anyone else has
> reported this problem.
I think this should fix this (but totally untested except for
call-saved-1.c, and it doesn't make any sense to test on non-mips).
The problem I believe is that Aldy has changed init_optabs and insn-opinit.c
to use this_fn_optabs instead of this_target_optabs, but it is only set in
invoke_set_current_function_hook. During save_target_globals we want to
init this_target_optabs, so we need to temporarily switch this_fn_optabs to
make that happen.
2013-02-22 Jakub Jelinek <jakub@redhat.com>
PR target/52555
* target-globals.c (save_target_globals): For init_reg_sets and
target_reinit remporarily set this_fn_optabs to this_target_optabs.
--- gcc/target-globals.c.jj 2013-02-19 07:40:03.000000000 +0100
+++ gcc/target-globals.c 2013-02-22 10:55:36.725435859 +0100
@@ -67,6 +67,7 @@ struct target_globals *
save_target_globals (void)
{
struct target_globals *g;
+ struct target_optabs *saved_this_fn_optabs = this_fn_optabs;
g = ggc_alloc_target_globals ();
g->flag_state = XCNEW (struct target_flag_state);
@@ -86,8 +87,10 @@ save_target_globals (void)
g->bb_reorder = XCNEW (struct target_bb_reorder);
g->lower_subreg = XCNEW (struct target_lower_subreg);
restore_target_globals (g);
+ this_fn_optabs = this_target_optabs;
init_reg_sets ();
target_reinit ();
+ this_fn_optabs = saved_this_fn_optabs;
return g;
}
Jakub
next prev parent reply other threads:[~2013-02-22 10:03 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-12 0:15 Aldy Hernandez
2013-02-12 14:05 ` Jakub Jelinek
2013-02-12 15:58 ` Aldy Hernandez
2013-02-12 16:16 ` Jakub Jelinek
2013-02-12 16:30 ` Richard Sandiford
2013-02-12 17:28 ` Aldy Hernandez
2013-02-12 17:48 ` Richard Sandiford
2013-02-12 17:46 ` Richard Sandiford
2013-02-13 17:39 ` Aldy Hernandez
2013-02-13 17:58 ` Richard Sandiford
2013-02-13 18:08 ` Aldy Hernandez
2013-02-13 19:54 ` Jakub Jelinek
2013-02-15 17:23 ` Aldy Hernandez
2013-02-15 17:35 ` Jakub Jelinek
2013-02-15 17:52 ` Aldy Hernandez
2013-02-16 11:20 ` Richard Sandiford
2013-02-18 18:51 ` Aldy Hernandez
2013-02-18 23:05 ` Jakub Jelinek
2013-02-21 23:03 ` Steve Ellcey
2013-02-22 0:10 ` Aldy Hernandez
2013-02-22 10:03 ` Jakub Jelinek [this message]
2013-02-22 17:32 ` Steve Ellcey
2013-02-22 18:17 ` Jakub Jelinek
2013-02-22 19:49 ` Richard Sandiford
2013-03-01 23:37 ` Steve Ellcey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130222100311.GJ1215@tucnak.zalov.cz \
--to=jakub@redhat.com \
--cc=Steve.Ellcey@imgtec.com \
--cc=aldyh@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=rdsandiford@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).