From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11090 invoked by alias); 22 Feb 2013 18:17:59 -0000 Received: (qmail 11073 invoked by uid 22791); 22 Feb 2013 18:17:57 -0000 X-SWARE-Spam-Status: No, hits=-6.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 22 Feb 2013 18:17:47 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r1MIHiZG021124 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 22 Feb 2013 13:17:46 -0500 Received: from zalov.redhat.com (vpn1-4-48.ams2.redhat.com [10.36.4.48]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r1MIHgur030944 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 22 Feb 2013 13:17:43 -0500 Received: from zalov.cz (localhost [127.0.0.1]) by zalov.redhat.com (8.14.5/8.14.5) with ESMTP id r1MIHfTw017640; Fri, 22 Feb 2013 19:17:41 +0100 Received: (from jakub@localhost) by zalov.cz (8.14.5/8.14.5/Submit) id r1MIHeKP017639; Fri, 22 Feb 2013 19:17:40 +0100 Date: Fri, 22 Feb 2013 18:17:00 -0000 From: Jakub Jelinek To: Steve Ellcey , "rdsandiford@googlemail.com" Cc: Aldy Hernandez , gcc-patches Subject: Re: PR target/52555: attribute optimize is overriding command line options Message-ID: <20130222181740.GP1215@tucnak.zalov.cz> Reply-To: Jakub Jelinek References: <20130218230522.GB1215@tucnak.zalov.cz> <1C0E790D7E4C75418622FD04CC2A1172015D5C06@bamail02.ba.imgtec.org> <20130222100311.GJ1215@tucnak.zalov.cz> <1361554314.1732.17.camel@ubuntu-sellcey> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1361554314.1732.17.camel@ubuntu-sellcey> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2013-02/txt/msg01079.txt.bz2 On Fri, Feb 22, 2013 at 09:31:54AM -0800, Steve Ellcey wrote: > On Fri, 2013-02-22 at 11:03 +0100, Jakub Jelinek wrote: > > > The problem I believe is that Aldy has changed init_optabs and insn-opinit.c > > to use this_fn_optabs instead of this_target_optabs, but it is only set in > > invoke_set_current_function_hook. During save_target_globals we want to > > init this_target_optabs, so we need to temporarily switch this_fn_optabs to > > make that happen. > > > > 2013-02-22 Jakub Jelinek > > > > PR target/52555 > > * target-globals.c (save_target_globals): For init_reg_sets and > > target_reinit remporarily set this_fn_optabs to this_target_optabs. > > > > I built with this patch and ran the GCC testsuite (using the target > mips-mti-linux-gnu), it fixed the problem and caused no regressions for > me. Richard, is that ok for trunk then? Jakub