From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25368 invoked by alias); 5 Mar 2013 00:10:20 -0000 Received: (qmail 25238 invoked by uid 22791); 5 Mar 2013 00:10:14 -0000 X-SWARE-Spam-Status: No, hits=-9.3 required=5.0 tests=AWL,BAYES_00,KHOP_PGP_SIGNED,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 05 Mar 2013 00:10:08 +0000 Received: from vapier.localnet (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id 936AB33DB92; Tue, 5 Mar 2013 00:10:06 +0000 (UTC) From: Mike Frysinger To: Ian Lance Taylor Subject: Re: [PATCH 1/2] [pr53679] libgo: add a --enable-werror configure flag Date: Tue, 05 Mar 2013 00:10:00 -0000 User-Agent: KMail/1.13.7 (Linux/3.7.6; KDE/4.6.5; x86_64; ; ) Cc: gcc-patches@gcc.gnu.org References: <1356305421-13533-1-git-send-email-vapier@gentoo.org> <201301252220.39972.vapier@gentoo.org> In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart17485804.kDNz2CEopu"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201303041911.52652.vapier@gentoo.org> Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2013-03/txt/msg00149.txt.bz2 --nextPart17485804.kDNz2CEopu Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-length: 2620 On Saturday 26 January 2013 21:40:44 Ian Lance Taylor wrote: > On Fri, Jan 25, 2013 at 7:20 PM, Mike Frysinger wrote: > > On Friday 25 January 2013 19:13:55 Ian Lance Taylor wrote: > >> On Tue, Jan 15, 2013 at 9:45 AM, Mike Frysinger wrote: > >> > On Tuesday 15 January 2013 09:56:06 Ian Lance Taylor wrote: > >> >> On Sun, Dec 23, 2012 at 3:30 PM, Mike Frysinger wrote: > >> >> > diff --git a/libgo/configure.ac b/libgo/configure.ac > >> >> > index 8cde50b..63d8cbc 100644 > >> >> > --- a/libgo/configure.ac > >> >> > +++ b/libgo/configure.ac > >> >> > @@ -50,8 +50,11 @@ AC_PROG_AWK > >> >> >=20 > >> >> > WARN_FLAGS=3D'-Wall -Wextra -Wwrite-strings -Wcast-qual' > >> >> > AC_SUBST(WARN_FLAGS) > >> >> >=20 > >> >> > -dnl FIXME: This should be controlled by --enable-maintainer-mode. > >> >> > -WERROR=3D"-Werror" > >> >> > +AC_ARG_ENABLE(werror, [AS_HELP_STRING([--enable-werror], > >> >> > + [turns on -Werror > >> >> > @<:@default=3Dyes@:>@])]) +if test "x$enable_werror" !=3D "xno"; = then > >> >> > + WERROR=3D"-Werror" > >> >> > +fi > >> >> >=20 > >> >> > AC_SUBST(WERROR) > >> >> >=20=20 > >> >> > glibgo_toolexecdir=3Dno > >> >>=20 > >> >> Can you say something about when you needed this? What errors were > >> >> you seeing? > >> >=20 > >> > the referenced PR describes one: > >> > /build/src/gcc-4.7.1/libgo/runtime/print.c: In function 'gwrite': > >> > /build/src/gcc-4.7.1/libgo/runtime/print.c:20:3: error: ignoring > >> > return value of 'write', declared with attribute warn_unused_result > >> > [-Werror=3Dunused-result] cc1: all warnings being treated as errors > >> >=20 > >> > this bites distros that enable security settings by default (such as > >> > fortify and ssp). but ignoring even that, i don't believe releases > >> > should build all the time with -Werror -- i'm fine with defaulting to > >> > on as long as there is a configure flag to turn it off which is what > >> > this does like is already handled in much of the sourceware tree.=20 > >> > -Werror is great for development, but sucks when deployed on actual > >> > systems. the assumptions made at time of checkin rarely stay > >> > constant forever (in this case, a changing lib C can easily break > >> > it). -mike > >>=20 > >> Thanks for the explanation. > >>=20 > >> Committed to mainline. > >=20 > > thanks! mind if i commit it to gcc-4.6 and gcc-4.7 too ? >=20 > I certainly don't mind. You should probably get agreement from the > release managers although this seems safe enough. can you approve merges to the google branches ? that's really where i want= =20 this :). -mike --nextPart17485804.kDNz2CEopu Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. Content-length: 836 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (GNU/Linux) iQIcBAABAgAGBQJRNThIAAoJEEFjO5/oN/WBn1YP/Ay98A/dpe/hCNId8Zhx8Pvn iZZZyCDJa8jGRwOgXHSSfvY7Ugl4DapclnYh9fGtJqvEAiNyvM0BlTdnycLk6hLb Wnf0E38US/r8UPYeMuLsqgsnKE1ADfbjnPnBdMV8CunjHmmt/vTDbYnyDQvQ4eMl dBAta9njLS/k1NUaXhJzlUVBDF5UhKh7zl43P8Wy6NfTOK5JXm1b2SsBF/KwfK8W HgzWfTd5nyAEEfJHcoqVwdfYz4KrVmVyIsxUc6QqJLuteapNPN4+tgvgAH6t8QmX Lulj999gbwZBZR9oXUi6/ebCXe65oYIH+BKXF4lei4cFJim7PTGhEvOMv9jO78cs YP9Z9iZRHAm542HEgTm0t1UkSV77pImqcrKktK8XGP8K1JO+dkMwYTQnxdNtQvIc jUnpuATKs4JuMk7HSLnxahva0yCc2UsrVYjEX60WrQlrADhk1Y/frvoa5HD1FYe7 nK8t0wbzHU3UMB6tkXMYECoDMvXTszvynhQl+BZ+3Y2pH5gQCkiFSMCkdpUY2JOH Ij59AZNL7cupeo/1m8/Oo3UUWdphD93PfyZHsqwhaqZz2WiOGGxEYMm/xDD0HPRg iTr2B19OQp2U2wj91Zwf6US949bu24fn2/ida7ucgXQRjGfK5LpTjfzZ+Si5zyvR nWGzQeitW6AgN8V4RPqI =cIU8 -----END PGP SIGNATURE----- --nextPart17485804.kDNz2CEopu--