From: Mike Frysinger <vapier@gentoo.org>
To: Diego Novillo <dnovillo@google.com>
Cc: Ian Lance Taylor <iant@google.com>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH 1/2] [pr53679] libgo: add a --enable-werror configure flag
Date: Thu, 07 Mar 2013 06:59:00 -0000 [thread overview]
Message-ID: <201303070201.36265.vapier@gentoo.org> (raw)
In-Reply-To: <CAD_=9DS=wv=KWj8yB3zW-JQNoJwW95ADznM75bm2FENYFC9e=A@mail.gmail.com>
[-- Attachment #1: Type: Text/Plain, Size: 3479 bytes --]
On Wednesday 06 March 2013 10:49:23 Diego Novillo wrote:
> On Tue, Mar 5, 2013 at 12:31 AM, Ian Lance Taylor <iant@google.com> wrote:
> > On Mon, Mar 4, 2013 at 4:11 PM, Mike Frysinger <vapier@gentoo.org> wrote:
> > > On Saturday 26 January 2013 21:40:44 Ian Lance Taylor wrote:
> > >> On Fri, Jan 25, 2013 at 7:20 PM, Mike Frysinger wrote:
> > >> > On Friday 25 January 2013 19:13:55 Ian Lance Taylor wrote:
> > >> >> On Tue, Jan 15, 2013 at 9:45 AM, Mike Frysinger wrote:
> > >> >> > On Tuesday 15 January 2013 09:56:06 Ian Lance Taylor wrote:
> > >> >> >> On Sun, Dec 23, 2012 at 3:30 PM, Mike Frysinger wrote:
> > >> >> >> > diff --git a/libgo/configure.ac b/libgo/configure.ac
> > >> >> >> > index 8cde50b..63d8cbc 100644
> > >> >> >> > --- a/libgo/configure.ac
> > >> >> >> > +++ b/libgo/configure.ac
> > >> >> >> > @@ -50,8 +50,11 @@ AC_PROG_AWK
> > >> >> >> >
> > >> >> >> > WARN_FLAGS='-Wall -Wextra -Wwrite-strings -Wcast-qual'
> > >> >> >> > AC_SUBST(WARN_FLAGS)
> > >> >> >> >
> > >> >> >> > -dnl FIXME: This should be controlled by
> > >> >> >> > --enable-maintainer-mode.
> > >> >> >> > -WERROR="-Werror"
> > >> >> >> > +AC_ARG_ENABLE(werror, [AS_HELP_STRING([--enable-werror],
> > >> >> >> > + [turns on -Werror
> > >> >> >> > @<:@default=yes@:>@])]) +if test "x$enable_werror" != "xno";
> > >> >> >> > then
> > >> >> >> > + WERROR="-Werror"
> > >> >> >> > +fi
> > >> >> >> >
> > >> >> >> > AC_SUBST(WERROR)
> > >> >> >> >
> > >> >> >> > glibgo_toolexecdir=no
> > >> >> >>
> > >> >> >> Can you say something about when you needed this? What errors
> > >> >> >> were
> > >> >> >> you seeing?
> > >> >> >
> > >> >> > the referenced PR describes one:
> > >> >> > /build/src/gcc-4.7.1/libgo/runtime/print.c: In function 'gwrite':
> > >> >> > /build/src/gcc-4.7.1/libgo/runtime/print.c:20:3: error: ignoring
> > >> >> > return value of 'write', declared with attribute
> > >> >> > warn_unused_result
> > >> >> > [-Werror=unused-result] cc1: all warnings being treated as errors
> > >> >> >
> > >> >> > this bites distros that enable security settings by default (such
> > >> >> > as
> > >> >> > fortify and ssp). but ignoring even that, i don't believe
> > >> >> > releases
> > >> >> > should build all the time with -Werror -- i'm fine with
> > >> >> > defaulting to
> > >> >> > on as long as there is a configure flag to turn it off which is
> > >> >> > what
> > >> >> > this does like is already handled in much of the sourceware tree.
> > >> >> > -Werror is great for development, but sucks when deployed on
> > >> >> > actual
> > >> >> > systems. the assumptions made at time of checkin rarely stay
> > >> >> > constant forever (in this case, a changing lib C can easily break
> > >> >> > it). -mike
> > >> >>
> > >> >> Thanks for the explanation.
> > >> >>
> > >> >> Committed to mainline.
> > >> >
> > >> > thanks! mind if i commit it to gcc-4.6 and gcc-4.7 too ?
> > >>
> > >> I certainly don't mind. You should probably get agreement from the
> > >> release managers although this seems safe enough.
> > >
> > > can you approve merges to the google branches ? that's really where i
> > > want
> > > this :).
> >
> > No, I don't work on those branches. Sorry.
>
> I committed this patch to google/gcc-4_7 rev 196494. Feel free to
> commit to google/gcc-4_6 if you need to.
nope, we just need it in 4.7, thanks!
-mike
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2013-03-07 6:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-23 23:30 Mike Frysinger
2012-12-23 23:30 ` [PATCH 2/2] [pr32193] libgomp: " Mike Frysinger
2013-01-15 14:56 ` [PATCH 1/2] [pr53679] libgo: " Ian Lance Taylor
2013-01-15 17:42 ` Mike Frysinger
2013-01-26 0:14 ` Ian Lance Taylor
2013-01-26 3:21 ` Mike Frysinger
2013-01-27 2:40 ` Ian Lance Taylor
2013-03-05 0:10 ` Mike Frysinger
2013-03-05 5:31 ` Ian Lance Taylor
2013-03-06 15:49 ` Diego Novillo
2013-03-07 6:59 ` Mike Frysinger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201303070201.36265.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=dnovillo@google.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=iant@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).