From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10568 invoked by alias); 7 Mar 2013 06:59:39 -0000 Received: (qmail 10560 invoked by uid 22791); 7 Mar 2013 06:59:38 -0000 X-SWARE-Spam-Status: No, hits=-9.3 required=5.0 tests=AWL,BAYES_00,KHOP_PGP_SIGNED,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 07 Mar 2013 06:59:31 +0000 Received: from vapier.localnet (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id D195833DEA1; Thu, 7 Mar 2013 06:59:30 +0000 (UTC) From: Mike Frysinger To: Diego Novillo Subject: Re: [PATCH 1/2] [pr53679] libgo: add a --enable-werror configure flag Date: Thu, 07 Mar 2013 06:59:00 -0000 User-Agent: KMail/1.13.7 (Linux/3.7.6; KDE/4.6.5; x86_64; ; ) Cc: Ian Lance Taylor , gcc-patches@gcc.gnu.org References: <1356305421-13533-1-git-send-email-vapier@gentoo.org> In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart4074070.IlAbG5GKNp"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201303070201.36265.vapier@gentoo.org> Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2013-03/txt/msg00281.txt.bz2 --nextPart4074070.IlAbG5GKNp Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-length: 3459 On Wednesday 06 March 2013 10:49:23 Diego Novillo wrote: > On Tue, Mar 5, 2013 at 12:31 AM, Ian Lance Taylor wrote: > > On Mon, Mar 4, 2013 at 4:11 PM, Mike Frysinger wrot= e: > > > On Saturday 26 January 2013 21:40:44 Ian Lance Taylor wrote: > > >> On Fri, Jan 25, 2013 at 7:20 PM, Mike Frysinger wrote: > > >> > On Friday 25 January 2013 19:13:55 Ian Lance Taylor wrote: > > >> >> On Tue, Jan 15, 2013 at 9:45 AM, Mike Frysinger wrote: > > >> >> > On Tuesday 15 January 2013 09:56:06 Ian Lance Taylor wrote: > > >> >> >> On Sun, Dec 23, 2012 at 3:30 PM, Mike Frysinger wrote: > > >> >> >> > diff --git a/libgo/configure.ac b/libgo/configure.ac > > >> >> >> > index 8cde50b..63d8cbc 100644 > > >> >> >> > --- a/libgo/configure.ac > > >> >> >> > +++ b/libgo/configure.ac > > >> >> >> > @@ -50,8 +50,11 @@ AC_PROG_AWK > > >> >> >> >=20 > > >> >> >> > WARN_FLAGS=3D'-Wall -Wextra -Wwrite-strings -Wcast-qual' > > >> >> >> > AC_SUBST(WARN_FLAGS) > > >> >> >> >=20 > > >> >> >> > -dnl FIXME: This should be controlled by > > >> >> >> > --enable-maintainer-mode. > > >> >> >> > -WERROR=3D"-Werror" > > >> >> >> > +AC_ARG_ENABLE(werror, [AS_HELP_STRING([--enable-werror], > > >> >> >> > + [turns on -Werror > > >> >> >> > @<:@default=3Dyes@:>@])]) +if test "x$enable_werror" !=3D "x= no"; > > >> >> >> > then > > >> >> >> > + WERROR=3D"-Werror" > > >> >> >> > +fi > > >> >> >> >=20 > > >> >> >> > AC_SUBST(WERROR) > > >> >> >> >=20=20 > > >> >> >> > glibgo_toolexecdir=3Dno > > >> >> >>=20 > > >> >> >> Can you say something about when you needed this? What errors > > >> >> >> were > > >> >> >> you seeing? > > >> >> >=20 > > >> >> > the referenced PR describes one: > > >> >> > /build/src/gcc-4.7.1/libgo/runtime/print.c: In function 'gwrite= ': > > >> >> > /build/src/gcc-4.7.1/libgo/runtime/print.c:20:3: error: ignoring > > >> >> > return value of 'write', declared with attribute > > >> >> > warn_unused_result > > >> >> > [-Werror=3Dunused-result] cc1: all warnings being treated as er= rors > > >> >> >=20 > > >> >> > this bites distros that enable security settings by default (su= ch > > >> >> > as > > >> >> > fortify and ssp). but ignoring even that, i don't believe > > >> >> > releases > > >> >> > should build all the time with -Werror -- i'm fine with > > >> >> > defaulting to > > >> >> > on as long as there is a configure flag to turn it off which is > > >> >> > what > > >> >> > this does like is already handled in much of the sourceware tre= e. > > >> >> > -Werror is great for development, but sucks when deployed on > > >> >> > actual > > >> >> > systems. the assumptions made at time of checkin rarely stay > > >> >> > constant forever (in this case, a changing lib C can easily bre= ak > > >> >> > it). -mike > > >> >>=20 > > >> >> Thanks for the explanation. > > >> >>=20 > > >> >> Committed to mainline. > > >> >=20 > > >> > thanks! mind if i commit it to gcc-4.6 and gcc-4.7 too ? > > >>=20 > > >> I certainly don't mind. You should probably get agreement from the > > >> release managers although this seems safe enough. > > >=20 > > > can you approve merges to the google branches ? that's really where i > > > want > > > this :). > >=20 > > No, I don't work on those branches. Sorry. >=20 > I committed this patch to google/gcc-4_7 rev 196494. Feel free to > commit to google/gcc-4_6 if you need to. nope, we just need it in 4.7, thanks! -mike --nextPart4074070.IlAbG5GKNp Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. Content-length: 836 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (GNU/Linux) iQIcBAABAgAGBQJRODtQAAoJEEFjO5/oN/WBdQAQAOPIG+av/6RcU0ckC1ltKTF/ SeLggt6/dovvV6FgbaSCY6vcvwWTyM33vG2V7bHD4JIMgCVvNF4JA74U8V1DA0WS O29FzQaKGj6i/03T7VIDXHYL/CEzWHyF0OaVHo1/SYYmBD1can+mq79vT4BFXu/K D2m+ozasdFFmKJJf4m8B5Q+BJjQY4xGMQ7PAbxzID/QfHYjHpl+NZLxLpjbUowsE xuIFlGdS19ZM1zZuhIPvfgrPrL4iM5wmc6qAq0Qxd4K96gLrQG01dVDYak1RFSSN xgGXwkaQGhWJ/FXJmhc+N7pCzu8nTnR067K2vhkbKBrpK/PZz472crPjL/hB5ChE na60wknp1FQDuDCET7/MHDsu5rRsDgbuwkih1lwjODJoLW8ZZihcLh0OKu2Osmkr /T975XwtPH34xGfcKjgYtMjthHmsZWpg7gqG4xQeNMb45daDLzJWP9RcOhUicaBb oqG4LXQc1tPxoI6vFZwGW4omqaI/TwPx6fs9b5KnwFzs73r/rnuI3pluizp8x5qw vUL8gjVjXldtkgKMAHjVua33WTGoZALVsUSPpezPFeAKtYXXS32AJDtGr1ypJ3zI o0uGJT/wsA4YHK2FODKqwnKBa/hwcnYg6HnALfNM8Ud6D+OYUOoGYB5eVBdfCX7X Kn1lwxqzpUQlj2Ceft4u =w64V -----END PGP SIGNATURE----- --nextPart4074070.IlAbG5GKNp--