From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17248 invoked by alias); 19 Mar 2013 17:30:37 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 15455 invoked by uid 89); 19 Mar 2013 17:30:22 -0000 X-Spam-Sware-Status: No, score=-3.9 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD autolearn=ham version=3.3.1 X-Spam-User: qpsmtpd, 2 recipients Received: from two.firstfloor.org (HELO one.firstfloor.org) (193.170.194.197) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 19 Mar 2013 17:30:20 +0000 Received: by one.firstfloor.org (Postfix, from userid 503) id 5D03D8675D; Tue, 19 Mar 2013 18:30:16 +0100 (CET) Date: Tue, 19 Mar 2013 17:30:00 -0000 From: Andi Kleen To: Jakub Jelinek Cc: Andi Kleen , Jonathan Wakely , Andi Kleen , gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org, rth@redhat.com Subject: Re: [PATCH 1/4] Mark all member functions with memory models always inline Message-ID: <20130319173016.GF20853@two.firstfloor.org> References: <1363440569-17331-1-git-send-email-andi@firstfloor.org> <20130319064639.GA12913@tucnak.redhat.com> <20130319155121.GM19692@tassilo.jf.intel.com> <20130319161022.GE12913@tucnak.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130319161022.GE12913@tucnak.redhat.com> User-Agent: Mutt/1.5.20 (2009-06-14) X-SW-Source: 2013-03/txt/msg00696.txt.bz2 On Tue, Mar 19, 2013 at 05:10:22PM +0100, Jakub Jelinek wrote: > On Tue, Mar 19, 2013 at 08:51:21AM -0700, Andi Kleen wrote: > > > Using __always_inline as the name of the macro is a bad idea, glibc > > > headers use that macro already. Just use something else in public headers > > > that aren't part of glibc. > > > > That's why I had the ifdef, but ok. I'll use __force_inline then. > > I'd say Jonathan's _GLIBCXX_ALWAYS_INLINE would be better. > > BTW, have you verified always_inline works fine for -O0? I did some simple tests and it seemed to work. But thanks for the counter example. > > with -O0 -mhle doesn't result in xacquire, guess for !optimize > get_memmodel would need to look through chain of SSA_NAMEs if SSA_NAME > (that can appear because of inlining), looking for INTEGER_CSTs. interesting. so need more fixes. i'll look into that. Is there already a convenient helper for it? There was an alternative approach of using a template, but I suppose that would have the same problem. -Andi