From: Jakub Jelinek <jakub@redhat.com>
To: Jeff Law <law@redhat.com>
Cc: Aldy Hernandez <aldyh@redhat.com>,
"Joseph S. Myers" <joseph@codesourcery.com>,
"Iyer, Balaji V" <balaji.v.iyer@intel.com>,
gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [patch] cilkplus array notation for C (clean, independent patchset, take 1)
Date: Thu, 21 Mar 2013 06:09:00 -0000 [thread overview]
Message-ID: <20130321060933.GQ12913@tucnak.redhat.com> (raw)
In-Reply-To: <514A9B12.8050502@redhat.com>
On Wed, Mar 20, 2013 at 11:30:58PM -0600, Jeff Law wrote:
> On 03/20/2013 10:33 AM, Aldy Hernandez wrote:
> >As I'd mentioned, you have .exp files named compile.exp and execute.exp
> >which seem to be causing ambiguity problems in parallel checks (make
> >check -jN). For some reason, with this patch, the rest of dg.exp fails
> >to run after Cilkplus' compile/execute.exp runs. Renaming these to
> >something less generic does the trick. Do you mind prefixing all the
> >.exp's with "cilkplus_" or something similar?
Renaming is desirable anyway, people who run make check-gcc
execute.exp=something don't expect to run also some subset of cilk+ tests.
The Makefile runs some execute.exp=2* and similar when parallelized, see
check_gcc_parallelize in gcc/Makefile.in.
Anyway, have you tested that without parallelization make check doesn't skip
some tests? Often when a new *.exp file say sets some globals and never
resets them, this could affect following *.exp files.
Jakub
next prev parent reply other threads:[~2013-03-21 6:09 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-20 15:32 Aldy Hernandez
2013-03-20 16:33 ` Aldy Hernandez
2013-03-20 22:28 ` Iyer, Balaji V
2013-03-21 12:55 ` Aldy Hernandez
2013-03-21 5:31 ` Jeff Law
2013-03-21 6:09 ` Jakub Jelinek [this message]
2013-03-21 13:01 ` Aldy Hernandez
2013-03-21 13:06 ` Iyer, Balaji V
2013-03-21 13:09 ` Aldy Hernandez
2013-03-21 13:15 ` Iyer, Balaji V
2013-03-21 16:54 ` Mike Stump
2013-03-21 23:34 ` Aldy Hernandez
2013-03-22 22:36 ` Mike Stump
2013-03-23 1:36 ` Iyer, Balaji V
2013-03-23 5:00 ` Mike Stump
2013-03-20 22:00 ` [cilkplus-merge] test for side effects Aldy Hernandez
2013-03-21 14:25 ` [patch] cilkplus array notation for C (clean, independent patchset, take 1) Aldy Hernandez
2013-03-21 19:08 ` Iyer, Balaji V
2013-03-21 23:30 ` Aldy Hernandez
2013-03-21 15:56 ` Joseph S. Myers
2013-03-22 22:04 ` Iyer, Balaji V
2013-03-25 16:45 ` Aldy Hernandez
2013-03-25 21:39 ` Iyer, Balaji V
2013-03-25 21:49 ` Aldy Hernandez
2013-03-26 17:05 ` Joseph S. Myers
2013-03-26 21:11 ` Iyer, Balaji V
2013-03-26 16:27 ` Joseph S. Myers
2013-03-21 16:48 ` Joseph S. Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130321060933.GQ12913@tucnak.redhat.com \
--to=jakub@redhat.com \
--cc=aldyh@redhat.com \
--cc=balaji.v.iyer@intel.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=joseph@codesourcery.com \
--cc=law@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).