From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32026 invoked by alias); 21 Mar 2013 06:09:54 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 31979 invoked by uid 89); 21 Mar 2013 06:09:46 -0000 X-Spam-SWARE-Status: No, score=-8.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Thu, 21 Mar 2013 06:09:44 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r2L69fWd032262 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 21 Mar 2013 02:09:41 -0400 Received: from zalov.cz (vpn-55-62.rdu2.redhat.com [10.10.55.62]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r2L69cRI007119 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 21 Mar 2013 02:09:40 -0400 Received: from zalov.cz (localhost [127.0.0.1]) by zalov.cz (8.14.5/8.14.5) with ESMTP id r2L69btQ024385; Thu, 21 Mar 2013 07:09:37 +0100 Received: (from jakub@localhost) by zalov.cz (8.14.5/8.14.5/Submit) id r2L69YPc024384; Thu, 21 Mar 2013 07:09:34 +0100 Date: Thu, 21 Mar 2013 06:09:00 -0000 From: Jakub Jelinek To: Jeff Law Cc: Aldy Hernandez , "Joseph S. Myers" , "Iyer, Balaji V" , gcc-patches Subject: Re: [patch] cilkplus array notation for C (clean, independent patchset, take 1) Message-ID: <20130321060933.GQ12913@tucnak.redhat.com> Reply-To: Jakub Jelinek References: <5149D62F.9070503@redhat.com> <5149E4C7.1090206@redhat.com> <514A9B12.8050502@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <514A9B12.8050502@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2013-03/txt/msg00780.txt.bz2 On Wed, Mar 20, 2013 at 11:30:58PM -0600, Jeff Law wrote: > On 03/20/2013 10:33 AM, Aldy Hernandez wrote: > >As I'd mentioned, you have .exp files named compile.exp and execute.exp > >which seem to be causing ambiguity problems in parallel checks (make > >check -jN). For some reason, with this patch, the rest of dg.exp fails > >to run after Cilkplus' compile/execute.exp runs. Renaming these to > >something less generic does the trick. Do you mind prefixing all the > >.exp's with "cilkplus_" or something similar? Renaming is desirable anyway, people who run make check-gcc execute.exp=something don't expect to run also some subset of cilk+ tests. The Makefile runs some execute.exp=2* and similar when parallelized, see check_gcc_parallelize in gcc/Makefile.in. Anyway, have you tested that without parallelization make check doesn't skip some tests? Often when a new *.exp file say sets some globals and never resets them, this could affect following *.exp files. Jakub