From: Michael Meissner <meissner@linux.vnet.ibm.com>
To: David Edelsohn <dje.gcc@gmail.com>
Cc: Michael Meissner <meissner@linux.vnet.ibm.com>,
GCC Patches <gcc-patches@gcc.gnu.org>,
Pat Haugen <pthaugen@us.ibm.com>,
Peter Bergner <bergner@vnet.ibm.com>
Subject: Re: [PATCH, rs6000] power8 patches, patch #7, quad/byte/half-word atomic instructions
Date: Wed, 29 May 2013 20:36:00 -0000 [thread overview]
Message-ID: <20130529203617.GC24280@ibm-tiger.the-meissners.org> (raw)
In-Reply-To: <CAGWvnyk1qJvPPimXRDQs_mJGZo=_U7N9y+s_D6wf7_z_w2dOEw@mail.gmail.com>
On Wed, May 29, 2013 at 04:29:07PM -0400, David Edelsohn wrote:
> - if (mode == QImode || mode == HImode)
> + /* On power8, we want to use SImode for the operation. On previoius systems,
> + use the operation in a subword and shift/mask to get the proper byte or
> + halfword. */
> + if (TARGET_SYNC_HI_QI && (mode == QImode || mode == HImode))
> + {
> + val = convert_modes (SImode, mode, val, 1);
> +
> + /* Prepare to adjust the return value. */
> + before = gen_reg_rtx (SImode);
> + if (after)
> + after = gen_reg_rtx (SImode);
> + mode = SImode;
> + }
> + else if (mode == QImode || mode == HImode)
>
> Spelling: previoius.
Thanks.
> This logic is redundant. Why not
>
> if (mode == QImode || mode == HImode)
> {
> if (TARGET_SYNC_HI_QI)
> {
> new code
> }
> else
> {
> original code
> }
>
> The rest of this patch is okay.
I can do that. I think earlier versions did it that way.
--
Michael Meissner, IBM
IBM, M/S 2506R, 550 King Street, Littleton, MA 01460, USA
email: meissner@linux.vnet.ibm.com, phone: +1 (978) 899-4797
next prev parent reply other threads:[~2013-05-29 20:36 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-20 20:41 [PATCH, rs6000] power8 patches Michael Meissner
2013-05-20 20:49 ` [PATCH, rs6000] power8 patch #1, infrastructure changes Michael Meissner
2013-05-20 21:34 ` [PATCH, rs6000] power8 patch #1, infrastructure changes (revised patch) Michael Meissner
2013-05-22 3:29 ` David Edelsohn
2013-05-20 23:13 ` [PATCH, rs6000] power8 patches, patch #2, add crypto builtins Michael Meissner
2013-05-22 3:30 ` David Edelsohn
2013-05-23 3:41 ` David Edelsohn
2013-05-23 3:59 ` Michael Meissner
2013-05-25 4:07 ` David Edelsohn
2013-05-30 21:04 ` Michael Meissner
2013-05-21 2:11 ` [PATCH, rs6000] power8 patches Peter Bergner
2013-05-21 15:51 ` [PATCH, rs6000] power8 patches, patch #3, add V2DI vector support Michael Meissner
2013-05-23 16:31 ` David Edelsohn
2013-05-21 23:47 ` [PATCH, rs6000] power8 patches, patch #4, new power8 builtins Michael Meissner
2013-05-25 4:03 ` David Edelsohn
2013-05-30 23:26 ` Michael Meissner
2013-05-31 9:14 ` Segher Boessenkool
2013-05-31 15:11 ` Michael Meissner
2013-06-04 18:49 ` [PATCH, rs6000] power8 patches, patch #4 (revised), " Michael Meissner
2013-06-05 14:28 ` David Edelsohn
2013-06-05 15:50 ` Segher Boessenkool
2013-06-05 16:05 ` Michael Meissner
2013-06-05 20:06 ` Segher Boessenkool
2013-06-05 20:24 ` Michael Meissner
2013-06-05 16:13 ` Michael Meissner
2013-06-05 17:28 ` David Edelsohn
2013-06-06 15:57 ` David Edelsohn
2013-06-06 21:42 ` Michael Meissner
2013-07-15 21:48 ` Michael Meissner
2013-07-20 19:12 ` David Edelsohn
2013-07-23 21:24 ` Michael Meissner
2013-05-21 23:49 ` [PATCH, rs6000] power8 patches, patch #5, new vector tests Michael Meissner
2013-06-06 21:51 ` Michael Meissner
2013-05-22 14:26 ` [PATCH, rs6000] power8 patches, patch #6, direct move & basic quad load/store Michael Meissner
2013-05-29 19:53 ` David Edelsohn
2013-05-29 20:32 ` Michael Meissner
2013-06-10 15:41 ` David Edelsohn
2013-06-10 20:26 ` Michael Meissner
2013-05-22 16:51 ` [PATCH, rs6000] power8 patches, patch #7, quad/byte/half-word atomic instructions Michael Meissner
2013-05-29 20:29 ` David Edelsohn
2013-05-29 20:36 ` Michael Meissner [this message]
2013-06-11 23:56 ` Michael Meissner
2013-06-12 21:55 ` David Edelsohn
2013-05-22 20:53 ` [PATCH, rs6000] power8 patches, patch #8, power8 load fusion + misc Michael Meissner
2013-06-18 18:30 ` David Edelsohn
2013-06-24 16:32 ` Michael Meissner
2013-06-24 19:43 ` David Edelsohn
2013-07-29 18:46 ` [PATCH, rs6000] power8 patches, revised patch #8, power8 load fusion Michael Meissner
2013-07-31 16:00 ` David Edelsohn
2013-11-23 16:48 ` Alan Modra
2013-06-07 19:22 ` [PATCH, rs6000] power8 patches, patch #9, power8 scheduling Pat Haugen
2013-06-19 13:00 ` David Edelsohn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130529203617.GC24280@ibm-tiger.the-meissners.org \
--to=meissner@linux.vnet.ibm.com \
--cc=bergner@vnet.ibm.com \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=pthaugen@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).