From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10093 invoked by alias); 30 May 2013 13:44:47 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 10076 invoked by uid 89); 30 May 2013 13:44:46 -0000 X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.1 X-Spam-User: qpsmtpd, 2 recipients Received: from mel.act-europe.fr (HELO smtp.eu.adacore.com) (194.98.77.210) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Thu, 30 May 2013 13:44:28 +0000 Received: from localhost (localhost [127.0.0.1]) by filtered-smtp.eu.adacore.com (Postfix) with ESMTP id E58C32648C5F; Thu, 30 May 2013 15:42:51 +0200 (CEST) Received: from smtp.eu.adacore.com ([127.0.0.1]) by localhost (smtp.eu.adacore.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id l-936gwfRj3T; Thu, 30 May 2013 15:42:51 +0200 (CEST) Received: from chelles.act-europe.fr (chelles.act-europe.fr [10.10.0.160]) by smtp.eu.adacore.com (Postfix) with ESMTP id 9BF182648C50; Thu, 30 May 2013 15:42:51 +0200 (CEST) Received: by chelles.act-europe.fr (Postfix, from userid 525) id 09CAA1EA005E; Thu, 30 May 2013 15:44:26 +0200 (CEST) Date: Thu, 30 May 2013 13:44:00 -0000 From: Arnaud Charlet To: Paolo Bonzini Cc: Thomas Schwinge , gcc-patches@gcc.gnu.org, Rainer Orth , ebotcazou@adacore.com, obry@adacore.com, dj@redhat.com, neroden@gcc.gnu.org, aoliva@redhat.com, Ralf.Wildenhues@gmx.de, Arnaud Charlet Subject: Re: [ada, build] host/target configuration Message-ID: <20130530134425.GA15756@adacore.com> References: <87txlnlg0z.fsf@kepler.schwinge.homeip.net> <87zjvejc02.fsf@kepler.schwinge.homeip.net> <51A60EF2.5000605@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <51A60EF2.5000605@gnu.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2013-05/txt/msg01780.txt.bz2 > >>> The target_cpu_canonical substitution has been added in commit > >>> 369e542b3ad1c0acfa9bfaeb72b338d8db5ba2ef (2009-02-27, r144463, > >>> schwab) but unused ever since, thus removed. > >>> > >>> I'll now be testing for x86 GNU/Linux and GNU/Hurd; further > >>> testing appreciated. > > For these two configurations, I have now successfully tested the > > patch I posted. Further review/testing appreciated. (Adding > > »build machinery (*.in)« maintainers.) > > > > > > I agree that using $(target_os) and linux% matches is a better way to > strip out the "-gnu"s. > > The patch is long, but I think I reviewed it carefully enough. It's > okay for mainline. Not so fast, we are talking about the Ada build machinery which requires an Ada maintainer to review it. The patch seems to go in the right direction but needs careful review which hasn't been done yet, so please hold on your change for now, thanks. In other words, this change will impact basically all targets, so needs either much more testing, or more review, which is on going. Arno