From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25394 invoked by alias); 30 May 2013 21:04:48 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 25384 invoked by uid 89); 30 May 2013 21:04:48 -0000 X-Spam-SWARE-Status: No, score=-3.7 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL autolearn=ham version=3.3.1 Received: from e38.co.us.ibm.com (HELO e38.co.us.ibm.com) (32.97.110.159) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Thu, 30 May 2013 21:04:47 +0000 Received: from /spool/local by e38.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 30 May 2013 15:04:45 -0600 Received: from d03dlp03.boulder.ibm.com (9.17.202.179) by e38.co.us.ibm.com (192.168.1.138) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Thu, 30 May 2013 15:04:40 -0600 Received: from d03relay04.boulder.ibm.com (d03relay04.boulder.ibm.com [9.17.195.106]) by d03dlp03.boulder.ibm.com (Postfix) with ESMTP id ADF7A19D804E for ; Thu, 30 May 2013 15:04:31 -0600 (MDT) Received: from d03av06.boulder.ibm.com (d03av06.boulder.ibm.com [9.17.195.245]) by d03relay04.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r4UL4WiW338146 for ; Thu, 30 May 2013 15:04:32 -0600 Received: from d03av06.boulder.ibm.com (loopback [127.0.0.1]) by d03av06.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r4UL7bnE019950 for ; Thu, 30 May 2013 15:07:37 -0600 Received: from ibm-tiger.the-meissners.org (dhcp-9-32-77-206.usma.ibm.com [9.32.77.206]) by d03av06.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id r4UL7a56019888; Thu, 30 May 2013 15:07:37 -0600 Received: by ibm-tiger.the-meissners.org (Postfix, from userid 500) id 46AB042665; Thu, 30 May 2013 17:04:00 -0400 (EDT) Date: Thu, 30 May 2013 21:04:00 -0000 From: Michael Meissner To: David Edelsohn Cc: Michael Meissner , GCC Patches , Pat Haugen , Peter Bergner Subject: Re: [PATCH, rs6000] power8 patches, patch #2, add crypto builtins Message-ID: <20130530210359.GA29408@ibm-tiger.the-meissners.org> Mail-Followup-To: Michael Meissner , David Edelsohn , GCC Patches , Pat Haugen , Peter Bergner References: <20130520204053.GA21090@ibm-tiger.the-meissners.org> <20130520231307.GA538@ibm-tiger.the-meissners.org> <20130523035946.GA29062@ibm-tiger.the-meissners.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-12-10) X-TM-AS-MML: No X-Content-Scanned: Fidelis XPS MAILER x-cbid: 13053021-5518-0000-0000-00000F32D692 X-SW-Source: 2013-05/txt/msg01809.txt.bz2 On Sat, May 25, 2013 at 12:07:32AM -0400, David Edelsohn wrote: > [gcc/testsuite] > 2013-05-20 Michael Meissner > > * gcc.target/powerpc/crypto-builtin-1.c: New file, test for power8 > crypto builtins. > > The testcase needs to check something more than > > /* { dg-require-effective-target powerpc_vsx_ok } */ > > I don't know if we need to separate the new VSX operations from the > crypto opterations, but the new testcases need to ensure that the > assembler and/or processor support the new instructions. I believe I did this test before adding powerpc_p8vector_ok in patch #5. Thanks for noticing it. I think I'll commit the target-supports.exp change and then change this test to use powerpc_p8vector_ok unless you have objections to the target-supports.exp part of the patch. I don't think it is important enough to have a separate category for crypto vs. the other p8 vector stuff, since the assembler change added both at the same time. -- Michael Meissner, IBM IBM, M/S 2506R, 550 King Street, Littleton, MA 01460, USA email: meissner@linux.vnet.ibm.com, phone: +1 (978) 899-4797