From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 503 invoked by alias); 2 Aug 2013 09:50:13 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 493 invoked by uid 89); 2 Aug 2013 09:50:13 -0000 X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_50,KHOP_RCVD_UNTRUST,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RDNS_NONE autolearn=no version=3.3.1 Received: from Unknown (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Fri, 02 Aug 2013 09:50:13 +0000 Received: from relay1.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 24B7DA52BF; Fri, 2 Aug 2013 11:50:05 +0200 (CEST) Date: Fri, 02 Aug 2013 09:50:00 -0000 From: Martin Jambor To: Jan Hubicka Cc: gcc-patches@gcc.gnu.org Subject: Re: Do not use PARM_DECLs in ipa-cp and ipa-prop Message-ID: <20130802095004.GC2728@virgil.suse> Mail-Followup-To: Jan Hubicka , gcc-patches@gcc.gnu.org References: <20130801131135.GB22179@kam.mff.cuni.cz> <20130801153627.GA2728@virgil.suse> <20130801154820.GB8408@kam.mff.cuni.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20130801154820.GB8408@kam.mff.cuni.cz> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2013-08/txt/msg00073.txt.bz2 Hi, On Thu, Aug 01, 2013 at 05:48:20PM +0200, Jan Hubicka wrote: > > On Thu, Aug 01, 2013 at 03:11:36PM +0200, Jan Hubicka wrote: > > > Hi, > > > this is preparation work to move DECL_ARGUMENTS and DECL_RESULT into function > > > sections during WPA. Even with some work to release unused ones, there are 4M > > > of PARM_DECLs and 2M of RESULT_DECLs streamed during LTO (for 6M of > > > function_decls) making them one of the most common nodes. > > > > > > This patch makes ipa-cp and ipa-prop to not use DECL_ARGUMENTS during WPA > > > stage. this only needed to tamn debug info, move logic doing casts from > > > get_replacement_map to tree_function_versioning and stream move_cost that is > > > computed form parm type. > > > > > > Martin, does this patch look OK? > > > > > > > Generally yes, except that I think you did not convert some dumping in > > ipa-cp.c, at least in functions estimate_local_effects, > > find_more_scalar_values_for_callers_subset and decide_about_value. I > > believe that after your change there should not be a single call to > > ipa_get_param in file ipa-cp.c. > > Hmm, I was aware of that while making the patch but then forgot. > OK, I will convert these too (and the testsuite) and commit. > (alternative I was thining of having ipa_dump_param helper that will > dump "parm 4" in WPA mode and "parm 4 (parmname)" in non-WPA). Do > you think it would be useful? Yes, I think it would be very convenient. > We probably should comonnize syntax of dumps in between ipa-prop > and ipa-inline-analysis predicates (that currently use op4 syntax and call the > parameters operands). Something to track incrementally anyway. > Indeed. Thanks, Martin