From: Trevor Saunders <tsaunders@mozilla.com>
To: Gabriel Dos Reis <gdr@integrable-solutions.net>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH 1/2] make the c++ pretty printer inherit from the C one instead of include it
Date: Mon, 05 Aug 2013 01:40:00 -0000 [thread overview]
Message-ID: <20130805013749.GA25293@tsaunders-iceball.corp.tor1.mozilla.com> (raw)
In-Reply-To: <CAAiZkiDQ1=0XdKhOtNT0RXTiF+Bs-Aa4wAdLfjpOj86psFCEBA@mail.gmail.com>
On Wed, Jul 31, 2013 at 10:02:29PM -0500, Gabriel Dos Reis wrote:
> * declare the "pointer to function fields" as virtual functions --
> that is what I meant
> with the (necessarily poor) emulation through the casts.
I guess you'll work on this later in the patch series you're sending,
but its worth noting making pretty_print_info::format_decoder a virtual
function is non-trivial, it turns out to be important that some
consumers can leave it null instead of making it what is currently
default_tree_printer. This is because gcov and maybe other things link
against diagnostic.c and pretty-print.c but not all the tree stuff that
would be required for default_tree_printer.
Trev
> * override those that needed to be overridden in cxx_pretty_printer.
> * adjust the macros.
> * Have the associated constructors do the right thing.
>
>
>
> -- Gaby
next prev parent reply other threads:[~2013-08-05 1:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-01 1:20 start cleaning up the pretty printers Trevor Saunders
2013-08-01 1:20 ` [PATCH 2/2] rm pp_c_base sub classes should just inherit from c_pretty_printer and things should just work Trevor Saunders
2013-08-01 3:04 ` Gabriel Dos Reis
2013-08-01 1:20 ` [PATCH 1/2] make the c++ pretty printer inherit from the C one instead of include it Trevor Saunders
2013-08-01 3:02 ` Gabriel Dos Reis
2013-08-01 3:21 ` Trevor Saunders
2013-08-01 3:48 ` Gabriel Dos Reis
2013-08-05 1:40 ` Trevor Saunders [this message]
2013-08-05 2:54 ` Gabriel Dos Reis
2013-08-01 3:04 ` start cleaning up the pretty printers Gabriel Dos Reis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130805013749.GA25293@tsaunders-iceball.corp.tor1.mozilla.com \
--to=tsaunders@mozilla.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=gdr@integrable-solutions.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).