* [PATCH] VAX: Fix ICE during operand output
@ 2013-07-31 16:50 Jan-Benedict Glaw
2013-08-21 13:46 ` [Ping] " Jan-Benedict Glaw
2013-09-13 12:24 ` [Ping^2 PATCH] " Jan-Benedict Glaw
0 siblings, 2 replies; 4+ messages in thread
From: Jan-Benedict Glaw @ 2013-07-31 16:50 UTC (permalink / raw)
To: GCC Patches; +Cc: Will Deacon, Matt Thomas
[-- Attachment #1: Type: text/plain, Size: 1169 bytes --]
Hi!
We've seen ICEs while outputting an operand (not even the excessive
CISC of a VAX could do that), which should be fixed by this patch:
2013-07-31 Jan-Benedict Glaw <jbglaw@lug-owl.de>
* config/vax/constraints.md (T): Add missing CONSTANT_P check.
diff --git a/gcc/config/vax/constraints.md b/gcc/config/vax/constraints.md
index a4774d4..66d6bf0 100644
--- a/gcc/config/vax/constraints.md
+++ b/gcc/config/vax/constraints.md
@@ -114,5 +114,6 @@
(define_constraint "T"
"@internal satisfies CONSTANT_P and, if pic is enabled, is not a SYMBOL_REF, LABEL_REF, or CONST."
- (ior (not (match_code "const,symbol_ref,label_ref"))
- (match_test "!flag_pic")))
+ (and (match_test ("CONSTANT_P (op)"))
+ (ior (not (match_code "symbol_ref,label_ref,const"))
+ (match_test "!flag_pic"))))
Even the description got it right :) Thanks to Will Deacon for
debugging this.
Ok?
MfG, JBG
--
Jan-Benedict Glaw jbglaw@lug-owl.de +49-172-7608481
Signature of: Lauf nicht vor Deinem Glück davon:
the second : Es könnte hinter Dir stehen!
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* [Ping] VAX: Fix ICE during operand output
2013-07-31 16:50 [PATCH] VAX: Fix ICE during operand output Jan-Benedict Glaw
@ 2013-08-21 13:46 ` Jan-Benedict Glaw
2013-09-13 12:24 ` [Ping^2 PATCH] " Jan-Benedict Glaw
1 sibling, 0 replies; 4+ messages in thread
From: Jan-Benedict Glaw @ 2013-08-21 13:46 UTC (permalink / raw)
To: GCC Patches; +Cc: Will Deacon, Matt Thomas
[-- Attachment #1: Type: text/plain, Size: 558 bytes --]
On Wed, 2013-07-31 18:34:26 +0200, Jan-Benedict Glaw <jbglaw@lug-owl.de> wrote:
> Hi!
>
> We've seen ICEs while outputting an operand (not even the excessive
> CISC of a VAX could do that), which should be fixed by this patch:
>
> 2013-07-31 Jan-Benedict Glaw <jbglaw@lug-owl.de>
>
> * config/vax/constraints.md (T): Add missing CONSTANT_P check.
Ping?
MfG, JBG
--
Jan-Benedict Glaw jbglaw@lug-owl.de +49-172-7608481
Signature of: Friends are relatives you make for yourself.
the second :
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* [Ping^2 PATCH] VAX: Fix ICE during operand output
2013-07-31 16:50 [PATCH] VAX: Fix ICE during operand output Jan-Benedict Glaw
2013-08-21 13:46 ` [Ping] " Jan-Benedict Glaw
@ 2013-09-13 12:24 ` Jan-Benedict Glaw
2013-09-13 14:30 ` Matt Thomas
1 sibling, 1 reply; 4+ messages in thread
From: Jan-Benedict Glaw @ 2013-09-13 12:24 UTC (permalink / raw)
To: Matt Thomas; +Cc: Will Deacon, GCC Patches
[-- Attachment #1: Type: text/plain, Size: 1242 bytes --]
On Wed, 2013-07-31 18:34:26 +0200, Jan-Benedict Glaw <jbglaw@lug-owl.de> wrote:
> We've seen ICEs while outputting an operand (not even the excessive
> CISC of a VAX could do that), which should be fixed by this patch:
>
> 2013-07-31 Jan-Benedict Glaw <jbglaw@lug-owl.de>
>
> * config/vax/constraints.md (T): Add missing CONSTANT_P check.
>
> diff --git a/gcc/config/vax/constraints.md b/gcc/config/vax/constraints.md
> index a4774d4..66d6bf0 100644
> --- a/gcc/config/vax/constraints.md
> +++ b/gcc/config/vax/constraints.md
> @@ -114,5 +114,6 @@
>
> (define_constraint "T"
> "@internal satisfies CONSTANT_P and, if pic is enabled, is not a SYMBOL_REF, LABEL_REF, or CONST."
> - (ior (not (match_code "const,symbol_ref,label_ref"))
> - (match_test "!flag_pic")))
> + (and (match_test ("CONSTANT_P (op)"))
> + (ior (not (match_code "symbol_ref,label_ref,const"))
> + (match_test "!flag_pic"))))
>
> Even the description got it right :) Thanks to Will Deacon for
> debugging this.
>
> Ok?
Ping^2
MfG, JBG
--
Jan-Benedict Glaw jbglaw@lug-owl.de +49-172-7608481
Signature of: Wenn ich wach bin, träume ich.
the second :
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Ping^2 PATCH] VAX: Fix ICE during operand output
2013-09-13 12:24 ` [Ping^2 PATCH] " Jan-Benedict Glaw
@ 2013-09-13 14:30 ` Matt Thomas
0 siblings, 0 replies; 4+ messages in thread
From: Matt Thomas @ 2013-09-13 14:30 UTC (permalink / raw)
To: Jan-Benedict Glaw; +Cc: Will Deacon, GCC Patches
On Sep 13, 2013, at 4:21 AM, Jan-Benedict Glaw <jbglaw@lug-owl.de> wrote:
> On Wed, 2013-07-31 18:34:26 +0200, Jan-Benedict Glaw <jbglaw@lug-owl.de> wrote:
>> We've seen ICEs while outputting an operand (not even the excessive
>> CISC of a VAX could do that), which should be fixed by this patch:
>>
>> 2013-07-31 Jan-Benedict Glaw <jbglaw@lug-owl.de>
>>
>> * config/vax/constraints.md (T): Add missing CONSTANT_P check.
>>
>> diff --git a/gcc/config/vax/constraints.md b/gcc/config/vax/constraints.md
>> index a4774d4..66d6bf0 100644
>> --- a/gcc/config/vax/constraints.md
>> +++ b/gcc/config/vax/constraints.md
>> @@ -114,5 +114,6 @@
>>
>> (define_constraint "T"
>> "@internal satisfies CONSTANT_P and, if pic is enabled, is not a SYMBOL_REF, LABEL_REF, or CONST."
>> - (ior (not (match_code "const,symbol_ref,label_ref"))
>> - (match_test "!flag_pic")))
>> + (and (match_test ("CONSTANT_P (op)"))
>> + (ior (not (match_code "symbol_ref,label_ref,const"))
>> + (match_test "!flag_pic"))))
>>
>> Even the description got it right :) Thanks to Will Deacon for
>> debugging this.
>>
>> Ok?
Yes.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-09-13 12:52 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-07-31 16:50 [PATCH] VAX: Fix ICE during operand output Jan-Benedict Glaw
2013-08-21 13:46 ` [Ping] " Jan-Benedict Glaw
2013-09-13 12:24 ` [Ping^2 PATCH] " Jan-Benedict Glaw
2013-09-13 14:30 ` Matt Thomas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).