* Ping: RFA: testsuite patches (1/6): keeps_null_pointer_checks effect on pta/alias dump files @ 2013-09-05 14:42 Joern Rennecke 2013-09-05 15:02 ` Mike Stump 0 siblings, 1 reply; 5+ messages in thread From: Joern Rennecke @ 2013-09-05 14:42 UTC (permalink / raw) To: gcc-patches; +Cc: Rainer Orth, Mike Stump, Janis Johnson This patch has not been reviewed for more than two weeks: http://gcc.gnu.org/ml/gcc-patches/2013-08/msg00990.html ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Ping: RFA: testsuite patches (1/6): keeps_null_pointer_checks effect on pta/alias dump files 2013-09-05 14:42 Ping: RFA: testsuite patches (1/6): keeps_null_pointer_checks effect on pta/alias dump files Joern Rennecke @ 2013-09-05 15:02 ` Mike Stump 2013-09-06 6:58 ` Richard Biener 0 siblings, 1 reply; 5+ messages in thread From: Mike Stump @ 2013-09-05 15:02 UTC (permalink / raw) To: gcc-patches; +Cc: Rainer Orth, Janis Johnson, Joern Rennecke On Sep 5, 2013, at 7:42 AM, Joern Rennecke <joern.rennecke@embecosm.com> wrote: > This patch has not been reviewed for more than two weeks: > http://gcc.gnu.org/ml/gcc-patches/2013-08/msg00990.html I'd like a pta type person (or anyone that has an opinion on the change) to review/comment on this… Surely we have at least 1 person that still works in that area around here… This is the type of change: Index: gcc.dg/tree-ssa/pta-escape-2.c =================================================================== --- gcc.dg/tree-ssa/pta-escape-2.c (revision 201835) +++ gcc.dg/tree-ssa/pta-escape-2.c (working copy) @@ -34,5 +34,5 @@ int main() return 0; } -/* { dg-final { scan-tree-dump "ESCAPED = { NULL ESCAPED NONLOCAL x }" "alias" } } */ +/* { dg-final { scan-tree-dump "ESCAPED = { NULL ESCAPED NONLOCAL x }" "alias" { target { ! keeps_null_pointer_checks } } } } */ /* { dg-final { cleanup-tree-dump "alias" } } */ if you are not sure you want to click on the link. ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Ping: RFA: testsuite patches (1/6): keeps_null_pointer_checks effect on pta/alias dump files 2013-09-05 15:02 ` Mike Stump @ 2013-09-06 6:58 ` Richard Biener 2013-09-06 9:13 ` Joern Rennecke 0 siblings, 1 reply; 5+ messages in thread From: Richard Biener @ 2013-09-06 6:58 UTC (permalink / raw) To: Mike Stump; +Cc: GCC Patches, Rainer Orth, Janis Johnson, Joern Rennecke On Thu, Sep 5, 2013 at 5:02 PM, Mike Stump <mikestump@comcast.net> wrote: > On Sep 5, 2013, at 7:42 AM, Joern Rennecke <joern.rennecke@embecosm.com> wrote: >> This patch has not been reviewed for more than two weeks: >> http://gcc.gnu.org/ml/gcc-patches/2013-08/msg00990.html > > I'd like a pta type person (or anyone that has an opinion on the change) to review/comment on this… Surely we have at least 1 person that still works in that area around here… > > This is the type of change: > > Index: gcc.dg/tree-ssa/pta-escape-2.c > =================================================================== > --- gcc.dg/tree-ssa/pta-escape-2.c (revision 201835) > +++ gcc.dg/tree-ssa/pta-escape-2.c (working copy) > @@ -34,5 +34,5 @@ int main() > return 0; > } > > -/* { dg-final { scan-tree-dump "ESCAPED = { NULL ESCAPED NONLOCAL x }" "alias" } } */ > +/* { dg-final { scan-tree-dump "ESCAPED = { NULL ESCAPED NONLOCAL x }" "alias" { target { ! keeps_null_pointer_checks } } } } */ > /* { dg-final { cleanup-tree-dump "alias" } } */ > > if you are not sure you want to click on the link. I'd say rather than just disabling the scan for keeps_null_pointer_checks you should add appropriate scanning for those targets as well (I expect you just don't see the 'NULL's in the points-to sets). Richard. ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Ping: RFA: testsuite patches (1/6): keeps_null_pointer_checks effect on pta/alias dump files 2013-09-06 6:58 ` Richard Biener @ 2013-09-06 9:13 ` Joern Rennecke 2013-09-06 9:21 ` Richard Biener 0 siblings, 1 reply; 5+ messages in thread From: Joern Rennecke @ 2013-09-06 9:13 UTC (permalink / raw) To: Richard Biener; +Cc: Mike Stump, GCC Patches, Rainer Orth, Janis Johnson [-- Attachment #1: Type: text/plain, Size: 480 bytes --] Quoting Richard Biener <richard.guenther@gmail.com>: > I'd say rather than just disabling the scan for > keeps_null_pointer_checks you should add > appropriate scanning for those targets as well (I expect you just > don't see the 'NULL's in the points-to sets). Well, for gcc.dg/ipa/ipa-pta-14.c, which doesn't have NONLOCAL otherwise, you instead see NONLOCAL. Please find attached the amended patch. I have verified that this gets the new expected PASSes for atmega128-sim. [-- Attachment #2: tmp --] [-- Type: text/plain, Size: 3307 bytes --] 2013-09-06 Joern Rennecke <joern.rennecke@embecosm.com> * gcc.dg/ipa/ipa-pta-14.c (scan-ipa-dump) [keeps_null_pointer_checks]: Don't expect NULL in foo.result set. * gcc.dg/tree-ssa/pta-escape-1.c (scan-tree-dump): Don't expect NULL in ESCAPED set. * gcc.dg/tree-ssa/pta-escape-2.c: Likewise. * gcc.dg/tree-ssa/pta-escape-3.c: Likewise. diff --git a/gcc/testsuite/gcc.dg/ipa/ipa-pta-14.c b/gcc/testsuite/gcc.dg/ipa/ipa-pta-14.c index e8abc32..ed59cbf 100644 --- a/gcc/testsuite/gcc.dg/ipa/ipa-pta-14.c +++ b/gcc/testsuite/gcc.dg/ipa/ipa-pta-14.c @@ -22,7 +22,8 @@ int main() a.p = (void *)&c; p = foo(&a, &a); /* { dg-final { scan-ipa-dump "foo.result = { NULL a\[^ \]* c\[^ \]* }" "pta" { xfail *-*-* } } } */ - /* { dg-final { scan-ipa-dump "foo.result = { NULL a\[^ \]* a\[^ \]* c\[^ \]* }" "pta" } } */ + /* { dg-final { scan-ipa-dump "foo.result = { NULL a\[^ \]* a\[^ \]* c\[^ \]* }" "pta" { target { ! keeps_null_pointer_checks } } } } */ + /* { dg-final { scan-ipa-dump "foo.result = { NONLOCAL a\[^ \]* a\[^ \]* c\[^ \]* }" "pta" { target { keeps_null_pointer_checks } } } } */ ((struct X *)p)->p = (void *)0; if (a.p != (void *)0) abort (); diff --git a/gcc/testsuite/gcc.dg/tree-ssa/pta-escape-1.c b/gcc/testsuite/gcc.dg/tree-ssa/pta-escape-1.c index a424417..dcfae5d 100644 --- a/gcc/testsuite/gcc.dg/tree-ssa/pta-escape-1.c +++ b/gcc/testsuite/gcc.dg/tree-ssa/pta-escape-1.c @@ -33,5 +33,6 @@ int main() return 0; } -/* { dg-final { scan-tree-dump "ESCAPED = { NULL ESCAPED NONLOCAL x }" "alias" } } */ +/* { dg-final { scan-tree-dump "ESCAPED = { NULL ESCAPED NONLOCAL x }" "alias" { target { ! keeps_null_pointer_checks } } } } */ +/* { dg-final { scan-tree-dump "ESCAPED = { ESCAPED NONLOCAL x }" "alias" { target { keeps_null_pointer_checks } } } } */ /* { dg-final { cleanup-tree-dump "alias" } } */ diff --git a/gcc/testsuite/gcc.dg/tree-ssa/pta-escape-2.c b/gcc/testsuite/gcc.dg/tree-ssa/pta-escape-2.c index 8580382..e613959 100644 --- a/gcc/testsuite/gcc.dg/tree-ssa/pta-escape-2.c +++ b/gcc/testsuite/gcc.dg/tree-ssa/pta-escape-2.c @@ -34,5 +34,6 @@ int main() return 0; } -/* { dg-final { scan-tree-dump "ESCAPED = { NULL ESCAPED NONLOCAL x }" "alias" } } */ +/* { dg-final { scan-tree-dump "ESCAPED = { NULL ESCAPED NONLOCAL x }" "alias" { target { ! keeps_null_pointer_checks } } } } */ +/* { dg-final { scan-tree-dump "ESCAPED = { ESCAPED NONLOCAL x }" "alias" { target { keeps_null_pointer_checks } } } } */ /* { dg-final { cleanup-tree-dump "alias" } } */ diff --git a/gcc/testsuite/gcc.dg/tree-ssa/pta-escape-3.c b/gcc/testsuite/gcc.dg/tree-ssa/pta-escape-3.c index 5a121a0..870dcf6 100644 --- a/gcc/testsuite/gcc.dg/tree-ssa/pta-escape-3.c +++ b/gcc/testsuite/gcc.dg/tree-ssa/pta-escape-3.c @@ -38,5 +38,6 @@ int main() return 0; } -/* { dg-final { scan-tree-dump "ESCAPED = { NULL ESCAPED NONLOCAL x }" "alias" } } */ +/* { dg-final { scan-tree-dump "ESCAPED = { NULL ESCAPED NONLOCAL x }" "alias" { target { ! keeps_null_pointer_checks } } } } */ +/* { dg-final { scan-tree-dump "ESCAPED = { ESCAPED NONLOCAL x }" "alias" { target { keeps_null_pointer_checks } } } } */ /* { dg-final { cleanup-tree-dump "alias" } } */ ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Ping: RFA: testsuite patches (1/6): keeps_null_pointer_checks effect on pta/alias dump files 2013-09-06 9:13 ` Joern Rennecke @ 2013-09-06 9:21 ` Richard Biener 0 siblings, 0 replies; 5+ messages in thread From: Richard Biener @ 2013-09-06 9:21 UTC (permalink / raw) To: Joern Rennecke; +Cc: Mike Stump, GCC Patches, Rainer Orth, Janis Johnson On Fri, Sep 6, 2013 at 11:13 AM, Joern Rennecke <joern.rennecke@embecosm.com> wrote: > Quoting Richard Biener <richard.guenther@gmail.com>: > >> I'd say rather than just disabling the scan for >> keeps_null_pointer_checks you should add >> appropriate scanning for those targets as well (I expect you just >> don't see the 'NULL's in the points-to sets). > > > Well, for gcc.dg/ipa/ipa-pta-14.c, which doesn't have NONLOCAL otherwise, > you instead see NONLOCAL. Yes. On those targets NULL == NONLOCAL (0 is just another global address). > Please find attached the amended patch. > > I have verified that this gets the new expected PASSes for atmega128-sim. Ok. Thanks, Richard. > 2013-09-06 Joern Rennecke <joern.rennecke@embecosm.com> > > * gcc.dg/ipa/ipa-pta-14.c (scan-ipa-dump) > [keeps_null_pointer_checks]: > Don't expect NULL in foo.result set. > * gcc.dg/tree-ssa/pta-escape-1.c (scan-tree-dump): Don't expect NULL > in ESCAPED set. > * gcc.dg/tree-ssa/pta-escape-2.c: Likewise. > * gcc.dg/tree-ssa/pta-escape-3.c: Likewise. > > diff --git a/gcc/testsuite/gcc.dg/ipa/ipa-pta-14.c > b/gcc/testsuite/gcc.dg/ipa/ipa-pta-14.c > index e8abc32..ed59cbf 100644 > --- a/gcc/testsuite/gcc.dg/ipa/ipa-pta-14.c > +++ b/gcc/testsuite/gcc.dg/ipa/ipa-pta-14.c > @@ -22,7 +22,8 @@ int main() > a.p = (void *)&c; > p = foo(&a, &a); > /* { dg-final { scan-ipa-dump "foo.result = { NULL a\[^ \]* c\[^ \]* }" > "pta" { xfail *-*-* } } } */ > - /* { dg-final { scan-ipa-dump "foo.result = { NULL a\[^ \]* a\[^ \]* c\[^ > \]* }" "pta" } } */ > + /* { dg-final { scan-ipa-dump "foo.result = { NULL a\[^ \]* a\[^ \]* c\[^ > \]* }" "pta" { target { ! keeps_null_pointer_checks } } } } */ > + /* { dg-final { scan-ipa-dump "foo.result = { NONLOCAL a\[^ \]* a\[^ \]* > c\[^ \]* }" "pta" { target { keeps_null_pointer_checks } } } } */ > ((struct X *)p)->p = (void *)0; > if (a.p != (void *)0) > abort (); > diff --git a/gcc/testsuite/gcc.dg/tree-ssa/pta-escape-1.c > b/gcc/testsuite/gcc.dg/tree-ssa/pta-escape-1.c > index a424417..dcfae5d 100644 > --- a/gcc/testsuite/gcc.dg/tree-ssa/pta-escape-1.c > +++ b/gcc/testsuite/gcc.dg/tree-ssa/pta-escape-1.c > @@ -33,5 +33,6 @@ int main() > return 0; > } > > -/* { dg-final { scan-tree-dump "ESCAPED = { NULL ESCAPED NONLOCAL x }" > "alias" } } */ > +/* { dg-final { scan-tree-dump "ESCAPED = { NULL ESCAPED NONLOCAL x }" > "alias" { target { ! keeps_null_pointer_checks } } } } */ > +/* { dg-final { scan-tree-dump "ESCAPED = { ESCAPED NONLOCAL x }" "alias" { > target { keeps_null_pointer_checks } } } } */ > /* { dg-final { cleanup-tree-dump "alias" } } */ > diff --git a/gcc/testsuite/gcc.dg/tree-ssa/pta-escape-2.c > b/gcc/testsuite/gcc.dg/tree-ssa/pta-escape-2.c > index 8580382..e613959 100644 > --- a/gcc/testsuite/gcc.dg/tree-ssa/pta-escape-2.c > +++ b/gcc/testsuite/gcc.dg/tree-ssa/pta-escape-2.c > @@ -34,5 +34,6 @@ int main() > return 0; > } > > -/* { dg-final { scan-tree-dump "ESCAPED = { NULL ESCAPED NONLOCAL x }" > "alias" } } */ > +/* { dg-final { scan-tree-dump "ESCAPED = { NULL ESCAPED NONLOCAL x }" > "alias" { target { ! keeps_null_pointer_checks } } } } */ > +/* { dg-final { scan-tree-dump "ESCAPED = { ESCAPED NONLOCAL x }" "alias" { > target { keeps_null_pointer_checks } } } } */ > /* { dg-final { cleanup-tree-dump "alias" } } */ > diff --git a/gcc/testsuite/gcc.dg/tree-ssa/pta-escape-3.c > b/gcc/testsuite/gcc.dg/tree-ssa/pta-escape-3.c > index 5a121a0..870dcf6 100644 > --- a/gcc/testsuite/gcc.dg/tree-ssa/pta-escape-3.c > +++ b/gcc/testsuite/gcc.dg/tree-ssa/pta-escape-3.c > @@ -38,5 +38,6 @@ int main() > return 0; > } > > -/* { dg-final { scan-tree-dump "ESCAPED = { NULL ESCAPED NONLOCAL x }" > "alias" } } */ > +/* { dg-final { scan-tree-dump "ESCAPED = { NULL ESCAPED NONLOCAL x }" > "alias" { target { ! keeps_null_pointer_checks } } } } */ > +/* { dg-final { scan-tree-dump "ESCAPED = { ESCAPED NONLOCAL x }" "alias" { > target { keeps_null_pointer_checks } } } } */ > /* { dg-final { cleanup-tree-dump "alias" } } */ > ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-09-06 9:21 UTC | newest] Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2013-09-05 14:42 Ping: RFA: testsuite patches (1/6): keeps_null_pointer_checks effect on pta/alias dump files Joern Rennecke 2013-09-05 15:02 ` Mike Stump 2013-09-06 6:58 ` Richard Biener 2013-09-06 9:13 ` Joern Rennecke 2013-09-06 9:21 ` Richard Biener
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).