public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* Silence gcc.dg/autopar/pr49960.c
@ 2013-09-05 22:50 Jan Hubicka
  2013-09-06  0:06 ` Mike Stump
  0 siblings, 1 reply; 3+ messages in thread
From: Jan Hubicka @ 2013-09-05 22:50 UTC (permalink / raw)
  To: gcc-patches

Hi,
this testcase breaks with partial inlining because it depends on hand hoisted loop
header out of the loop nest.  Partial inling (correctly) moves the test out of function
and prevents the analysis to happen.

The whole testcase is very artificial, so I think it is fine to disable partial inlining
until we have IPA value range propagation.

Comitted as obvoius.

Honza

Index: ChangeLog
===================================================================
--- ChangeLog	(revision 202296)
+++ ChangeLog	(working copy)
@@ -1,3 +1,6 @@
+2013-09-05  Jan Hubicka  <jh@suse.cz>
+
+	* gcc.dg/autopar/pr49960.c: Disable partial inlining
 2013-09-05  Richard Biener  <rguenther@suse.de>
 
 	PR tree-optimization/58137
Index: gcc.dg/autopar/pr49960.c
===================================================================
--- gcc.dg/autopar/pr49960.c	(revision 202271)
+++ gcc.dg/autopar/pr49960.c	(working copy)
@@ -1,5 +1,5 @@
 /* { dg-do compile } */
-/* { dg-options "-O2 -ftree-parallelize-loops=4 -fdump-tree-parloops-details -fdump-tree-optimized" } */
+/* { dg-options "-O2 -ftree-parallelize-loops=4 -fdump-tree-parloops-details -fdump-tree-optimized -fno-partial-inlining" } */
 
 #include <stdio.h>
 #define MB 100
@@ -12,7 +12,9 @@ void MRTRBR(int MA_1, int NA_1, int MB_1
   int i,j, t,k;
 
   /* At the moment we are not able to hoist the loop headers out of the loop
-     nest.  */
+     nest. 
+     Partial inlining needs to be disabled so we do not optimize this out
+     of the function body.  */
   if (MA_1 < 4 || NA_1 < 4 || MB_1 < 4)
     return;
 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Silence gcc.dg/autopar/pr49960.c
  2013-09-05 22:50 Silence gcc.dg/autopar/pr49960.c Jan Hubicka
@ 2013-09-06  0:06 ` Mike Stump
  2013-09-06  7:41   ` Jan Hubicka
  0 siblings, 1 reply; 3+ messages in thread
From: Mike Stump @ 2013-09-06  0:06 UTC (permalink / raw)
  To: Jan Hubicka; +Cc: gcc-patches

On Sep 5, 2013, at 3:50 PM, Jan Hubicka <hubicka@ucw.cz> wrote:
> Comitted as obvoius.
> 
> Honza
> 
> Index: ChangeLog
> ===================================================================
> --- ChangeLog	(revision 202296)
> +++ ChangeLog	(working copy)
> @@ -1,3 +1,6 @@
> +2013-09-05  Jan Hubicka  <jh@suse.cz>
> +
> +	* gcc.dg/autopar/pr49960.c: Disable partial inlining
> 2013-09-05  Richard Biener  <rguenther@suse.de>

Please add a blank line between entries…

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Silence gcc.dg/autopar/pr49960.c
  2013-09-06  0:06 ` Mike Stump
@ 2013-09-06  7:41   ` Jan Hubicka
  0 siblings, 0 replies; 3+ messages in thread
From: Jan Hubicka @ 2013-09-06  7:41 UTC (permalink / raw)
  To: Mike Stump; +Cc: Jan Hubicka, gcc-patches

> > +2013-09-05  Jan Hubicka  <jh@suse.cz>
> > +
> > +	* gcc.dg/autopar/pr49960.c: Disable partial inlining
> > 2013-09-05  Richard Biener  <rguenther@suse.de>
> 
> Please add a blank line between entries?

The actual commmit has the extra line.  Not sure why the patch doesn't.
Sorry for that.

Honza

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-09-06  7:41 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-09-05 22:50 Silence gcc.dg/autopar/pr49960.c Jan Hubicka
2013-09-06  0:06 ` Mike Stump
2013-09-06  7:41   ` Jan Hubicka

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).