From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18734 invoked by alias); 9 Sep 2013 07:59:09 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 18724 invoked by uid 89); 9 Sep 2013 07:59:09 -0000 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 09 Sep 2013 07:59:09 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.5 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r897x51d000886 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 9 Sep 2013 03:59:06 -0400 Received: from tucnak.zalov.cz (vpn1-7-146.ams2.redhat.com [10.36.7.146]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r897x30U025670 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 9 Sep 2013 03:59:04 -0400 Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.14.7/8.14.7) with ESMTP id r897x2ut014893; Mon, 9 Sep 2013 09:59:03 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.14.7/8.14.7/Submit) id r897x2oF014892; Mon, 9 Sep 2013 09:59:02 +0200 Date: Mon, 09 Sep 2013 08:02:00 -0000 From: Jakub Jelinek To: "Michael V. Zolotukhin" Cc: Jan Hubicka , "H.J. Lu" , Eric Botcazou , Kirill Yukhin , GCC Patches , Ond??ej B?lka , Uros Bizjak Subject: Re: [PATCH, x86] Use vector moves in memmove expanding Message-ID: <20130909075902.GD1817@tucnak.redhat.com> Reply-To: Jakub Jelinek References: <20130705112534.GA10164@kam.mff.cuni.cz> <7703907.JSoGtmLQkn@polaris> <20130909072317.GA53568@msticlxl57.ims.intel.com> <20130909072434.GA21984@kam.mff.cuni.cz> <20130909074205.GB53568@msticlxl57.ims.intel.com> <20130909074643.GC1817@tucnak.redhat.com> <20130909075249.GC53568@msticlxl57.ims.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130909075249.GC53568@msticlxl57.ims.intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2013-09/txt/msg00558.txt.bz2 On Mon, Sep 09, 2013 at 11:52:49AM +0400, Michael V. Zolotukhin wrote: > > I don't see anything i386 specific on the testcase, except the flags, > > and don't see why you need -fno-common in there, there are no global vars. > > So, I think it would be better to stick it into gcc.dg/torture/, drop > > dg-require-* line and instead just add > > /* { dg-additional-options "-march=pentiumpro" { target ia32 } } */ > > /* { dg-additional-options "-minline-all-stringops" { target { i?86-*-* x86_64-*-* } } } */ > > or so (and let it cycle through all the -O* options). > Originally the test targeted a specific situation, happening on pentiumpro (and > thus ia32), because on pentium pro we want 64-bit alignment for 32-bit > rep-moves. So, it reveals an issue when desired alignment is bigger than size > of move_mode. > I don't see if it could be helpful on other platforms, though if > you think it's worthwhile, I'll update the test as you suggested. I think it is worthwhile, various targets have many different ways to expand memcpy, admittedly i?86/x86_64 probably the biggest number of these, and while right now you've encountered it on ia32 with certain options doesn't mean that in a few years it couldn't hit some unrelated target, arm, sh, sparc, whatever. Jakub