From: Jan Hubicka <hubicka@ucw.cz>
To: David Malcolm <dmalcolm@redhat.com>
Cc: gcc-patches@gcc.gnu.org, Jan Hubicka <hubicka@ucw.cz>
Subject: Re: [PATCH v2 4/6] Remove symtab_node and const_symtab_node typedefs.
Date: Tue, 10 Sep 2013 13:39:00 -0000 [thread overview]
Message-ID: <20130910133743.GF25658@kam.mff.cuni.cz> (raw)
In-Reply-To: <1378755140-5555-5-git-send-email-dmalcolm@redhat.com>
> gcc/
>
> * ipa-ref.h (symtab_node): Remove typedef to pointer type, as it
> clashes with the preferred name for the base class.
> (const_symtab_node): Remove redundant typedef.
This is OK, too.
Actually it is not only clash - it was really inconsistent to write
symtab_node node;
struct cgraph_node *cnode;
It is good this inconsistency is gone.
Honza
next prev parent reply other threads:[~2013-09-10 13:37 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-16 0:58 [PATCH 0/2] Port symtab/cgraph/varpool nodes to use C++ inheritance David Malcolm
2013-08-16 0:58 ` [PATCH 2/2] Autogenerated fixes of "->symbol." to "->" David Malcolm
2013-08-16 0:58 ` [PATCH 1/2] Convert symtab, cgraph and varpool nodes into a real class hierarchy David Malcolm
2013-08-20 21:26 ` Jan Hubicka
2013-08-20 21:31 ` Steven Bosscher
2013-08-20 21:34 ` Jan Hubicka
2013-08-20 21:42 ` Jan Hubicka
2013-08-27 11:10 ` Richard Biener
2013-08-27 11:48 ` Jan Hubicka
2013-08-27 12:17 ` Richard Biener
2013-08-27 12:50 ` Jan Hubicka
2013-08-27 15:25 ` Mike Stump
2013-08-28 9:37 ` Richard Biener
2013-08-28 17:06 ` Mike Stump
2013-08-29 10:16 ` Richard Biener
2013-08-20 21:06 ` [PATCH 0/2] Port symtab/cgraph/varpool nodes to use C++ inheritance Jan Hubicka
2013-08-21 10:03 ` Martin Jambor
2013-08-26 22:27 ` David Malcolm
2013-09-09 19:32 ` [PATCH v2 0/6] Port symtab/cgraph/varpool nodes to use C++ inheritance; rename types David Malcolm
2013-09-09 19:32 ` [PATCH v2 2/6] Automated conversion of symtab to class hierarchy David Malcolm
2013-09-10 13:37 ` Jan Hubicka
2013-09-09 19:32 ` [PATCH v2 3/6] Split symtab_node declarations onto multiple lines David Malcolm
2013-09-10 13:38 ` Jan Hubicka
2013-10-30 16:12 ` David Malcolm
2013-09-09 19:32 ` [PATCH v2 6/6] Update hand-written GTY routines for type renaming David Malcolm
2013-09-10 13:46 ` Jan Hubicka
2013-09-09 19:33 ` [PATCH v2 1/6] Convert symtab, cgraph and varpool nodes into a real class hierarchy David Malcolm
2013-09-10 9:14 ` Richard Biener
2013-09-10 13:36 ` Jan Hubicka
2013-09-17 21:10 ` David Malcolm
2013-09-18 8:05 ` Jan Hubicka
2013-09-18 10:37 ` Richard Biener
2013-09-09 19:43 ` [PATCH v2 4/6] Remove symtab_node and const_symtab_node typedefs David Malcolm
2013-09-10 13:39 ` Jan Hubicka [this message]
2013-10-31 23:38 ` symtab_node is now a struct, not a pointer (was Re: [PATCH v2 4/6] Remove symtab_node and const_symtab_node typedefs.) David Malcolm
2013-09-09 20:49 ` [PATCH v2 5/6] Automated renaming of symtab types David Malcolm
2013-09-10 13:40 ` Jan Hubicka
2013-09-10 13:04 ` [PATCH v2 0/6] Port symtab/cgraph/varpool nodes to use C++ inheritance; rename types Jan Hubicka
2013-09-11 1:34 ` David Malcolm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130910133743.GF25658@kam.mff.cuni.cz \
--to=hubicka@ucw.cz \
--cc=dmalcolm@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).