From: Jan-Benedict Glaw <jbglaw@lug-owl.de>
To: Matt Thomas <matt@3am-software.com>
Cc: Will Deacon <will@willdeacon.co.uk>,
GCC Patches <gcc-patches@gcc.gnu.org>
Subject: [Ping^2 PATCH] VAX: Fix ICE during operand output
Date: Fri, 13 Sep 2013 12:24:00 -0000 [thread overview]
Message-ID: <20130913112141.GG24834@lug-owl.de> (raw)
In-Reply-To: <20130731163426.GD31990@lug-owl.de>
[-- Attachment #1: Type: text/plain, Size: 1242 bytes --]
On Wed, 2013-07-31 18:34:26 +0200, Jan-Benedict Glaw <jbglaw@lug-owl.de> wrote:
> We've seen ICEs while outputting an operand (not even the excessive
> CISC of a VAX could do that), which should be fixed by this patch:
>
> 2013-07-31 Jan-Benedict Glaw <jbglaw@lug-owl.de>
>
> * config/vax/constraints.md (T): Add missing CONSTANT_P check.
>
> diff --git a/gcc/config/vax/constraints.md b/gcc/config/vax/constraints.md
> index a4774d4..66d6bf0 100644
> --- a/gcc/config/vax/constraints.md
> +++ b/gcc/config/vax/constraints.md
> @@ -114,5 +114,6 @@
>
> (define_constraint "T"
> "@internal satisfies CONSTANT_P and, if pic is enabled, is not a SYMBOL_REF, LABEL_REF, or CONST."
> - (ior (not (match_code "const,symbol_ref,label_ref"))
> - (match_test "!flag_pic")))
> + (and (match_test ("CONSTANT_P (op)"))
> + (ior (not (match_code "symbol_ref,label_ref,const"))
> + (match_test "!flag_pic"))))
>
> Even the description got it right :) Thanks to Will Deacon for
> debugging this.
>
> Ok?
Ping^2
MfG, JBG
--
Jan-Benedict Glaw jbglaw@lug-owl.de +49-172-7608481
Signature of: Wenn ich wach bin, träume ich.
the second :
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2013-09-13 11:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-31 16:50 [PATCH] " Jan-Benedict Glaw
2013-08-21 13:46 ` [Ping] " Jan-Benedict Glaw
2013-09-13 12:24 ` Jan-Benedict Glaw [this message]
2013-09-13 14:30 ` [Ping^2 PATCH] " Matt Thomas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130913112141.GG24834@lug-owl.de \
--to=jbglaw@lug-owl.de \
--cc=gcc-patches@gcc.gnu.org \
--cc=matt@3am-software.com \
--cc=will@willdeacon.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).