On Wed, 2013-07-31 18:34:26 +0200, Jan-Benedict Glaw <jbglaw@lug-owl.de> wrote:
> We've seen ICEs while outputting an operand (not even the excessive
> CISC of a VAX could do that), which should be fixed by this patch:
> 
> 2013-07-31  Jan-Benedict Glaw  <jbglaw@lug-owl.de>
> 
> 	* config/vax/constraints.md (T): Add missing CONSTANT_P check.
> 
> diff --git a/gcc/config/vax/constraints.md b/gcc/config/vax/constraints.md
> index a4774d4..66d6bf0 100644
> --- a/gcc/config/vax/constraints.md
> +++ b/gcc/config/vax/constraints.md
> @@ -114,5 +114,6 @@
>  
>  (define_constraint "T"
>      "@internal satisfies CONSTANT_P and, if pic is enabled, is not a SYMBOL_REF, LABEL_REF, or CONST."
> -   (ior (not (match_code "const,symbol_ref,label_ref"))
> -	(match_test "!flag_pic")))
> +  (and (match_test ("CONSTANT_P (op)"))
> +       (ior (not (match_code "symbol_ref,label_ref,const"))
> +	    (match_test "!flag_pic"))))
> 
> Even the description got it right :)  Thanks to Will Deacon for
> debugging this.
> 
> Ok?

Ping^2

MfG, JBG

-- 
      Jan-Benedict Glaw      jbglaw@lug-owl.de              +49-172-7608481
  Signature of:                           Wenn ich wach bin, träume ich.
  the second  :