From: Jakub Jelinek <jakub@redhat.com>
To: libstdc++@gcc.gnu.org
Cc: Paolo Carlini <paolo.carlini@oracle.com>,
Andreas Schwab <schwab@suse.de>,
Paul Pluzhnikov <ppluzhnikov@google.com>,
gcc-patches List <gcc-patches@gcc.gnu.org>
Subject: Re: [patch] Make vector::at() assertion message more useful (try #2)
Date: Mon, 23 Sep 2013 14:12:00 -0000 [thread overview]
Message-ID: <20130923140053.GF30970@tucnak.zalov.cz> (raw)
In-Reply-To: <alpine.DEB.2.10.1309231542490.4526@stedding.saclay.inria.fr>
On Mon, Sep 23, 2013 at 03:55:26PM +0200, Marc Glisse wrote:
> On Mon, 23 Sep 2013, Paolo Carlini wrote:
>
> >>There are a lot of targets using unsigned int for size_t, which would
> >>have been uncovered by proper testing.
>
> We can't test all patches on 3-4 different targets... It wasn't
> obvious this patch could be that sensitive to the target.
>
> >That's true, just remember to test *both* -m32 and -m64, for non
> >trivial changes.
>
> So how do you do that in practice ? Is it done by default if
> multilib is enabled? You also mentioned doing something special to
> check debug/profile modes recently, is there a make target to really
> perform all the tests necessary for a submission?
It isn't done by default, but you can easily do that, by running
make check RUNTESTFLAGS='--target_board=unix\{-m32,-m64\}'
(either toplevel, or more specific, e.g. just in libstdc++-v3/
dir, or even
make check-gcc RUNTESTFLAGS='--target_board=unix\{-m32,-m64\} dg.exp=pr12345.c'
etc.).
Or of course you can do two separate bootstraps/make check (that is what I'm usually
doing, so that both bootstraps are tested).
>
> http://gcc.gnu.org/contribute.html has an outdated section on
> testing. It mentions that you should do a bootstrap for a change to
> the C front-end (should also be for the C++ front-end and I guess
> libstdc++ even if it isn't used much inside gcc).
Jakub
next prev parent reply other threads:[~2013-09-23 14:01 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-04 20:53 Paul Pluzhnikov
2013-09-04 21:10 ` Daniel Krügler
2013-09-04 23:17 ` Paul Pluzhnikov
2013-09-05 4:55 ` Daniel Krügler
2013-09-13 5:19 ` Paul Pluzhnikov
2013-09-13 10:52 ` Paolo Carlini
2013-09-18 20:30 ` Paul Pluzhnikov
2013-09-18 23:24 ` Paolo Carlini
2013-09-22 10:19 ` Paul Pluzhnikov
2013-09-23 11:09 ` Andreas Schwab
2013-09-23 11:45 ` Paolo Carlini
2013-09-23 12:54 ` Richard Biener
2013-09-23 12:59 ` Andreas Schwab
2013-09-23 13:40 ` Paolo Carlini
2013-09-23 13:42 ` Andreas Schwab
2013-09-23 14:12 ` Paolo Carlini
2013-09-23 14:12 ` Marc Glisse
2013-09-23 14:12 ` Jakub Jelinek [this message]
2015-04-06 11:37 ` [wwwdocs] Testing C++ changes (was: [patch] Make vector::at() assertion message more useful) Gerald Pfeifer
2015-04-06 14:06 ` [wwwdocs] Testing C++ changes Jason Merrill
2013-09-23 15:18 ` [patch] Make vector::at() assertion message more useful (try #2) Paul Pluzhnikov
2013-09-23 15:26 ` Paolo Carlini
2013-09-23 16:38 ` Paul Pluzhnikov
2013-09-23 17:00 ` Paolo Carlini
2013-09-23 17:01 ` Paul Pluzhnikov
2013-09-23 16:21 ` Paul Pluzhnikov
2013-09-04 23:26 ` Paolo Carlini
2013-09-04 23:36 ` Paul Pluzhnikov
2013-09-04 23:44 ` Paolo Carlini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130923140053.GF30970@tucnak.zalov.cz \
--to=jakub@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
--cc=paolo.carlini@oracle.com \
--cc=ppluzhnikov@google.com \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).