From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15161 invoked by alias); 7 Nov 2013 08:23:02 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 15098 invoked by uid 89); 7 Nov 2013 08:23:01 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.1 required=5.0 tests=AWL,BAYES_40,RDNS_NONE,SPAM_SUBJECT,SPF_HELO_PASS,SPF_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 07 Nov 2013 08:23:00 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rA78MpMs027086 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 7 Nov 2013 03:22:51 -0500 Received: from tucnak.zalov.cz (vpn1-6-38.ams2.redhat.com [10.36.6.38]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id rA78MoUV006333 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 7 Nov 2013 03:22:51 -0500 Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.14.7/8.14.7) with ESMTP id rA78Mnk2007840; Thu, 7 Nov 2013 09:22:49 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.14.7/8.14.7/Submit) id rA78Mm5A007839; Thu, 7 Nov 2013 09:22:48 +0100 Date: Thu, 07 Nov 2013 08:48:00 -0000 From: Jakub Jelinek To: Thomas Schwinge Cc: gcc-patches@gcc.gnu.org Subject: Re: [gomp4 9/9] OpenACC: Basic support for #pragma acc parallel. Message-ID: <20131107082248.GV27813@tucnak.zalov.cz> Reply-To: Jakub Jelinek References: <1383766943-8863-1-git-send-email-thomas@codesourcery.com> <1383766943-8863-2-git-send-email-thomas@codesourcery.com> <1383766943-8863-3-git-send-email-thomas@codesourcery.com> <1383766943-8863-4-git-send-email-thomas@codesourcery.com> <1383766943-8863-5-git-send-email-thomas@codesourcery.com> <1383766943-8863-6-git-send-email-thomas@codesourcery.com> <1383766943-8863-7-git-send-email-thomas@codesourcery.com> <1383766943-8863-8-git-send-email-thomas@codesourcery.com> <1383766943-8863-9-git-send-email-thomas@codesourcery.com> <8761s5joir.fsf@schwinge.name> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8761s5joir.fsf@schwinge.name> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2013-11/txt/msg00719.txt.bz2 On Wed, Nov 06, 2013 at 08:53:00PM +0100, Thomas Schwinge wrote: > Forgot to pass the --patience switch to Git, so the diff algorithm > decided to first patch the existing expand_omp_taskreg into > expand_oacc_parallel, and then later re-add expand_omp_taskreg. Here's a > more readable version of that patch, avoiding all that back'n'forth: I've just quickly skimmed this, other than what I've mentioned earlier I haven't found anything totally wrong, so with that thing fixed I guess it is ok for the branch, but my quick skimming was far from a proper review. Jakub