From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4009 invoked by alias); 21 Nov 2013 22:19:45 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 3999 invoked by uid 89); 21 Nov 2013 22:19:44 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_20,RDNS_NONE,SPF_HELO_PASS,SPF_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 21 Nov 2013 22:19:44 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rALMJaRm014695 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 21 Nov 2013 17:19:36 -0500 Received: from tucnak.zalov.cz (vpn1-4-253.ams2.redhat.com [10.36.4.253]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id rALMJY9f032084 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 21 Nov 2013 17:19:35 -0500 Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.14.7/8.14.7) with ESMTP id rALMJXKJ028270; Thu, 21 Nov 2013 23:19:33 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.14.7/8.14.7/Submit) id rALMJXHh028269; Thu, 21 Nov 2013 23:19:33 +0100 Date: Fri, 22 Nov 2013 00:27:00 -0000 From: Jakub Jelinek To: David Malcolm Cc: Jeff Law , gcc-patches@gcc.gnu.org, Andrew MacLeod Subject: Re: [PATCH] Updated automated patch (was Re: [PATCH 3/6] Automated part of conversion of gimple types to use C++ inheritance) Message-ID: <20131121221933.GQ892@tucnak.redhat.com> Reply-To: Jakub Jelinek References: <5271CBF9.2070005@redhat.com> <1383236801-13234-1-git-send-email-dmalcolm@redhat.com> <1383236801-13234-4-git-send-email-dmalcolm@redhat.com> <5284806A.2050607@redhat.com> <1384806352.11568.80.camel@surprise> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1384806352.11568.80.camel@surprise> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2013-11/txt/msg02784.txt.bz2 On Mon, Nov 18, 2013 at 03:25:52PM -0500, David Malcolm wrote: > > So is there some reason the GIMPLE_CHECK was left in here rather than > > doing the downcasting? This happens in other places. Note that the changes removed tons of checks that IMHO were desirable. The as_a that replaced those checks e.g. allows 3 different gimple codes, while previously only one was allowed, this is both more expensive for --enable-checking=yes, and allows one to use inline wrappers e.g. gimple_omp_parallel_something on GIMPLE_OMP_TASK etc. Jakub