public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jakub Jelinek <jakub@redhat.com>
To: Dmitry Vyukov <dvyukov@google.com>
Cc: Ian Lance Taylor <iant@google.com>,
	       Konstantin Serebryany <konstantin.s.serebryany@gmail.com>,
	       GCC Patches <gcc-patches@gcc.gnu.org>,
	       Alexey Samsonov <samsonov@google.com>
Subject: Re: [PATCH] Handle PIEs in libbacktrace
Date: Fri, 06 Dec 2013 08:25:00 -0000	[thread overview]
Message-ID: <20131206082507.GF892@tucnak.redhat.com> (raw)
In-Reply-To: <CACT4Y+b4Txm5oWOCEC71OmU5+4sbxgpkx=6ziiXD7DPfBrpeoA@mail.gmail.com>

On Fri, Dec 06, 2013 at 12:19:45PM +0400, Dmitry Vyukov wrote:
> > And the reason why check-g++ tsan.exp fails even with this patch is
> > that apparently tsan doesn't try to demangle the symbol names, so we get
> > e.g.:
> 
> Demangling must be done by the symbolizer.
> +samsonov for this

So why does asan_report.cc have then:
static const char *MaybeDemangleGlobalName(const char *name) {
  // We can spoil names of globals with C linkage, so use an heuristic
  // approach to check if the name should be demangled.
  return (name[0] == '_' && name[1] == 'Z')
             ? Symbolizer::Get()->Demangle(name)
             : name;
}
and uses it where it wants to demangle?  From what I can see, even when
you are using llvm-symbolizer, sanitizer_common doesn't pass -demangle
option to it.

	Jakub

  reply	other threads:[~2013-12-06  8:25 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-06  7:50 Jakub Jelinek
2013-12-06  8:20 ` Dmitry Vyukov
2013-12-06  8:25   ` Jakub Jelinek [this message]
2013-12-06  8:52     ` Dmitry Vyukov
2013-12-06  8:53       ` Alexey Samsonov
2013-12-06  9:53         ` Jakub Jelinek
2013-12-06 14:41           ` Ian Lance Taylor
2013-12-10 11:38             ` [PATCH] libsanitizer demangling using cp-demangle.c Jakub Jelinek
2014-01-09 11:41               ` Dodji Seketeli
2014-01-09 13:51               ` Konstantin Serebryany
2014-01-09 13:57                 ` Jakub Jelinek
2014-01-10  3:57                   ` Konstantin Serebryany
2014-01-16 13:58                     ` Alexey Samsonov
2014-01-28 14:36               ` -Og bug? (was: [PATCH] libsanitizer demangling using cp-demangle.c) Thomas Schwinge
2014-01-28 14:52                 ` Ian Lance Taylor
2014-01-28 16:11                   ` -Og bug? Thomas Schwinge
2014-01-28 17:12                     ` Ian Lance Taylor
2014-01-28 21:10                       ` Thomas Schwinge
2014-01-28 21:24                         ` Ian Lance Taylor
2014-01-29  9:38                           ` Richard Biener
2013-12-06 14:36 ` [PATCH] Handle PIEs in libbacktrace Ian Lance Taylor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131206082507.GF892@tucnak.redhat.com \
    --to=jakub@redhat.com \
    --cc=dvyukov@google.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=iant@google.com \
    --cc=konstantin.s.serebryany@gmail.com \
    --cc=samsonov@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).