From: Jakub Jelinek <jakub@redhat.com>
To: gcc-patches@gcc.gnu.org
Subject: [committed] Fix one issue reported by valgrind (PR other/58712)
Date: Wed, 15 Jan 2014 08:14:00 -0000 [thread overview]
Message-ID: <20140115081424.GW892@tucnak.redhat.com> (raw)
Hi!
When memcpy has constant length, we leave probable_max_size uninitialized
and later on create a CONST_INT out of it.
Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-linux,
committed to trunk as obvious.
2014-01-15 Jakub Jelinek <jakub@redhat.com>
PR other/58712
* builtins.c (determine_block_size): Initialize *probable_max_size
even if len_rtx is CONST_INT.
--- gcc/builtins.c.jj 2014-01-13 13:26:37.000000000 +0100
+++ gcc/builtins.c 2014-01-13 18:21:13.299612871 +0100
@@ -3117,7 +3117,7 @@ determine_block_size (tree len, rtx len_
{
if (CONST_INT_P (len_rtx))
{
- *min_size = *max_size = UINTVAL (len_rtx);
+ *min_size = *max_size = *probable_max_size = UINTVAL (len_rtx);
return;
}
else
@@ -3131,7 +3131,8 @@ determine_block_size (tree len, rtx len_
else
*min_size = 0;
if (tree_fits_uhwi_p (TYPE_MAX_VALUE (TREE_TYPE (len))))
- *probable_max_size = *max_size = tree_to_uhwi (TYPE_MAX_VALUE (TREE_TYPE (len)));
+ *probable_max_size = *max_size
+ = tree_to_uhwi (TYPE_MAX_VALUE (TREE_TYPE (len)));
else
*probable_max_size = *max_size = GET_MODE_MASK (GET_MODE (len_rtx));
Jakub
reply other threads:[~2014-01-15 8:14 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140115081424.GW892@tucnak.redhat.com \
--to=jakub@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).