public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: dominiq@lps.ens.fr (Dominique Dhumieres)
To: fortran@gcc.gnu.org
Cc: gcc-patches@gcc.gnu.org, nmm1@cam.ac.uk,
	sgk@troutmask.apl.washington.edu
Subject: Re: [PATCH, fortran/52879] RANDOM_SEED revisited
Date: Sun, 09 Feb 2014 14:31:00 -0000	[thread overview]
Message-ID: <20140209143109.181EB104@mailhost.lps.ens.fr> (raw)

Steve,

First, it is needed to remove the line

  mpz_t put_size, get_size;

in gcc/fortran/check.c, otherwise compiling the file with -Werror
(default) fails.

Second, the patch breaks the interface of RANDOM_SEED(GET/PUT...)
as shown for gfortran.dg/random_seed_1.f90 and the original test
in pr52879. This likely makes the patch stage 1 material.

AFAIU my tests in pr52879, comment 1, the generated sequence for real
does not depend on the four first integers. From a user point of view,
this surprising (may be undocumented, I did not check).

So I think the seed generation should keep the present properties
and only add a way to randomize the 12 integers.

Thanks for working on it.

Dominique

             reply	other threads:[~2014-02-09 14:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-09 14:31 Dominique Dhumieres [this message]
2014-02-09 17:06 ` Steve Kargl
  -- strict thread matches above, loose matches on Subject: below --
2014-02-09  0:40 Steve Kargl
2014-02-10 15:23 ` Janne Blomqvist
2014-02-10 16:27   ` Steve Kargl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140209143109.181EB104@mailhost.lps.ens.fr \
    --to=dominiq@lps.ens.fr \
    --cc=fortran@gcc.gnu.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=nmm1@cam.ac.uk \
    --cc=sgk@troutmask.apl.washington.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).