From: Dominik Vogt <vogt@linux.vnet.ibm.com>
To: gcc-patches@gcc.gnu.org
Cc: Andreas Krebbel <krebbel@linux.vnet.ibm.com>
Subject: [PATCH] S390: Fix crash with -mhotpatch and gfortran
Date: Wed, 12 Feb 2014 10:28:00 -0000 [thread overview]
Message-ID: <20140212102838.GA10947@linux.vnet.ibm.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 310 bytes --]
The attached patch fixes a crash if gfortran encounters a nested
function when -mhotpatch is enabled. (It slightly improves the
warning message too.)
This patch affects s390 only. Andreas Krebbel will commit the
patch soon, if there are no objections.
Ciao
Dominik ^_^ ^_^
--
Dominik Vogt
IBM Germany
[-- Attachment #2: gcc-4.9-0001-S390-Fix-crash-when-mhotpatch-encounters-nested-func.patch --]
[-- Type: text/x-diff, Size: 974 bytes --]
From 352cf98ffb32c1f0fa8b961314faf6e6afffb661 Mon Sep 17 00:00:00 2001
From: Dominik Vogt <vogt@de.ibm.com>
Date: Wed, 12 Feb 2014 05:53:34 +0000
Subject: [PATCH 1/2] S390: Fix crash when -mhotpatch encounters nested
functions
(e.g. with gfortran).
---
gcc/config/s390/s390.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/gcc/config/s390/s390.c b/gcc/config/s390/s390.c
index 32a25a4..9ae8ffd 100644
--- a/gcc/config/s390/s390.c
+++ b/gcc/config/s390/s390.c
@@ -5510,9 +5510,8 @@ s390_asm_output_function_label (FILE *asm_out_file, const char *fname,
if (hotpatch_trampoline_halfwords >= 0
&& decl_function_context (decl) != NULL_TREE)
{
- warning_at (0, DECL_SOURCE_LOCATION (decl),
- "hotpatch_prologue is not compatible with nested"
- " function");
+ warning_at (0, OPT_mhotpatch,
+ "hotpatching is not compatible with nested functions");
hotpatch_trampoline_halfwords = -1;
}
}
--
1.8.3.1
[-- Attachment #3: gcc-4.9-ChangeLog --]
[-- Type: text/plain, Size: 225 bytes --]
2014-02-12 Dominik Vogt <vogt@linux.vnet.ibm.com>
* config/s390/s390.c (s390_asm_output_function_label):
fix crash caused by bad second argument to warning_at() with -mhotpatch
and nested functions (e.g. with gfortran)
next reply other threads:[~2014-02-12 10:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-12 10:28 Dominik Vogt [this message]
2014-02-12 10:30 ` [PATCH] (gcc-4.8) " Dominik Vogt
2014-02-13 5:51 ` Dominik Vogt
2014-02-13 12:40 ` Andreas Krebbel
2014-02-12 11:34 ` [PATCH] " Richard Sandiford
2014-02-13 5:48 ` Dominik Vogt
2014-02-13 12:41 ` Andreas Krebbel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140212102838.GA10947@linux.vnet.ibm.com \
--to=vogt@linux.vnet.ibm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=krebbel@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).