[PATCH] Fix PR 60203: No direct move support for long double/_Decimal128 on powerpc ISA 2.07

[PATCH] Fix PR 60203: No direct move support for long double/_Decimal128 on powerpc ISA 2.07

[Michael Meissner]

[-- Attachment #1: Type: text/plain, Size: 1266 bytes --]

When I added direct move support for ISA 2.07 (power8), I did not add direct
move support for long double and _Decimal128 types.  This patch adds the direct
move support for those types when you are running in 64-bit mode.  Now, there
are still the problems raised in PR 25972 on machines without direct move, but
this simple patch does help the machines with direct move.

I bootstrapped the compiler with/without the change, and there were no
regressions in the test suite.  Is it ok to check into the tree?

[gcc]
2014-02-14  Michael Meissner  <meissner@linux.vnet.ibm.com>

	PR target/60203
	* config/rs6000/rs6000.md (rreg): Add TFmode, TDmode constraints.
	(mov<mode>_internal, TFmode/TDmode): Split TFmode/TDmode moves
	into 64-bit and 32-bit moves.  On 64-bit moves, add support for
	using direct move instructions on ISA 2.07.  Also adjust
	instruction length for 64-bit.
	(mov<mode>_64bit, TFmode/TDmode): Likewise.
	(mov<mode>_32bit, TFmode/TDmode): Likewise.

[gcc/testsuite]
2014-02-14  Michael Meissner  <meissner@linux.vnet.ibm.com>

	PR target/60203
	* gcc.target/powerpc/pr60203.c: New testsuite.


-- 
Michael Meissner, IBM
IBM, M/S 2506R, 550 King Street, Littleton, MA 01460-6245, USA
email: meissner@linux.vnet.ibm.com, phone: +1 (978) 899-4797

[-- Attachment #2: pr60203.patch01b --]
[-- Type: text/plain, Size: 1532 bytes --]

Index: gcc/config/rs6000/rs6000.md
===================================================================
--- gcc/config/rs6000/rs6000.md	(revision 207791)
+++ gcc/config/rs6000/rs6000.md	(working copy)
@@ -387,6 +387,8 @@ (define_mode_attr ptrm [(SI "m")
 
 (define_mode_attr rreg [(SF   "f")
 			(DF   "ws")
+			(TF   "f")
+			(TD   "f")
 			(V4SF "wf")
 			(V2DF "wd")])
 
@@ -9524,10 +9526,22 @@ (define_expand "mov<mode>"
 ;; It's important to list Y->r and r->Y before r->r because otherwise
 ;; reload, given m->r, will try to pick r->r and reload it, which
 ;; doesn't make progress.
-(define_insn_and_split "*mov<mode>_internal"
+(define_insn_and_split "*mov<mode>_64bit"
+  [(set (match_operand:FMOVE128 0 "nonimmediate_operand" "=m,d,d,Y,r,r,r,wm")
+	(match_operand:FMOVE128 1 "input_operand" "d,m,d,r,YGHF,r,wm,r"))]
+  "TARGET_HARD_FLOAT && TARGET_FPRS && TARGET_POWERPC64
+   && (gpc_reg_operand (operands[0], <MODE>mode)
+       || gpc_reg_operand (operands[1], <MODE>mode))"
+  "#"
+  "&& reload_completed"
+  [(pc)]
+{ rs6000_split_multireg_move (operands[0], operands[1]); DONE; }
+  [(set_attr "length" "8,8,8,12,12,8,8,8")])
+
+(define_insn_and_split "*mov<mode>_32bit"
   [(set (match_operand:FMOVE128 0 "nonimmediate_operand" "=m,d,d,Y,r,r")
 	(match_operand:FMOVE128 1 "input_operand" "d,m,d,r,YGHF,r"))]
-  "TARGET_HARD_FLOAT && TARGET_FPRS
+  "TARGET_HARD_FLOAT && TARGET_FPRS && !TARGET_POWERPC64
    && (gpc_reg_operand (operands[0], <MODE>mode)
        || gpc_reg_operand (operands[1], <MODE>mode))"
   "#"

Re: [PATCH] Fix PR 60203: No direct move support for long double/_Decimal128 on powerpc ISA 2.07

[Michael Meissner]

[-- Attachment #1: Type: text/plain, Size: 195 bytes --]

I forgot to add the new test to my patches.

-- 
Michael Meissner, IBM
IBM, M/S 2506R, 550 King Street, Littleton, MA 01460-6245, USA
email: meissner@linux.vnet.ibm.com, phone: +1 (978) 899-4797

[-- Attachment #2: pr60203.patch01c --]
[-- Type: text/plain, Size: 1265 bytes --]

2014-02-14  Michael Meissner  <meissner@linux.vnet.ibm.com>

	PR target/60203
	* gcc.target/powerpc/pr60203.c: New testsuite.

Index: gcc/testsuite/gcc.target/powerpc/pr60203.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/pr60203.c	(revision 0)
+++ gcc/testsuite/gcc.target/powerpc/pr60203.c	(revision 0)
@@ -0,0 +1,40 @@
+/* { dg-do compile { target { powerpc*-*-* && lp64 } } } */
+/* { dg-skip-if "" { powerpc*-*-darwin* } { "*" } { "" } } */
+/* { dg-require-effective-target powerpc_p8vector_ok } */
+/* { dg-options "-mcpu=power8 -O3" } */
+
+union u_ld { long double ld; double d[2]; };
+
+long double
+pack (double a, double aa)
+{
+  union u_ld u;
+  u.d[0] = a;
+  u.d[1] = aa;
+  return u.ld;
+}
+
+double
+unpack_0 (long double x)
+{
+  union u_ld u;
+  u.ld = x;
+  return u.d[0];
+}
+
+double
+unpack_1 (long double x)
+{
+  union u_ld u;
+  u.ld = x;
+  return u.d[1];
+}
+
+/* { dg-final { scan-assembler-not "stfd"   } } */
+/* { dg-final { scan-assembler-not "lfd"    } } */
+/* { dg-final { scan-assembler-not "lxsdx"  } } */
+/* { dg-final { scan-assembler-not "stxsdx" } } */
+/* { dg-final { scan-assembler-not "mfvsrd" } } */
+/* { dg-final { scan-assembler-not "mtvsrd" } } */
+
+

Re: [PATCH] Fix PR 60203: No direct move support for long double/_Decimal128 on powerpc ISA 2.07

[David Edelsohn]

On Fri, Feb 14, 2014 at 5:59 PM, Michael Meissner
<meissner@linux.vnet.ibm.com> wrote:
> When I added direct move support for ISA 2.07 (power8), I did not add direct
> move support for long double and _Decimal128 types.  This patch adds the direct
> move support for those types when you are running in 64-bit mode.  Now, there
> are still the problems raised in PR 25972 on machines without direct move, but
> this simple patch does help the machines with direct move.
>
> I bootstrapped the compiler with/without the change, and there were no
> regressions in the test suite.  Is it ok to check into the tree?
>
> [gcc]
> 2014-02-14  Michael Meissner  <meissner@linux.vnet.ibm.com>
>
>         PR target/60203
>         * config/rs6000/rs6000.md (rreg): Add TFmode, TDmode constraints.
>         (mov<mode>_internal, TFmode/TDmode): Split TFmode/TDmode moves
>         into 64-bit and 32-bit moves.  On 64-bit moves, add support for
>         using direct move instructions on ISA 2.07.  Also adjust
>         instruction length for 64-bit.
>         (mov<mode>_64bit, TFmode/TDmode): Likewise.
>         (mov<mode>_32bit, TFmode/TDmode): Likewise.
>
> [gcc/testsuite]
> 2014-02-14  Michael Meissner  <meissner@linux.vnet.ibm.com>
>
>         PR target/60203
>         * gcc.target/powerpc/pr60203.c: New testsuite.

Okay.

Thanks, David