* Fix wrong code issue in ipa-devirt
@ 2014-04-08 4:13 Jan Hubicka
2014-04-08 16:28 ` Martin Jambor
0 siblings, 1 reply; 3+ messages in thread
From: Jan Hubicka @ 2014-04-08 4:13 UTC (permalink / raw)
To: gcc-patches, mjambor
Hi,
while looking into devirtualization dumps, I noticed that I got one "false"
typed out as "true". Not sure what I was thinking of.
Martin, this may fix the wrong code issue you see in Firefox, hopefully.
Will commit it after x86_64-linux testing finishes tomorrow.
Honza
* ipa-devirt.c (maybe_record_node): Set completep to false
instead of true when node is not recorded.
Index: ipa-devirt.c
===================================================================
--- ipa-devirt.c (revision 209170)
+++ ipa-devirt.c (working copy)
@@ -650,7 +650,7 @@ maybe_record_node (vec <cgraph_node *> &
else if (completep
&& !type_in_anonymous_namespace_p
(method_class_type (TREE_TYPE (target))))
- *completep = true;
+ *completep = false;
}
/* See if BINFO's type match OUTER_TYPE. If so, lookup
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Fix wrong code issue in ipa-devirt
2014-04-08 4:13 Fix wrong code issue in ipa-devirt Jan Hubicka
@ 2014-04-08 16:28 ` Martin Jambor
2014-04-08 17:11 ` Jan Hubicka
0 siblings, 1 reply; 3+ messages in thread
From: Martin Jambor @ 2014-04-08 16:28 UTC (permalink / raw)
To: Jan Hubicka; +Cc: gcc-patches
Hi,
On Tue, Apr 08, 2014 at 06:13:27AM +0200, Jan Hubicka wrote:
> Hi,
> while looking into devirtualization dumps, I noticed that I got one "false"
> typed out as "true". Not sure what I was thinking of.
>
> Martin, this may fix the wrong code issue you see in Firefox, hopefully.
it did not segfault the whole afternoon, so yes, I believe this is the
fix.
Thanks,
Martin
>
> Will commit it after x86_64-linux testing finishes tomorrow.
> Honza
>
> * ipa-devirt.c (maybe_record_node): Set completep to false
> instead of true when node is not recorded.
> Index: ipa-devirt.c
> ===================================================================
> --- ipa-devirt.c (revision 209170)
> +++ ipa-devirt.c (working copy)
> @@ -650,7 +650,7 @@ maybe_record_node (vec <cgraph_node *> &
> else if (completep
> && !type_in_anonymous_namespace_p
> (method_class_type (TREE_TYPE (target))))
> - *completep = true;
> + *completep = false;
> }
>
> /* See if BINFO's type match OUTER_TYPE. If so, lookup
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Fix wrong code issue in ipa-devirt
2014-04-08 16:28 ` Martin Jambor
@ 2014-04-08 17:11 ` Jan Hubicka
0 siblings, 0 replies; 3+ messages in thread
From: Jan Hubicka @ 2014-04-08 17:11 UTC (permalink / raw)
To: Jan Hubicka, gcc-patches
> Hi,
>
> On Tue, Apr 08, 2014 at 06:13:27AM +0200, Jan Hubicka wrote:
> > Hi,
> > while looking into devirtualization dumps, I noticed that I got one "false"
> > typed out as "true". Not sure what I was thinking of.
> >
> > Martin, this may fix the wrong code issue you see in Firefox, hopefully.
>
> it did not segfault the whole afternoon, so yes, I believe this is the
> fix.
Great, because all builds of firefox now segfaults for me at startup, so I will
try to fix my setup ;))
Honza
>
> Thanks,
>
> Martin
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-04-08 17:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-04-08 4:13 Fix wrong code issue in ipa-devirt Jan Hubicka
2014-04-08 16:28 ` Martin Jambor
2014-04-08 17:11 ` Jan Hubicka
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).