From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27747 invoked by alias); 16 Apr 2014 18:45:42 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 27738 invoked by uid 89); 16 Apr 2014 18:45:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.0 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 16 Apr 2014 18:45:41 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s3GIjd4d003196 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 16 Apr 2014 14:45:40 -0400 Received: from greed.delorie.com (ovpn-113-46.phx2.redhat.com [10.3.113.46]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s3GIjc3i028385 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Wed, 16 Apr 2014 14:45:39 -0400 Received: from greed.delorie.com (greed.delorie.com [127.0.0.1]) by greed.delorie.com (8.14.4/8.14.4) with ESMTP id s3GIjb8q001908; Wed, 16 Apr 2014 14:45:37 -0400 Received: (from dj@localhost) by greed.delorie.com (8.14.4/8.14.4/Submit) id s3GIjbLo001907; Wed, 16 Apr 2014 14:45:37 -0400 Date: Wed, 16 Apr 2014 19:13:00 -0000 Message-Id: <201404161845.s3GIjbLo001907@greed.delorie.com> From: DJ Delorie To: Jakub Jelinek CC: bonzini@gnu.org, aoliva@redhat.com, Ralf.Wildenhues@gmx.de, rguenther@suse.de, gcc-patches@gcc.gnu.org In-reply-to: <20140414110209.GO1817@tucnak.redhat.com> (message from Jakub Jelinek on Mon, 14 Apr 2014 13:02:09 +0200) Subject: Re: Patch ping References: <20140409130721.GK1817@tucnak.redhat.com> <201404092229.s39MTmXp015920@greed.delorie.com> <20140410055906.GP1817@tucnak.redhat.com> <201404101601.s3AG1VSv012678@greed.delorie.com> <20140414110209.GO1817@tucnak.redhat.com> X-IsSubscribed: yes X-SW-Source: 2014-04/txt/msg00926.txt.bz2 I'll approve both patches, if you agree to think about a way to solve this problem without module-specific configury changes for each such command line option. I understand the usefulness of having instrumentation, but the configure hack is a hack. Note that in a combined tree this isn't a problem, because we'd just instrument the linker at the same time.