From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11585 invoked by alias); 17 Apr 2014 12:16:53 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 11572 invoked by uid 89); 17 Apr 2014 12:16:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.9 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 17 Apr 2014 12:16:52 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s3HCGoOX007318 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 17 Apr 2014 08:16:50 -0400 Received: from tucnak.zalov.cz (ovpn-116-44.ams2.redhat.com [10.36.116.44]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s3HCGmPx025368 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Thu, 17 Apr 2014 08:16:50 -0400 Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.14.8/8.14.7) with ESMTP id s3HCGkpN016237; Thu, 17 Apr 2014 14:16:47 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.14.8/8.14.8/Submit) id s3HCGifQ016236; Thu, 17 Apr 2014 14:16:44 +0200 Date: Thu, 17 Apr 2014 12:21:00 -0000 From: Jakub Jelinek To: DJ Delorie Cc: bonzini@gnu.org, aoliva@redhat.com, Ralf.Wildenhues@gmx.de, rguenther@suse.de, gcc-patches@gcc.gnu.org Subject: Re: Patch ping Message-ID: <20140417121644.GU1817@tucnak.redhat.com> Reply-To: Jakub Jelinek References: <20140409130721.GK1817@tucnak.redhat.com> <201404092229.s39MTmXp015920@greed.delorie.com> <20140410055906.GP1817@tucnak.redhat.com> <201404101601.s3AG1VSv012678@greed.delorie.com> <20140414110209.GO1817@tucnak.redhat.com> <201404161845.s3GIjbLo001907@greed.delorie.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201404161845.s3GIjbLo001907@greed.delorie.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2014-04/txt/msg00997.txt.bz2 On Wed, Apr 16, 2014 at 02:45:37PM -0400, DJ Delorie wrote: > I'll approve both patches, if you agree to think about a way to solve > this problem without module-specific configury changes for each such > command line option. I understand the usefulness of having > instrumentation, but the configure hack is a hack. Only the second patch I'd consider a hack, the first patch merely makes sure the POSTSTAGE1_LDFLAGS stuff actually isn't eaten by libtool. I'll think about other options for the second patch. > Note that in a combined tree this isn't a problem, because we'd just > instrument the linker at the same time. Only if you never use the plugin from the combined tree build with any other linker. Add -B ../ to some other linker and suddenly it will crash. Jakub