* [Patch, avr] Propagate -mrelax gcc driver flag to assembler
@ 2014-04-11 17:57 Senthil Kumar Selvaraj
2014-04-12 16:36 ` Georg-Johann Lay
0 siblings, 1 reply; 12+ messages in thread
From: Senthil Kumar Selvaraj @ 2014-04-11 17:57 UTC (permalink / raw)
To: gcc-patches; +Cc: chertykov, gjl
This patch modifies AVR target's ASM spec to pass -mlink-relax to the
assembler if -mrelax is passed to the compiler driver. This was already
being passed on to the linker, this patch merely makes the assembler
also aware of it.
The corresponding patch in binutils to handle the -mlink-relax patch is
already committed in the binutils repo. I'm not sure how to manage a
running a newer gcc with an older version of binutils though - how is this
generally handled?
If ok, could someone commit please? I don't have commit access.
Regards
Senthil
2014-04-11 Senthil Kumar Selvaraj <senthil_kumar.selvaraj@atmel.com>
* config/avr/avr.h: Modify ASM_SPEC to pass -mlink-relax
to assembler.
diff --git gcc/config/avr/avr.h gcc/config/avr/avr.h
index 78434ec..c1b4dd9 100644
--- gcc/config/avr/avr.h
+++ gcc/config/avr/avr.h
@@ -512,7 +512,8 @@ extern const char *avr_device_to_sp8 (int argc, const char **argv);
%{!fenforce-eh-specs:-fno-enforce-eh-specs} \
%{!fexceptions:-fno-exceptions}"
-#define ASM_SPEC "%:device_to_as(%{mmcu=*:%*}) "
+#define ASM_SPEC "%:device_to_as(%{mmcu=*:%*})\
+%{mrelax:-mlink-relax}"
#define LINK_SPEC "\
%{mrelax:--relax\
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Patch, avr] Propagate -mrelax gcc driver flag to assembler
2014-04-11 17:57 [Patch, avr] Propagate -mrelax gcc driver flag to assembler Senthil Kumar Selvaraj
@ 2014-04-12 16:36 ` Georg-Johann Lay
2014-04-18 10:05 ` Senthil Kumar Selvaraj
0 siblings, 1 reply; 12+ messages in thread
From: Georg-Johann Lay @ 2014-04-12 16:36 UTC (permalink / raw)
To: Senthil Kumar Selvaraj; +Cc: gcc-patches, chertykov
Senthil Kumar Selvaraj schrieb:
> This patch modifies AVR target's ASM spec to pass -mlink-relax to the
> assembler if -mrelax is passed to the compiler driver. This was already
> being passed on to the linker, this patch merely makes the assembler
> also aware of it.
>
> The corresponding patch in binutils to handle the -mlink-relax patch is
> already committed in the binutils repo. I'm not sure how to manage a
> running a newer gcc with an older version of binutils though - how is this
> generally handled?
The right place is gcc/configure.ac and have a macro defined depending
on whether gas supports -mlink-relax.
Same should be done for -mrmw, IMO, for similar reasons, e.g. something like
case "$target" in
...
avr-*-*)
...
gcc_GAS_CHECK_FEATURE([-mrmw option], gcc_cv_as_avr_mrmw,,
[-mrmw], [.text],,
[AC_DEFINE(HAVE_AS_AVR_MRMW_OPTION, 1,
[Define if your assembler supports -mrmw option.])])
or
gcc_GAS_CHECK_FEATURE([-mrmw option], gcc_cv_as_avr_mrmw,,
[-mrmw], [.text],,,)
if test x$gcc_cv_as_avr_mrmw = xyes; then
AC_DEFINE(HAVE_AS_AVR_MRMW_OPTION, 1,
[Define if your assembler supports the -mrmw option.])
However, the gcc-4_9-branch has already been created...
Johann
> If ok, could someone commit please? I don't have commit access.
>
> Regards
> Senthil
>
> 2014-04-11 Senthil Kumar Selvaraj <senthil_kumar.selvaraj@atmel.com>
>
> * config/avr/avr.h: Modify ASM_SPEC to pass -mlink-relax
> to assembler.
>
>
> diff --git gcc/config/avr/avr.h gcc/config/avr/avr.h
> index 78434ec..c1b4dd9 100644
> --- gcc/config/avr/avr.h
> +++ gcc/config/avr/avr.h
> @@ -512,7 +512,8 @@ extern const char *avr_device_to_sp8 (int argc, const char **argv);
> %{!fenforce-eh-specs:-fno-enforce-eh-specs} \
> %{!fexceptions:-fno-exceptions}"
>
> -#define ASM_SPEC "%:device_to_as(%{mmcu=*:%*}) "
> +#define ASM_SPEC "%:device_to_as(%{mmcu=*:%*})\
> +%{mrelax:-mlink-relax}"
>
> #define LINK_SPEC "\
> %{mrelax:--relax\
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Patch, avr] Propagate -mrelax gcc driver flag to assembler
2014-04-12 16:36 ` Georg-Johann Lay
@ 2014-04-18 10:05 ` Senthil Kumar Selvaraj
2014-05-12 10:21 ` Senthil Kumar Selvaraj
2014-05-12 11:18 ` Georg-Johann Lay
0 siblings, 2 replies; 12+ messages in thread
From: Senthil Kumar Selvaraj @ 2014-04-18 10:05 UTC (permalink / raw)
To: Georg-Johann Lay, chertykov; +Cc: gcc-patches
On Sat, Apr 12, 2014 at 06:36:01PM +0200, Georg-Johann Lay wrote:
> Senthil Kumar Selvaraj schrieb:
> >This patch modifies AVR target's ASM spec to pass -mlink-relax to the
> >assembler if -mrelax is passed to the compiler driver. This was already
> >being passed on to the linker, this patch merely makes the assembler
> >also aware of it.
> >
> >The corresponding patch in binutils to handle the -mlink-relax patch is
> >already committed in the binutils repo. I'm not sure how to manage a
> >running a newer gcc with an older version of binutils though - how is this
> >generally handled?
>
> The right place is gcc/configure.ac and have a macro defined depending on
> whether gas supports -mlink-relax.
>
>
> Same should be done for -mrmw, IMO, for similar reasons, e.g. something like
>
> case "$target" in
> ...
> avr-*-*)
> ...
> gcc_GAS_CHECK_FEATURE([-mrmw option], gcc_cv_as_avr_mrmw,,
> [-mrmw], [.text],,
> [AC_DEFINE(HAVE_AS_AVR_MRMW_OPTION, 1,
> [Define if your assembler supports -mrmw option.])])
>
> or
>
> gcc_GAS_CHECK_FEATURE([-mrmw option], gcc_cv_as_avr_mrmw,,
> [-mrmw], [.text],,,)
> if test x$gcc_cv_as_avr_mrmw = xyes; then
> AC_DEFINE(HAVE_AS_AVR_MRMW_OPTION, 1,
> [Define if your assembler supports the -mrmw option.])
>
Thanks Johann. The below patch adds the configury check for -mlink-relax,
along with the change to ASM_SPEC to propagate the -mrelax flag. I
modified the original patch a bit to make it easier to handle
conditional additions to SPECs (inspired by the sparc target).
>
> However, the gcc-4_9-branch has already been created...
Yes, but I figured it would be useful anyway - if this eventually gets
backported to 4_9, for example.
If the below patch looks ok, could someone commit please? I don't have
commit access.
Regards
Senthil
gcc/ChangeLog
2014-04-18 Senthil Kumar Selvaraj <senthil_kumar.selvaraj@atmel.com>
* config/avr/avr.h: Pass on mlink-relax to assembler.
* configure.ac: Test for mlink-relax support in assembler.
* configure: Regenerate.
diff --git gcc/config/avr/avr.h gcc/config/avr/avr.h
index 78434ec..b4e3eb1 100644
--- gcc/config/avr/avr.h
+++ gcc/config/avr/avr.h
@@ -512,7 +512,28 @@ extern const char *avr_device_to_sp8 (int argc, const char **argv);
%{!fenforce-eh-specs:-fno-enforce-eh-specs} \
%{!fexceptions:-fno-exceptions}"
-#define ASM_SPEC "%:device_to_as(%{mmcu=*:%*}) "
+#ifdef HAVE_AS_RELAX_OPTION
+#define ASM_RELAX_SPEC "%{mrelax:-mlink-relax}"
+#else
+#define ASM_RELAX_SPEC ""
+#endif
+
+#define ASM_SPEC "%:device_to_as(%{mmcu=*:%*})\
+%(asm_relax)"
+
+/* This macro defines names of additional specifications to put in the specs
+ that can be used in various specifications like CC1_SPEC. Its definition
+ is an initializer with a subgrouping for each command option.
+
+ Each subgrouping contains a string constant, that defines the
+ specification name, and a string constant that used by the GCC driver
+ program.
+
+ Do not define this macro if it does not need to do anything. */
+
+#define EXTRA_SPECS \
+ { "asm_relax", ASM_RELAX_SPEC }
+
#define LINK_SPEC "\
%{mrelax:--relax\
diff --git gcc/configure gcc/configure
index bfb1525..7815038 100755
--- gcc/configure
+++ gcc/configure
@@ -24142,6 +24142,39 @@ $as_echo "#define HAVE_AS_JSRDIRECT_RELOCS 1" >>confdefs.h
fi
;;
+ avr-*-*)
+ { $as_echo "$as_me:${as_lineno-$LINENO}: checking assembler for -mlink-relax option" >&5
+$as_echo_n "checking assembler for -mlink-relax option... " >&6; }
+if test "${gcc_cv_as_avr_relax+set}" = set; then :
+ $as_echo_n "(cached) " >&6
+else
+ gcc_cv_as_avr_relax=no
+ if test x$gcc_cv_as != x; then
+ $as_echo '.text' > conftest.s
+ if { ac_try='$gcc_cv_as $gcc_cv_as_flags -mlink-relax -o conftest.o conftest.s >&5'
+ { { eval echo "\"\$as_me\":${as_lineno-$LINENO}: \"$ac_try\""; } >&5
+ (eval $ac_try) 2>&5
+ ac_status=$?
+ $as_echo "$as_me:${as_lineno-$LINENO}: \$? = $ac_status" >&5
+ test $ac_status = 0; }; }
+ then
+ gcc_cv_as_avr_relax=yes
+ else
+ echo "configure: failed program was" >&5
+ cat conftest.s >&5
+ fi
+ rm -f conftest.o conftest.s
+ fi
+fi
+{ $as_echo "$as_me:${as_lineno-$LINENO}: result: $gcc_cv_as_avr_relax" >&5
+$as_echo "$gcc_cv_as_avr_relax" >&6; }
+if test $gcc_cv_as_avr_relax = yes; then
+
+$as_echo "#define HAVE_AS_RELAX_OPTION 1" >>confdefs.h
+
+fi
+ ;;
+
cris-*-*)
{ $as_echo "$as_me:${as_lineno-$LINENO}: checking assembler for -no-mul-bug-abort option" >&5
$as_echo_n "checking assembler for -no-mul-bug-abort option... " >&6; }
diff --git gcc/configure.ac gcc/configure.ac
index d7cae6c..cfa862d 100644
--- gcc/configure.ac
+++ gcc/configure.ac
@@ -3579,6 +3579,13 @@ case "$target" in
[Define if your assembler supports the lituse_jsrdirect relocation.])])
;;
+ avr-*-*)
+ gcc_GAS_CHECK_FEATURE([-mlink-relax option], gcc_cv_as_avr_relax,,
+ [-mlink-relax], [.text],,
+ [AC_DEFINE(HAVE_AS_RELAX_OPTION, 1,
+ [Define if your assembler supports -mlink-relax option.])])
+ ;;
+
cris-*-*)
gcc_GAS_CHECK_FEATURE([-no-mul-bug-abort option],
gcc_cv_as_cris_no_mul_bug,[2,15,91],
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Patch, avr] Propagate -mrelax gcc driver flag to assembler
2014-04-18 10:05 ` Senthil Kumar Selvaraj
@ 2014-05-12 10:21 ` Senthil Kumar Selvaraj
2014-05-12 11:18 ` Georg-Johann Lay
1 sibling, 0 replies; 12+ messages in thread
From: Senthil Kumar Selvaraj @ 2014-05-12 10:21 UTC (permalink / raw)
To: chertykov; +Cc: gcc-patches
Ping!
Regards
Senthil
On Fri, Apr 18, 2014 at 03:22:46PM +0530, Senthil Kumar Selvaraj wrote:
>
> On Sat, Apr 12, 2014 at 06:36:01PM +0200, Georg-Johann Lay wrote:
> > Senthil Kumar Selvaraj schrieb:
> > >This patch modifies AVR target's ASM spec to pass -mlink-relax to the
> > >assembler if -mrelax is passed to the compiler driver. This was already
> > >being passed on to the linker, this patch merely makes the assembler
> > >also aware of it.
> > >
> > >The corresponding patch in binutils to handle the -mlink-relax patch is
> > >already committed in the binutils repo. I'm not sure how to manage a
> > >running a newer gcc with an older version of binutils though - how is this
> > >generally handled?
> >
> > The right place is gcc/configure.ac and have a macro defined depending on
> > whether gas supports -mlink-relax.
> >
> >
> > Same should be done for -mrmw, IMO, for similar reasons, e.g. something like
> >
> > case "$target" in
> > ...
> > avr-*-*)
> > ...
> > gcc_GAS_CHECK_FEATURE([-mrmw option], gcc_cv_as_avr_mrmw,,
> > [-mrmw], [.text],,
> > [AC_DEFINE(HAVE_AS_AVR_MRMW_OPTION, 1,
> > [Define if your assembler supports -mrmw option.])])
> >
> > or
> >
> > gcc_GAS_CHECK_FEATURE([-mrmw option], gcc_cv_as_avr_mrmw,,
> > [-mrmw], [.text],,,)
> > if test x$gcc_cv_as_avr_mrmw = xyes; then
> > AC_DEFINE(HAVE_AS_AVR_MRMW_OPTION, 1,
> > [Define if your assembler supports the -mrmw option.])
> >
>
> Thanks Johann. The below patch adds the configury check for -mlink-relax,
> along with the change to ASM_SPEC to propagate the -mrelax flag. I
> modified the original patch a bit to make it easier to handle
> conditional additions to SPECs (inspired by the sparc target).
>
> >
> > However, the gcc-4_9-branch has already been created...
>
> Yes, but I figured it would be useful anyway - if this eventually gets
> backported to 4_9, for example.
>
> If the below patch looks ok, could someone commit please? I don't have
> commit access.
>
> Regards
> Senthil
>
> gcc/ChangeLog
>
> 2014-04-18 Senthil Kumar Selvaraj <senthil_kumar.selvaraj@atmel.com>
>
> * config/avr/avr.h: Pass on mlink-relax to assembler.
> * configure.ac: Test for mlink-relax support in assembler.
> * configure: Regenerate.
>
> diff --git gcc/config/avr/avr.h gcc/config/avr/avr.h
> index 78434ec..b4e3eb1 100644
> --- gcc/config/avr/avr.h
> +++ gcc/config/avr/avr.h
> @@ -512,7 +512,28 @@ extern const char *avr_device_to_sp8 (int argc, const char **argv);
> %{!fenforce-eh-specs:-fno-enforce-eh-specs} \
> %{!fexceptions:-fno-exceptions}"
>
> -#define ASM_SPEC "%:device_to_as(%{mmcu=*:%*}) "
> +#ifdef HAVE_AS_RELAX_OPTION
> +#define ASM_RELAX_SPEC "%{mrelax:-mlink-relax}"
> +#else
> +#define ASM_RELAX_SPEC ""
> +#endif
> +
> +#define ASM_SPEC "%:device_to_as(%{mmcu=*:%*})\
> +%(asm_relax)"
> +
> +/* This macro defines names of additional specifications to put in the specs
> + that can be used in various specifications like CC1_SPEC. Its definition
> + is an initializer with a subgrouping for each command option.
> +
> + Each subgrouping contains a string constant, that defines the
> + specification name, and a string constant that used by the GCC driver
> + program.
> +
> + Do not define this macro if it does not need to do anything. */
> +
> +#define EXTRA_SPECS \
> + { "asm_relax", ASM_RELAX_SPEC }
> +
>
> #define LINK_SPEC "\
> %{mrelax:--relax\
> diff --git gcc/configure gcc/configure
> index bfb1525..7815038 100755
> --- gcc/configure
> +++ gcc/configure
> @@ -24142,6 +24142,39 @@ $as_echo "#define HAVE_AS_JSRDIRECT_RELOCS 1" >>confdefs.h
> fi
> ;;
>
> + avr-*-*)
> + { $as_echo "$as_me:${as_lineno-$LINENO}: checking assembler for -mlink-relax option" >&5
> +$as_echo_n "checking assembler for -mlink-relax option... " >&6; }
> +if test "${gcc_cv_as_avr_relax+set}" = set; then :
> + $as_echo_n "(cached) " >&6
> +else
> + gcc_cv_as_avr_relax=no
> + if test x$gcc_cv_as != x; then
> + $as_echo '.text' > conftest.s
> + if { ac_try='$gcc_cv_as $gcc_cv_as_flags -mlink-relax -o conftest.o conftest.s >&5'
> + { { eval echo "\"\$as_me\":${as_lineno-$LINENO}: \"$ac_try\""; } >&5
> + (eval $ac_try) 2>&5
> + ac_status=$?
> + $as_echo "$as_me:${as_lineno-$LINENO}: \$? = $ac_status" >&5
> + test $ac_status = 0; }; }
> + then
> + gcc_cv_as_avr_relax=yes
> + else
> + echo "configure: failed program was" >&5
> + cat conftest.s >&5
> + fi
> + rm -f conftest.o conftest.s
> + fi
> +fi
> +{ $as_echo "$as_me:${as_lineno-$LINENO}: result: $gcc_cv_as_avr_relax" >&5
> +$as_echo "$gcc_cv_as_avr_relax" >&6; }
> +if test $gcc_cv_as_avr_relax = yes; then
> +
> +$as_echo "#define HAVE_AS_RELAX_OPTION 1" >>confdefs.h
> +
> +fi
> + ;;
> +
> cris-*-*)
> { $as_echo "$as_me:${as_lineno-$LINENO}: checking assembler for -no-mul-bug-abort option" >&5
> $as_echo_n "checking assembler for -no-mul-bug-abort option... " >&6; }
> diff --git gcc/configure.ac gcc/configure.ac
> index d7cae6c..cfa862d 100644
> --- gcc/configure.ac
> +++ gcc/configure.ac
> @@ -3579,6 +3579,13 @@ case "$target" in
> [Define if your assembler supports the lituse_jsrdirect relocation.])])
> ;;
>
> + avr-*-*)
> + gcc_GAS_CHECK_FEATURE([-mlink-relax option], gcc_cv_as_avr_relax,,
> + [-mlink-relax], [.text],,
> + [AC_DEFINE(HAVE_AS_RELAX_OPTION, 1,
> + [Define if your assembler supports -mlink-relax option.])])
> + ;;
> +
> cris-*-*)
> gcc_GAS_CHECK_FEATURE([-no-mul-bug-abort option],
> gcc_cv_as_cris_no_mul_bug,[2,15,91],
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Patch, avr] Propagate -mrelax gcc driver flag to assembler
2014-04-18 10:05 ` Senthil Kumar Selvaraj
2014-05-12 10:21 ` Senthil Kumar Selvaraj
@ 2014-05-12 11:18 ` Georg-Johann Lay
2014-05-13 12:49 ` Senthil Kumar Selvaraj
1 sibling, 1 reply; 12+ messages in thread
From: Georg-Johann Lay @ 2014-05-12 11:18 UTC (permalink / raw)
To: Senthil Kumar Selvaraj; +Cc: Denis Chertykov, GCC Patches
Am 04/18/2014 11:52 AM, schrieb Senthil Kumar Selvaraj:
>
> On Sat, Apr 12, 2014 at 06:36:01PM +0200, Georg-Johann Lay wrote:
>> Senthil Kumar Selvaraj schrieb:
>>> This patch modifies AVR target's ASM spec to pass -mlink-relax to the
>>> assembler if -mrelax is passed to the compiler driver. This was already
>>> being passed on to the linker, this patch merely makes the assembler
>>> also aware of it.
>>>
>>> The corresponding patch in binutils to handle the -mlink-relax patch is
>>> already committed in the binutils repo. I'm not sure how to manage a
>>> running a newer gcc with an older version of binutils though - how is this
>>> generally handled?
>>
>> The right place is gcc/configure.ac and have a macro defined depending on
>> whether gas supports -mlink-relax.
>>
>>
>> Same should be done for -mrmw, IMO, for similar reasons, e.g. something like
>>
>> case "$target" in
>> ...
>> avr-*-*)
>> ...
>> gcc_GAS_CHECK_FEATURE([-mrmw option], gcc_cv_as_avr_mrmw,,
>> [-mrmw], [.text],,
>> [AC_DEFINE(HAVE_AS_AVR_MRMW_OPTION, 1,
>> [Define if your assembler supports -mrmw option.])])
>>
>> or
>>
>> gcc_GAS_CHECK_FEATURE([-mrmw option], gcc_cv_as_avr_mrmw,,
>> [-mrmw], [.text],,,)
>> if test x$gcc_cv_as_avr_mrmw = xyes; then
>> AC_DEFINE(HAVE_AS_AVR_MRMW_OPTION, 1,
>> [Define if your assembler supports the -mrmw option.])
>>
>
> Thanks Johann. The below patch adds the configury check for -mlink-relax,
> along with the change to ASM_SPEC to propagate the -mrelax flag. I
> modified the original patch a bit to make it easier to handle
> conditional additions to SPECs (inspired by the sparc target).
>
>>
>> However, the gcc-4_9-branch has already been created...
>
> Yes, but I figured it would be useful anyway - if this eventually gets
> backported to 4_9, for example.
>
> If the below patch looks ok, could someone commit please? I don't have
> commit access.
>
> Regards
> Senthil
>
> gcc/ChangeLog
>
> 2014-04-18 Senthil Kumar Selvaraj <senthil_kumar.selvaraj@atmel.com>
>
> * config/avr/avr.h: Pass on mlink-relax to assembler.
> * configure.ac: Test for mlink-relax support in assembler.
> * configure: Regenerate.
>
> diff --git gcc/config/avr/avr.h gcc/config/avr/avr.h
> index 78434ec..b4e3eb1 100644
> --- gcc/config/avr/avr.h
> +++ gcc/config/avr/avr.h
> @@ -512,7 +512,28 @@ extern const char *avr_device_to_sp8 (int argc, const char **argv);
> %{!fenforce-eh-specs:-fno-enforce-eh-specs} \
> %{!fexceptions:-fno-exceptions}"
>
> -#define ASM_SPEC "%:device_to_as(%{mmcu=*:%*}) "
> +#ifdef HAVE_AS_RELAX_OPTION
> +#define ASM_RELAX_SPEC "%{mrelax:-mlink-relax}"
> +#else
> +#define ASM_RELAX_SPEC ""
> +#endif
> +
> +#define ASM_SPEC "%:device_to_as(%{mmcu=*:%*})\
> +%(asm_relax)"
> +
> +/* This macro defines names of additional specifications to put in the specs
> + that can be used in various specifications like CC1_SPEC. Its definition
> + is an initializer with a subgrouping for each command option.
> +
> + Each subgrouping contains a string constant, that defines the
> + specification name, and a string constant that used by the GCC driver
> + program.
> +
> + Do not define this macro if it does not need to do anything. */
> +
> +#define EXTRA_SPECS \
> + { "asm_relax", ASM_RELAX_SPEC }
> +
Hi, wouldn't it be easier to add just a line to driver-avr.c:avr_device_to_as ?
>
> #define LINK_SPEC "\
> %{mrelax:--relax\
> diff --git gcc/configure gcc/configure
> index bfb1525..7815038 100755
> --- gcc/configure
> +++ gcc/configure
> @@ -24142,6 +24142,39 @@ $as_echo "#define HAVE_AS_JSRDIRECT_RELOCS 1" >>confdefs.h
> fi
> ;;
>
> + avr-*-*)
> + { $as_echo "$as_me:${as_lineno-$LINENO}: checking assembler for -mlink-relax option" >&5
> +$as_echo_n "checking assembler for -mlink-relax option... " >&6; }
> +if test "${gcc_cv_as_avr_relax+set}" = set; then :
> + $as_echo_n "(cached) " >&6
> +else
> + gcc_cv_as_avr_relax=no
> + if test x$gcc_cv_as != x; then
> + $as_echo '.text' > conftest.s
> + if { ac_try='$gcc_cv_as $gcc_cv_as_flags -mlink-relax -o conftest.o conftest.s >&5'
> + { { eval echo "\"\$as_me\":${as_lineno-$LINENO}: \"$ac_try\""; } >&5
> + (eval $ac_try) 2>&5
> + ac_status=$?
> + $as_echo "$as_me:${as_lineno-$LINENO}: \$? = $ac_status" >&5
> + test $ac_status = 0; }; }
> + then
> + gcc_cv_as_avr_relax=yes
> + else
> + echo "configure: failed program was" >&5
> + cat conftest.s >&5
> + fi
> + rm -f conftest.o conftest.s
> + fi
> +fi
> +{ $as_echo "$as_me:${as_lineno-$LINENO}: result: $gcc_cv_as_avr_relax" >&5
> +$as_echo "$gcc_cv_as_avr_relax" >&6; }
> +if test $gcc_cv_as_avr_relax = yes; then
> +
> +$as_echo "#define HAVE_AS_RELAX_OPTION 1" >>confdefs.h
> +
> +fi
> + ;;
> +
> cris-*-*)
> { $as_echo "$as_me:${as_lineno-$LINENO}: checking assembler for -no-mul-bug-abort option" >&5
> $as_echo_n "checking assembler for -no-mul-bug-abort option... " >&6; }
> diff --git gcc/configure.ac gcc/configure.ac
> index d7cae6c..cfa862d 100644
> --- gcc/configure.ac
> +++ gcc/configure.ac
> @@ -3579,6 +3579,13 @@ case "$target" in
> [Define if your assembler supports the lituse_jsrdirect relocation.])])
> ;;
>
> + avr-*-*)
> + gcc_GAS_CHECK_FEATURE([-mlink-relax option], gcc_cv_as_avr_relax,,
> + [-mlink-relax], [.text],,
> + [AC_DEFINE(HAVE_AS_RELAX_OPTION, 1,
IMO this is very confusing naming
- The gas option is not "relax" but "link-relax"
- The option is avr specific, thus in order to avoid naming clashes
the variable(s) should be named something like
HAVE_AS_AVR_LINK_RELAX_OPTION
> + [Define if your assembler supports -mlink-relax option.])])
> + ;;
> +
> cris-*-*)
> gcc_GAS_CHECK_FEATURE([-no-mul-bug-abort option],
> gcc_cv_as_cris_no_mul_bug,[2,15,91],
>
Johann
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Patch, avr] Propagate -mrelax gcc driver flag to assembler
2014-05-12 11:18 ` Georg-Johann Lay
@ 2014-05-13 12:49 ` Senthil Kumar Selvaraj
2014-05-14 10:49 ` Georg-Johann Lay
0 siblings, 1 reply; 12+ messages in thread
From: Senthil Kumar Selvaraj @ 2014-05-13 12:49 UTC (permalink / raw)
To: Georg-Johann Lay; +Cc: Denis Chertykov, GCC Patches
On Mon, May 12, 2014 at 01:19:37PM +0200, Georg-Johann Lay wrote:
> Am 04/18/2014 11:52 AM, schrieb Senthil Kumar Selvaraj:
> >
> >On Sat, Apr 12, 2014 at 06:36:01PM +0200, Georg-Johann Lay wrote:
> >>Senthil Kumar Selvaraj schrieb:
> >>>This patch modifies AVR target's ASM spec to pass -mlink-relax to the
> >>>assembler if -mrelax is passed to the compiler driver. This was already
> >>>being passed on to the linker, this patch merely makes the assembler
> >>>also aware of it.
> >>>
> >>>The corresponding patch in binutils to handle the -mlink-relax patch is
> >>>already committed in the binutils repo. I'm not sure how to manage a
> >>>running a newer gcc with an older version of binutils though - how is this
> >>>generally handled?
> >>
> >>The right place is gcc/configure.ac and have a macro defined depending on
> >>whether gas supports -mlink-relax.
> >>
> >>
> >>Same should be done for -mrmw, IMO, for similar reasons, e.g. something like
> >>
> >>case "$target" in
> >> ...
> >> avr-*-*)
> >> ...
> >> gcc_GAS_CHECK_FEATURE([-mrmw option], gcc_cv_as_avr_mrmw,,
> >> [-mrmw], [.text],,
> >> [AC_DEFINE(HAVE_AS_AVR_MRMW_OPTION, 1,
> >> [Define if your assembler supports -mrmw option.])])
> >>
> >>or
> >>
> >> gcc_GAS_CHECK_FEATURE([-mrmw option], gcc_cv_as_avr_mrmw,,
> >> [-mrmw], [.text],,,)
> >> if test x$gcc_cv_as_avr_mrmw = xyes; then
> >> AC_DEFINE(HAVE_AS_AVR_MRMW_OPTION, 1,
> >> [Define if your assembler supports the -mrmw option.])
> >>
> >
> >Thanks Johann. The below patch adds the configury check for -mlink-relax,
> >along with the change to ASM_SPEC to propagate the -mrelax flag. I
> >modified the original patch a bit to make it easier to handle
> >conditional additions to SPECs (inspired by the sparc target).
> >
> >>
> >>However, the gcc-4_9-branch has already been created...
> >
> >Yes, but I figured it would be useful anyway - if this eventually gets
> >backported to 4_9, for example.
> >
> >If the below patch looks ok, could someone commit please? I don't have
> >commit access.
> >
> >Regards
> >Senthil
> >
> >gcc/ChangeLog
> >
> >2014-04-18 Senthil Kumar Selvaraj <senthil_kumar.selvaraj@atmel.com>
> >
> > * config/avr/avr.h: Pass on mlink-relax to assembler.
> > * configure.ac: Test for mlink-relax support in assembler.
> > * configure: Regenerate.
> >
> >diff --git gcc/config/avr/avr.h gcc/config/avr/avr.h
> >index 78434ec..b4e3eb1 100644
> >--- gcc/config/avr/avr.h
> >+++ gcc/config/avr/avr.h
> >@@ -512,7 +512,28 @@ extern const char *avr_device_to_sp8 (int argc, const char **argv);
> > %{!fenforce-eh-specs:-fno-enforce-eh-specs} \
> > %{!fexceptions:-fno-exceptions}"
> >
> >-#define ASM_SPEC "%:device_to_as(%{mmcu=*:%*}) "
> >+#ifdef HAVE_AS_RELAX_OPTION
> >+#define ASM_RELAX_SPEC "%{mrelax:-mlink-relax}"
> >+#else
> >+#define ASM_RELAX_SPEC ""
> >+#endif
> >+
> >+#define ASM_SPEC "%:device_to_as(%{mmcu=*:%*})\
> >+%(asm_relax)"
> >+
> >+/* This macro defines names of additional specifications to put in the specs
> >+ that can be used in various specifications like CC1_SPEC. Its definition
> >+ is an initializer with a subgrouping for each command option.
> >+
> >+ Each subgrouping contains a string constant, that defines the
> >+ specification name, and a string constant that used by the GCC driver
> >+ program.
> >+
> >+ Do not define this macro if it does not need to do anything. */
> >+
> >+#define EXTRA_SPECS \
> >+ { "asm_relax", ASM_RELAX_SPEC }
> >+
>
> Hi, wouldn't it be easier to add just a line to driver-avr.c:avr_device_to_as ?
Well, I couldn't figure out how to do it without passing in the nested spec and
then do argument checking inside avr_device_to_as. Something like
#define ASM_SPEC "%:device_to_as(%{mmcu=*:%*} %{mrelax:-mlink-relax})"
and then handle argc==0, 1 and 2 cases by strcmp'ing against
-mlink-relax if HAVE_AVR_AS_LINK_RELAX_OPTION.
Did I miss something?
>
> >
> > #define LINK_SPEC "\
> > %{mrelax:--relax\
> >diff --git gcc/configure gcc/configure
> >index bfb1525..7815038 100755
> >--- gcc/configure
> >+++ gcc/configure
> >@@ -24142,6 +24142,39 @@ $as_echo "#define HAVE_AS_JSRDIRECT_RELOCS 1" >>confdefs.h
> > fi
> > ;;
> >
> >+ avr-*-*)
> >+ { $as_echo "$as_me:${as_lineno-$LINENO}: checking assembler for -mlink-relax option" >&5
> >+$as_echo_n "checking assembler for -mlink-relax option... " >&6; }
> >+if test "${gcc_cv_as_avr_relax+set}" = set; then :
> >+ $as_echo_n "(cached) " >&6
> >+else
> >+ gcc_cv_as_avr_relax=no
> >+ if test x$gcc_cv_as != x; then
> >+ $as_echo '.text' > conftest.s
> >+ if { ac_try='$gcc_cv_as $gcc_cv_as_flags -mlink-relax -o conftest.o conftest.s >&5'
> >+ { { eval echo "\"\$as_me\":${as_lineno-$LINENO}: \"$ac_try\""; } >&5
> >+ (eval $ac_try) 2>&5
> >+ ac_status=$?
> >+ $as_echo "$as_me:${as_lineno-$LINENO}: \$? = $ac_status" >&5
> >+ test $ac_status = 0; }; }
> >+ then
> >+ gcc_cv_as_avr_relax=yes
> >+ else
> >+ echo "configure: failed program was" >&5
> >+ cat conftest.s >&5
> >+ fi
> >+ rm -f conftest.o conftest.s
> >+ fi
> >+fi
> >+{ $as_echo "$as_me:${as_lineno-$LINENO}: result: $gcc_cv_as_avr_relax" >&5
> >+$as_echo "$gcc_cv_as_avr_relax" >&6; }
> >+if test $gcc_cv_as_avr_relax = yes; then
> >+
> >+$as_echo "#define HAVE_AS_RELAX_OPTION 1" >>confdefs.h
> >+
> >+fi
> >+ ;;
> >+
> > cris-*-*)
> > { $as_echo "$as_me:${as_lineno-$LINENO}: checking assembler for -no-mul-bug-abort option" >&5
> > $as_echo_n "checking assembler for -no-mul-bug-abort option... " >&6; }
> >diff --git gcc/configure.ac gcc/configure.ac
> >index d7cae6c..cfa862d 100644
> >--- gcc/configure.ac
> >+++ gcc/configure.ac
> >@@ -3579,6 +3579,13 @@ case "$target" in
> > [Define if your assembler supports the lituse_jsrdirect relocation.])])
> > ;;
> >
> >+ avr-*-*)
> >+ gcc_GAS_CHECK_FEATURE([-mlink-relax option], gcc_cv_as_avr_relax,,
> >+ [-mlink-relax], [.text],,
> >+ [AC_DEFINE(HAVE_AS_RELAX_OPTION, 1,
>
> IMO this is very confusing naming
>
> - The gas option is not "relax" but "link-relax"
> - The option is avr specific, thus in order to avoid naming clashes
> the variable(s) should be named something like
>
> HAVE_AS_AVR_LINK_RELAX_OPTION
Ok, I'll resend the patch with the renamed define - I was following
whatever the sparc target was doing.
Regards
Senthil
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Patch, avr] Propagate -mrelax gcc driver flag to assembler
2014-05-13 12:49 ` Senthil Kumar Selvaraj
@ 2014-05-14 10:49 ` Georg-Johann Lay
2014-05-14 10:57 ` Rainer Orth
0 siblings, 1 reply; 12+ messages in thread
From: Georg-Johann Lay @ 2014-05-14 10:49 UTC (permalink / raw)
To: Senthil Kumar Selvaraj; +Cc: Denis Chertykov, GCC Patches
Am 05/13/2014 02:48 PM, schrieb Senthil Kumar Selvaraj:
> On Mon, May 12, 2014 at 01:19:37PM +0200, Georg-Johann Lay wrote:
>> Am 04/18/2014 11:52 AM, schrieb Senthil Kumar Selvaraj:
>>>
>>> On Sat, Apr 12, 2014 at 06:36:01PM +0200, Georg-Johann Lay wrote:
>>>> Senthil Kumar Selvaraj schrieb:
[...]
>>> 2014-04-18 Senthil Kumar Selvaraj <senthil_kumar.selvaraj@atmel.com>
>>>
>>> * config/avr/avr.h: Pass on mlink-relax to assembler.
>>> * configure.ac: Test for mlink-relax support in assembler.
>>> * configure: Regenerate.
>>>
>>> diff --git gcc/config/avr/avr.h gcc/config/avr/avr.h
>>> index 78434ec..b4e3eb1 100644
>>> --- gcc/config/avr/avr.h
>>> +++ gcc/config/avr/avr.h
>>> @@ -512,7 +512,28 @@ extern const char *avr_device_to_sp8 (int argc, const char **argv);
>>> %{!fenforce-eh-specs:-fno-enforce-eh-specs} \
>>> %{!fexceptions:-fno-exceptions}"
>>>
>>> -#define ASM_SPEC "%:device_to_as(%{mmcu=*:%*}) "
>>> +#ifdef HAVE_AS_RELAX_OPTION
>>> +#define ASM_RELAX_SPEC "%{mrelax:-mlink-relax}"
>>> +#else
>>> +#define ASM_RELAX_SPEC ""
>>> +#endif
>>> +
>>> +#define ASM_SPEC "%:device_to_as(%{mmcu=*:%*})\
>>> +%(asm_relax)"
>>> +
>>> +/* This macro defines names of additional specifications to put in the specs
>>> + that can be used in various specifications like CC1_SPEC. Its definition
>>> + is an initializer with a subgrouping for each command option.
>>> +
>>> + Each subgrouping contains a string constant, that defines the
>>> + specification name, and a string constant that used by the GCC driver
>>> + program.
>>> +
>>> + Do not define this macro if it does not need to do anything. */
>>> +
>>> +#define EXTRA_SPECS \
>>> + { "asm_relax", ASM_RELAX_SPEC }
>>> +
>>
>> Hi, wouldn't it be easier to add just a line to driver-avr.c:avr_device_to_as ?
>
> Well, I couldn't figure out how to do it without passing in the nested spec and
> then do argument checking inside avr_device_to_as. Something like
>
> #define ASM_SPEC "%:device_to_as(%{mmcu=*:%*} %{mrelax:-mlink-relax})"
>
> and then handle argc==0, 1 and 2 cases by strcmp'ing against
> -mlink-relax if HAVE_AVR_AS_LINK_RELAX_OPTION.
> Did I miss something?
Or what about simply that, which works for me:
Index: config/avr/avr.h
===================================================================
--- config/avr/avr.h (revision 210276)
+++ config/avr/avr.h (working copy)
@@ -512,7 +512,11 @@ extern const char *avr_device_to_sp8 (in
%{!fenforce-eh-specs:-fno-enforce-eh-specs} \
%{!fexceptions:-fno-exceptions}"
+#ifdef HAVE_AS_AVR_LINK_RELAX_OPTION
+#define ASM_SPEC "%:device_to_as(%{mmcu=*:%*}) %{mrelax:-mlink-relax} "
+#else
#define ASM_SPEC "%:device_to_as(%{mmcu=*:%*}) "
+#endif
#define LINK_SPEC "\
%{mrelax:--relax\
Johann
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Patch, avr] Propagate -mrelax gcc driver flag to assembler
2014-05-14 10:49 ` Georg-Johann Lay
@ 2014-05-14 10:57 ` Rainer Orth
2014-05-15 7:57 ` Senthil Kumar Selvaraj
0 siblings, 1 reply; 12+ messages in thread
From: Rainer Orth @ 2014-05-14 10:57 UTC (permalink / raw)
To: Georg-Johann Lay; +Cc: Senthil Kumar Selvaraj, Denis Chertykov, GCC Patches
Georg-Johann Lay <avr@gjlay.de> writes:
> Or what about simply that, which works for me:
>
>
> Index: config/avr/avr.h
> ===================================================================
> --- config/avr/avr.h (revision 210276)
> +++ config/avr/avr.h (working copy)
> @@ -512,7 +512,11 @@ extern const char *avr_device_to_sp8 (in
> %{!fenforce-eh-specs:-fno-enforce-eh-specs} \
> %{!fexceptions:-fno-exceptions}"
>
> +#ifdef HAVE_AS_AVR_LINK_RELAX_OPTION
> +#define ASM_SPEC "%:device_to_as(%{mmcu=*:%*}) %{mrelax:-mlink-relax} "
> +#else
> #define ASM_SPEC "%:device_to_as(%{mmcu=*:%*}) "
> +#endif
>
> #define LINK_SPEC "\
> %{mrelax:--relax\
Better yet something like
#ifdef HAVE_AS_AVR_LINK_RELAX_OPTION
#define LINK_RELAX_SPEC "%{mrelax:-mlink-relax} "
#else
#define LINK_RELAX_SPEC ""
#endif
#define ASM_SPEC "%:device_to_as(%{mmcu=*:%*}) " LINK_RELAX_SPEC
to avoid unnecessary duplication.
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Patch, avr] Propagate -mrelax gcc driver flag to assembler
2014-05-14 10:57 ` Rainer Orth
@ 2014-05-15 7:57 ` Senthil Kumar Selvaraj
2014-05-16 10:00 ` Georg-Johann Lay
0 siblings, 1 reply; 12+ messages in thread
From: Senthil Kumar Selvaraj @ 2014-05-15 7:57 UTC (permalink / raw)
To: Rainer Orth; +Cc: Georg-Johann Lay, Denis Chertykov, GCC Patches
On Wed, May 14, 2014 at 12:56:54PM +0200, Rainer Orth wrote:
> Georg-Johann Lay <avr@gjlay.de> writes:
>
> > Or what about simply that, which works for me:
> >
> >
> > Index: config/avr/avr.h
> > ===================================================================
> > --- config/avr/avr.h (revision 210276)
> > +++ config/avr/avr.h (working copy)
> > @@ -512,7 +512,11 @@ extern const char *avr_device_to_sp8 (in
> > %{!fenforce-eh-specs:-fno-enforce-eh-specs} \
> > %{!fexceptions:-fno-exceptions}"
> >
> > +#ifdef HAVE_AS_AVR_LINK_RELAX_OPTION
> > +#define ASM_SPEC "%:device_to_as(%{mmcu=*:%*}) %{mrelax:-mlink-relax} "
> > +#else
> > #define ASM_SPEC "%:device_to_as(%{mmcu=*:%*}) "
> > +#endif
> >
> > #define LINK_SPEC "\
> > %{mrelax:--relax\
>
> Better yet something like
>
> #ifdef HAVE_AS_AVR_LINK_RELAX_OPTION
> #define LINK_RELAX_SPEC "%{mrelax:-mlink-relax} "
> #else
> #define LINK_RELAX_SPEC ""
> #endif
>
> #define ASM_SPEC "%:device_to_as(%{mmcu=*:%*}) " LINK_RELAX_SPEC
>
Does this look ok? I don't have commit access, so could someone commit
this please?
Regards
Senthil
2014-05-15 Senthil Kumar Selvaraj <senthil_kumar.selvaraj@atmel.com>
* config/avr/avr.h: Pass on mlink-relax to assembler.
* configure.ac: Test for mlink-relax assembler support.
* config.in: Regenerate.
* configure: Likewise.
diff --git gcc/config.in gcc/config.in
index c0ba36e..1738301 100644
--- gcc/config.in
+++ gcc/config.in
@@ -575,6 +575,12 @@
#endif
+/* Define if your assembler supports -mlink-relax option. */
+#ifndef USED_FOR_TARGET
+#undef HAVE_AVR_AS_LINK_RELAX_OPTION
+#endif
+
+
/* Define to 1 if you have the `clearerr_unlocked' function. */
#ifndef USED_FOR_TARGET
#undef HAVE_CLEARERR_UNLOCKED
diff --git gcc/config/avr/avr.h gcc/config/avr/avr.h
index 9d34983..c59c54d 100644
--- gcc/config/avr/avr.h
+++ gcc/config/avr/avr.h
@@ -512,8 +512,14 @@ extern const char *avr_device_to_sp8 (int argc, const char **argv);
%{!fenforce-eh-specs:-fno-enforce-eh-specs} \
%{!fexceptions:-fno-exceptions}"
-#define ASM_SPEC "%:device_to_as(%{mmcu=*:%*}) "
-
+#ifdef HAVE_AVR_AS_LINK_RELAX_OPTION
+#define ASM_RELAX_SPEC "%{mrelax:-mlink-relax}"
+#else
+#define ASM_RELAX_SPEC ""
+#endif
+
+#define ASM_SPEC "%:device_to_as(%{mmcu=*:%*}) " ASM_RELAX_SPEC
+
#define LINK_SPEC "\
%{mrelax:--relax\
%{mpmem-wrap-around:%{mmcu=at90usb8*:--pmem-wrap-around=8k}\
diff --git gcc/configure gcc/configure
index f4db0a0..2812cdb 100755
--- gcc/configure
+++ gcc/configure
@@ -24014,6 +24014,39 @@ $as_echo "#define HAVE_AS_JSRDIRECT_RELOCS 1" >>confdefs.h
fi
;;
+ avr-*-*)
+ { $as_echo "$as_me:${as_lineno-$LINENO}: checking assembler for -mlink-relax option" >&5
+$as_echo_n "checking assembler for -mlink-relax option... " >&6; }
+if test "${gcc_cv_as_avr_relax+set}" = set; then :
+ $as_echo_n "(cached) " >&6
+else
+ gcc_cv_as_avr_relax=no
+ if test x$gcc_cv_as != x; then
+ $as_echo '.text' > conftest.s
+ if { ac_try='$gcc_cv_as $gcc_cv_as_flags -mlink-relax -o conftest.o conftest.s >&5'
+ { { eval echo "\"\$as_me\":${as_lineno-$LINENO}: \"$ac_try\""; } >&5
+ (eval $ac_try) 2>&5
+ ac_status=$?
+ $as_echo "$as_me:${as_lineno-$LINENO}: \$? = $ac_status" >&5
+ test $ac_status = 0; }; }
+ then
+ gcc_cv_as_avr_relax=yes
+ else
+ echo "configure: failed program was" >&5
+ cat conftest.s >&5
+ fi
+ rm -f conftest.o conftest.s
+ fi
+fi
+{ $as_echo "$as_me:${as_lineno-$LINENO}: result: $gcc_cv_as_avr_relax" >&5
+$as_echo "$gcc_cv_as_avr_relax" >&6; }
+if test $gcc_cv_as_avr_relax = yes; then
+
+$as_echo "#define HAVE_AVR_AS_LINK_RELAX_OPTION 1" >>confdefs.h
+
+fi
+ ;;
+
cris-*-*)
{ $as_echo "$as_me:${as_lineno-$LINENO}: checking assembler for -no-mul-bug-abort option" >&5
$as_echo_n "checking assembler for -no-mul-bug-abort option... " >&6; }
diff --git gcc/configure.ac gcc/configure.ac
index 8f17dfb..49a1f3d 100644
--- gcc/configure.ac
+++ gcc/configure.ac
@@ -3510,6 +3510,13 @@ case "$target" in
[Define if your assembler supports the lituse_jsrdirect relocation.])])
;;
+ avr-*-*)
+ gcc_GAS_CHECK_FEATURE([-mlink-relax option], gcc_cv_as_avr_relax,,
+ [-mlink-relax], [.text],,
+ [AC_DEFINE(HAVE_AVR_AS_LINK_RELAX_OPTION, 1,
+ [Define if your assembler supports -mlink-relax option.])])
+ ;;
+
cris-*-*)
gcc_GAS_CHECK_FEATURE([-no-mul-bug-abort option],
gcc_cv_as_cris_no_mul_bug,[2,15,91],
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Patch, avr] Propagate -mrelax gcc driver flag to assembler
2014-05-15 7:57 ` Senthil Kumar Selvaraj
@ 2014-05-16 10:00 ` Georg-Johann Lay
2014-05-19 4:37 ` Denis Chertykov
2014-05-19 4:56 ` Senthil Kumar Selvaraj
0 siblings, 2 replies; 12+ messages in thread
From: Georg-Johann Lay @ 2014-05-16 10:00 UTC (permalink / raw)
To: Senthil Kumar Selvaraj; +Cc: Rainer Orth, Denis Chertykov, GCC Patches
Am 05/15/2014 09:55 AM, schrieb Senthil Kumar Selvaraj:
> On Wed, May 14, 2014 at 12:56:54PM +0200, Rainer Orth wrote:
>> Georg-Johann Lay <avr@gjlay.de> writes:
>>
>>> Or what about simply that, which works for me:
>>>
>>>
>>> Index: config/avr/avr.h
>>> ===================================================================
>>> --- config/avr/avr.h (revision 210276)
>>> +++ config/avr/avr.h (working copy)
>>> @@ -512,7 +512,11 @@ extern const char *avr_device_to_sp8 (in
>>> %{!fenforce-eh-specs:-fno-enforce-eh-specs} \
>>> %{!fexceptions:-fno-exceptions}"
>>>
>>> +#ifdef HAVE_AS_AVR_LINK_RELAX_OPTION
>>> +#define ASM_SPEC "%:device_to_as(%{mmcu=*:%*}) %{mrelax:-mlink-relax} "
>>> +#else
>>> #define ASM_SPEC "%:device_to_as(%{mmcu=*:%*}) "
>>> +#endif
>>>
>>> #define LINK_SPEC "\
>>> %{mrelax:--relax\
>>
>> Better yet something like
>>
>> #ifdef HAVE_AS_AVR_LINK_RELAX_OPTION
>> #define LINK_RELAX_SPEC "%{mrelax:-mlink-relax} "
>> #else
>> #define LINK_RELAX_SPEC ""
>> #endif
>>
>> #define ASM_SPEC "%:device_to_as(%{mmcu=*:%*}) " LINK_RELAX_SPEC
>>
>
> Does this look ok? I don't have commit access, so could someone commit
> this please?
Hi, looks fine to me. Thanks
Usually, changelogs are more descriptive w.r.t. to what objects are touched like:
* config/avr/avr.h (LINK_RELAX_SPEC): Pass -mlink-relax to the
assembler, depending on HAVE_AS_AVR_LINK_RELAX_OPTION.
(ASM_SPEC): Use it.
* configure.ac (HAVE_AVR_AS_LINK_RELAX_OPTION) [avr]: New define if
assembler supports -mlink-relax.
* config.in: Regenerate.
* configure: Likewise.
>
> Regards
> Senthil
>
> 2014-05-15 Senthil Kumar Selvaraj <senthil_kumar.selvaraj@atmel.com>
>
> * config/avr/avr.h: Pass on mlink-relax to assembler.
> * configure.ac: Test for mlink-relax assembler support.
> * config.in: Regenerate.
> * configure: Likewise.
>
> diff --git gcc/config.in gcc/config.in
> index c0ba36e..1738301 100644
> --- gcc/config.in
> +++ gcc/config.in
> @@ -575,6 +575,12 @@
> #endif
>
>
> +/* Define if your assembler supports -mlink-relax option. */
> +#ifndef USED_FOR_TARGET
> +#undef HAVE_AVR_AS_LINK_RELAX_OPTION
> +#endif
> +
> +
> /* Define to 1 if you have the `clearerr_unlocked' function. */
> #ifndef USED_FOR_TARGET
> #undef HAVE_CLEARERR_UNLOCKED
> diff --git gcc/config/avr/avr.h gcc/config/avr/avr.h
> index 9d34983..c59c54d 100644
> --- gcc/config/avr/avr.h
> +++ gcc/config/avr/avr.h
> @@ -512,8 +512,14 @@ extern const char *avr_device_to_sp8 (int argc, const char **argv);
> %{!fenforce-eh-specs:-fno-enforce-eh-specs} \
> %{!fexceptions:-fno-exceptions}"
>
> -#define ASM_SPEC "%:device_to_as(%{mmcu=*:%*}) "
> -
> +#ifdef HAVE_AVR_AS_LINK_RELAX_OPTION
> +#define ASM_RELAX_SPEC "%{mrelax:-mlink-relax}"
> +#else
> +#define ASM_RELAX_SPEC ""
> +#endif
> +
> +#define ASM_SPEC "%:device_to_as(%{mmcu=*:%*}) " ASM_RELAX_SPEC
> +
> #define LINK_SPEC "\
> %{mrelax:--relax\
> %{mpmem-wrap-around:%{mmcu=at90usb8*:--pmem-wrap-around=8k}\
> diff --git gcc/configure gcc/configure
> index f4db0a0..2812cdb 100755
> --- gcc/configure
> +++ gcc/configure
> @@ -24014,6 +24014,39 @@ $as_echo "#define HAVE_AS_JSRDIRECT_RELOCS 1" >>confdefs.h
> fi
> ;;
>
> + avr-*-*)
> + { $as_echo "$as_me:${as_lineno-$LINENO}: checking assembler for -mlink-relax option" >&5
> +$as_echo_n "checking assembler for -mlink-relax option... " >&6; }
> +if test "${gcc_cv_as_avr_relax+set}" = set; then :
> + $as_echo_n "(cached) " >&6
> +else
> + gcc_cv_as_avr_relax=no
> + if test x$gcc_cv_as != x; then
> + $as_echo '.text' > conftest.s
> + if { ac_try='$gcc_cv_as $gcc_cv_as_flags -mlink-relax -o conftest.o conftest.s >&5'
> + { { eval echo "\"\$as_me\":${as_lineno-$LINENO}: \"$ac_try\""; } >&5
> + (eval $ac_try) 2>&5
> + ac_status=$?
> + $as_echo "$as_me:${as_lineno-$LINENO}: \$? = $ac_status" >&5
> + test $ac_status = 0; }; }
> + then
> + gcc_cv_as_avr_relax=yes
> + else
> + echo "configure: failed program was" >&5
> + cat conftest.s >&5
> + fi
> + rm -f conftest.o conftest.s
> + fi
> +fi
> +{ $as_echo "$as_me:${as_lineno-$LINENO}: result: $gcc_cv_as_avr_relax" >&5
> +$as_echo "$gcc_cv_as_avr_relax" >&6; }
> +if test $gcc_cv_as_avr_relax = yes; then
> +
> +$as_echo "#define HAVE_AVR_AS_LINK_RELAX_OPTION 1" >>confdefs.h
> +
> +fi
> + ;;
> +
> cris-*-*)
> { $as_echo "$as_me:${as_lineno-$LINENO}: checking assembler for -no-mul-bug-abort option" >&5
> $as_echo_n "checking assembler for -no-mul-bug-abort option... " >&6; }
> diff --git gcc/configure.ac gcc/configure.ac
> index 8f17dfb..49a1f3d 100644
> --- gcc/configure.ac
> +++ gcc/configure.ac
> @@ -3510,6 +3510,13 @@ case "$target" in
> [Define if your assembler supports the lituse_jsrdirect relocation.])])
> ;;
>
> + avr-*-*)
> + gcc_GAS_CHECK_FEATURE([-mlink-relax option], gcc_cv_as_avr_relax,,
> + [-mlink-relax], [.text],,
> + [AC_DEFINE(HAVE_AVR_AS_LINK_RELAX_OPTION, 1,
> + [Define if your assembler supports -mlink-relax option.])])
> + ;;
> +
> cris-*-*)
> gcc_GAS_CHECK_FEATURE([-no-mul-bug-abort option],
> gcc_cv_as_cris_no_mul_bug,[2,15,91],
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Patch, avr] Propagate -mrelax gcc driver flag to assembler
2014-05-16 10:00 ` Georg-Johann Lay
@ 2014-05-19 4:37 ` Denis Chertykov
2014-05-19 4:56 ` Senthil Kumar Selvaraj
1 sibling, 0 replies; 12+ messages in thread
From: Denis Chertykov @ 2014-05-19 4:37 UTC (permalink / raw)
To: Georg-Johann Lay; +Cc: Senthil Kumar Selvaraj, Rainer Orth, GCC Patches
2014-05-16 14:02 GMT+04:00 Georg-Johann Lay <avr@gjlay.de>:
> Am 05/15/2014 09:55 AM, schrieb Senthil Kumar Selvaraj:
>
>> On Wed, May 14, 2014 at 12:56:54PM +0200, Rainer Orth wrote:
>>>
>>> Georg-Johann Lay <avr@gjlay.de> writes:
>>>
>>>> Or what about simply that, which works for me:
>>>>
>>>>
>>>> Index: config/avr/avr.h
>>>> ===================================================================
>>>> --- config/avr/avr.h (revision 210276)
>>>> +++ config/avr/avr.h (working copy)
>>>> @@ -512,7 +512,11 @@ extern const char *avr_device_to_sp8 (in
>>>> %{!fenforce-eh-specs:-fno-enforce-eh-specs} \
>>>> %{!fexceptions:-fno-exceptions}"
>>>>
>>>> +#ifdef HAVE_AS_AVR_LINK_RELAX_OPTION
>>>> +#define ASM_SPEC "%:device_to_as(%{mmcu=*:%*}) %{mrelax:-mlink-relax} "
>>>> +#else
>>>> #define ASM_SPEC "%:device_to_as(%{mmcu=*:%*}) "
>>>> +#endif
>>>>
>>>> #define LINK_SPEC "\
>>>> %{mrelax:--relax\
>>>
>>>
>>> Better yet something like
>>>
>>> #ifdef HAVE_AS_AVR_LINK_RELAX_OPTION
>>> #define LINK_RELAX_SPEC "%{mrelax:-mlink-relax} "
>>> #else
>>> #define LINK_RELAX_SPEC ""
>>> #endif
>>>
>>> #define ASM_SPEC "%:device_to_as(%{mmcu=*:%*}) " LINK_RELAX_SPEC
>>>
>>
>> Does this look ok? I don't have commit access, so could someone commit
>> this please?
>
>
> Hi, looks fine to me. Thanks
I'm on vacation until the 24-may.
Denis.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Patch, avr] Propagate -mrelax gcc driver flag to assembler
2014-05-16 10:00 ` Georg-Johann Lay
2014-05-19 4:37 ` Denis Chertykov
@ 2014-05-19 4:56 ` Senthil Kumar Selvaraj
1 sibling, 0 replies; 12+ messages in thread
From: Senthil Kumar Selvaraj @ 2014-05-19 4:56 UTC (permalink / raw)
To: Georg-Johann Lay; +Cc: Rainer Orth, Denis Chertykov, GCC Patches
On Fri, May 16, 2014 at 12:02:12PM +0200, Georg-Johann Lay wrote:
> Am 05/15/2014 09:55 AM, schrieb Senthil Kumar Selvaraj:
> >On Wed, May 14, 2014 at 12:56:54PM +0200, Rainer Orth wrote:
> >>Georg-Johann Lay <avr@gjlay.de> writes:
> >>
> >>>Or what about simply that, which works for me:
> >>>
> >>>
> >>>Index: config/avr/avr.h
> >>>===================================================================
> >>>--- config/avr/avr.h (revision 210276)
> >>>+++ config/avr/avr.h (working copy)
> >>>@@ -512,7 +512,11 @@ extern const char *avr_device_to_sp8 (in
> >>> %{!fenforce-eh-specs:-fno-enforce-eh-specs} \
> >>> %{!fexceptions:-fno-exceptions}"
> >>>
> >>>+#ifdef HAVE_AS_AVR_LINK_RELAX_OPTION
> >>>+#define ASM_SPEC "%:device_to_as(%{mmcu=*:%*}) %{mrelax:-mlink-relax} "
> >>>+#else
> >>> #define ASM_SPEC "%:device_to_as(%{mmcu=*:%*}) "
> >>>+#endif
> >>>
> >>> #define LINK_SPEC "\
> >>> %{mrelax:--relax\
> >>
> >>Better yet something like
> >>
> >>#ifdef HAVE_AS_AVR_LINK_RELAX_OPTION
> >>#define LINK_RELAX_SPEC "%{mrelax:-mlink-relax} "
> >>#else
> >>#define LINK_RELAX_SPEC ""
> >>#endif
> >>
> >>#define ASM_SPEC "%:device_to_as(%{mmcu=*:%*}) " LINK_RELAX_SPEC
> >>
> >
> >Does this look ok? I don't have commit access, so could someone commit
> >this please?
>
> Hi, looks fine to me. Thanks
>
> Usually, changelogs are more descriptive w.r.t. to what objects are touched like:
Ah ok. Will keep that in mind, thanks.
Regards
Senthil
>
> * config/avr/avr.h (LINK_RELAX_SPEC): Pass -mlink-relax to the
> assembler, depending on HAVE_AS_AVR_LINK_RELAX_OPTION.
> (ASM_SPEC): Use it.
> * configure.ac (HAVE_AVR_AS_LINK_RELAX_OPTION) [avr]: New define if
> assembler supports -mlink-relax.
> * config.in: Regenerate.
> * configure: Likewise.
>
> >
> >Regards
> >Senthil
> >
> >2014-05-15 Senthil Kumar Selvaraj <senthil_kumar.selvaraj@atmel.com>
> >
> > * config/avr/avr.h: Pass on mlink-relax to assembler.
> > * configure.ac: Test for mlink-relax assembler support.
> > * config.in: Regenerate.
> > * configure: Likewise.
> >
> >diff --git gcc/config.in gcc/config.in
> >index c0ba36e..1738301 100644
> >--- gcc/config.in
> >+++ gcc/config.in
> >@@ -575,6 +575,12 @@
> > #endif
> >
> >
> >+/* Define if your assembler supports -mlink-relax option. */
> >+#ifndef USED_FOR_TARGET
> >+#undef HAVE_AVR_AS_LINK_RELAX_OPTION
> >+#endif
> >+
> >+
> > /* Define to 1 if you have the `clearerr_unlocked' function. */
> > #ifndef USED_FOR_TARGET
> > #undef HAVE_CLEARERR_UNLOCKED
> >diff --git gcc/config/avr/avr.h gcc/config/avr/avr.h
> >index 9d34983..c59c54d 100644
> >--- gcc/config/avr/avr.h
> >+++ gcc/config/avr/avr.h
> >@@ -512,8 +512,14 @@ extern const char *avr_device_to_sp8 (int argc, const char **argv);
> > %{!fenforce-eh-specs:-fno-enforce-eh-specs} \
> > %{!fexceptions:-fno-exceptions}"
> >
> >-#define ASM_SPEC "%:device_to_as(%{mmcu=*:%*}) "
> >-
> >+#ifdef HAVE_AVR_AS_LINK_RELAX_OPTION
> >+#define ASM_RELAX_SPEC "%{mrelax:-mlink-relax}"
> >+#else
> >+#define ASM_RELAX_SPEC ""
> >+#endif
> >+
> >+#define ASM_SPEC "%:device_to_as(%{mmcu=*:%*}) " ASM_RELAX_SPEC
> >+
> > #define LINK_SPEC "\
> > %{mrelax:--relax\
> > %{mpmem-wrap-around:%{mmcu=at90usb8*:--pmem-wrap-around=8k}\
> >diff --git gcc/configure gcc/configure
> >index f4db0a0..2812cdb 100755
> >--- gcc/configure
> >+++ gcc/configure
> >@@ -24014,6 +24014,39 @@ $as_echo "#define HAVE_AS_JSRDIRECT_RELOCS 1" >>confdefs.h
> > fi
> > ;;
> >
> >+ avr-*-*)
> >+ { $as_echo "$as_me:${as_lineno-$LINENO}: checking assembler for -mlink-relax option" >&5
> >+$as_echo_n "checking assembler for -mlink-relax option... " >&6; }
> >+if test "${gcc_cv_as_avr_relax+set}" = set; then :
> >+ $as_echo_n "(cached) " >&6
> >+else
> >+ gcc_cv_as_avr_relax=no
> >+ if test x$gcc_cv_as != x; then
> >+ $as_echo '.text' > conftest.s
> >+ if { ac_try='$gcc_cv_as $gcc_cv_as_flags -mlink-relax -o conftest.o conftest.s >&5'
> >+ { { eval echo "\"\$as_me\":${as_lineno-$LINENO}: \"$ac_try\""; } >&5
> >+ (eval $ac_try) 2>&5
> >+ ac_status=$?
> >+ $as_echo "$as_me:${as_lineno-$LINENO}: \$? = $ac_status" >&5
> >+ test $ac_status = 0; }; }
> >+ then
> >+ gcc_cv_as_avr_relax=yes
> >+ else
> >+ echo "configure: failed program was" >&5
> >+ cat conftest.s >&5
> >+ fi
> >+ rm -f conftest.o conftest.s
> >+ fi
> >+fi
> >+{ $as_echo "$as_me:${as_lineno-$LINENO}: result: $gcc_cv_as_avr_relax" >&5
> >+$as_echo "$gcc_cv_as_avr_relax" >&6; }
> >+if test $gcc_cv_as_avr_relax = yes; then
> >+
> >+$as_echo "#define HAVE_AVR_AS_LINK_RELAX_OPTION 1" >>confdefs.h
> >+
> >+fi
> >+ ;;
> >+
> > cris-*-*)
> > { $as_echo "$as_me:${as_lineno-$LINENO}: checking assembler for -no-mul-bug-abort option" >&5
> > $as_echo_n "checking assembler for -no-mul-bug-abort option... " >&6; }
> >diff --git gcc/configure.ac gcc/configure.ac
> >index 8f17dfb..49a1f3d 100644
> >--- gcc/configure.ac
> >+++ gcc/configure.ac
> >@@ -3510,6 +3510,13 @@ case "$target" in
> > [Define if your assembler supports the lituse_jsrdirect relocation.])])
> > ;;
> >
> >+ avr-*-*)
> >+ gcc_GAS_CHECK_FEATURE([-mlink-relax option], gcc_cv_as_avr_relax,,
> >+ [-mlink-relax], [.text],,
> >+ [AC_DEFINE(HAVE_AVR_AS_LINK_RELAX_OPTION, 1,
> >+ [Define if your assembler supports -mlink-relax option.])])
> >+ ;;
> >+
> > cris-*-*)
> > gcc_GAS_CHECK_FEATURE([-no-mul-bug-abort option],
> > gcc_cv_as_cris_no_mul_bug,[2,15,91],
> >
>
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2014-05-19 4:56 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-04-11 17:57 [Patch, avr] Propagate -mrelax gcc driver flag to assembler Senthil Kumar Selvaraj
2014-04-12 16:36 ` Georg-Johann Lay
2014-04-18 10:05 ` Senthil Kumar Selvaraj
2014-05-12 10:21 ` Senthil Kumar Selvaraj
2014-05-12 11:18 ` Georg-Johann Lay
2014-05-13 12:49 ` Senthil Kumar Selvaraj
2014-05-14 10:49 ` Georg-Johann Lay
2014-05-14 10:57 ` Rainer Orth
2014-05-15 7:57 ` Senthil Kumar Selvaraj
2014-05-16 10:00 ` Georg-Johann Lay
2014-05-19 4:37 ` Denis Chertykov
2014-05-19 4:56 ` Senthil Kumar Selvaraj
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).