From: Gary Benson <gbenson@redhat.com>
To: Andrew Burgess <aburgess@broadcom.com>
Cc: Ian Lance Taylor <iant@google.com>,
gcc-patches <gcc-patches@gcc.gnu.org>,
Jason Merrill <jason@redhat.com>,
gdb-patches@sourceware.org
Subject: Re: [PATCH] cplus-demangler, free resource after a failed call to gnu_special.
Date: Wed, 14 May 2014 14:20:00 -0000 [thread overview]
Message-ID: <20140514142016.GA32660@blade.nx> (raw)
In-Reply-To: <537337AF.3020806@broadcom.com>
Andrew Burgess wrote:
> On 14/05/2014 10:01 AM, Gary Benson wrote:
> > Ian Lance Taylor wrote:
> > > Andrew Burgess <aburgess@broadcom.com> wrote:
> > > > On 09/05/2014 9:53 PM, Ian Lance Taylor wrote:
> > > > > Andrew Burgess <aburgess@broadcom.com> wrote:
> > > > > > if ((AUTO_DEMANGLING || GNU_DEMANGLING))
> > > > > > {
> > > > > > success = gnu_special (work, &mangled, &decl);
> > > > > > + if (!success)
> > > > > > + {
> > > > > > + delete_work_stuff (work);
> > > > > > + string_delete (&decl);
> > > > > > + }
> > > > >
> > >
> > > This patch is OK.
> >
> > Andrew, would you like me to commit this?
>
> Yes please.
Done:
https://gcc.gnu.org/viewcvs/gcc?view=revision&revision=210425
Thanks,
Gary
--
http://gbenson.net/
next prev parent reply other threads:[~2014-05-14 14:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-09 14:35 Andrew Burgess
2014-05-09 20:53 ` Ian Lance Taylor
2014-05-10 19:14 ` Andrew Burgess
2014-05-12 5:40 ` Ian Lance Taylor
2014-05-14 9:01 ` Gary Benson
2014-05-14 9:30 ` Andrew Burgess
2014-05-14 14:20 ` Gary Benson [this message]
2014-05-22 11:58 ` Thomas Schwinge
2014-05-22 16:02 ` Gary Benson
2014-05-22 16:13 ` Thomas Schwinge
2014-05-22 19:34 ` Gary Benson
2014-05-28 22:17 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140514142016.GA32660@blade.nx \
--to=gbenson@redhat.com \
--cc=aburgess@broadcom.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=iant@google.com \
--cc=jason@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).