From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31323 invoked by alias); 14 May 2014 14:20:41 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 31311 invoked by uid 89); 14 May 2014 14:20:40 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 14 May 2014 14:20:37 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s4EEKYTp030242 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 14 May 2014 10:20:34 -0400 Received: from blade.nx (ovpn-116-68.ams2.redhat.com [10.36.116.68]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id s4EEKG5X026795; Wed, 14 May 2014 10:20:17 -0400 Received: by blade.nx (Postfix, from userid 1000) id 5188A26234A; Wed, 14 May 2014 15:20:16 +0100 (BST) Date: Wed, 14 May 2014 14:20:00 -0000 From: Gary Benson To: Andrew Burgess Cc: Ian Lance Taylor , gcc-patches , Jason Merrill , gdb-patches@sourceware.org Subject: Re: [PATCH] cplus-demangler, free resource after a failed call to gnu_special. Message-ID: <20140514142016.GA32660@blade.nx> References: <1399646123-9960-1-git-send-email-aburgess@broadcom.com> <536E7A72.1040203@broadcom.com> <20140514090125.GA4974@blade.nx> <537337AF.3020806@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <537337AF.3020806@broadcom.com> X-IsSubscribed: yes X-SW-Source: 2014-05/txt/msg01090.txt.bz2 Andrew Burgess wrote: > On 14/05/2014 10:01 AM, Gary Benson wrote: > > Ian Lance Taylor wrote: > > > Andrew Burgess wrote: > > > > On 09/05/2014 9:53 PM, Ian Lance Taylor wrote: > > > > > Andrew Burgess wrote: > > > > > > if ((AUTO_DEMANGLING || GNU_DEMANGLING)) > > > > > > { > > > > > > success = gnu_special (work, &mangled, &decl); > > > > > > + if (!success) > > > > > > + { > > > > > > + delete_work_stuff (work); > > > > > > + string_delete (&decl); > > > > > > + } > > > > > > > > > > > This patch is OK. > > > > Andrew, would you like me to commit this? > > Yes please. Done: https://gcc.gnu.org/viewcvs/gcc?view=revision&revision=210425 Thanks, Gary -- http://gbenson.net/