public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Gary Benson <gbenson@redhat.com>
To: Thomas Schwinge <thomas@codesourcery.com>
Cc: Andrew Burgess <aburgess@broadcom.com>,
	Ian Lance Taylor <iant@google.com>,
	       gcc-patches <gcc-patches@gcc.gnu.org>,
	       Jason Merrill <jason@redhat.com>,
	gdb-patches@sourceware.org
Subject: Re: [PATCH] cplus-demangler, free resource after a failed call to gnu_special.
Date: Thu, 22 May 2014 16:02:00 -0000	[thread overview]
Message-ID: <20140522160208.GC25201@blade.nx> (raw)
In-Reply-To: <87a9aavxdr.fsf@kepler.schwinge.homeip.net>

Hi Thomas,

Thomas Schwinge wrote:
> In GCC, I'm consistenly seeing the following new failure:
> 
>     ./test-demangle < ../../../source/libiberty/testsuite/demangle-expected
>     FAIL at line 4350, options --format=auto --no-params:
>     in:  _QueueNotification_QueueController__$4PPPPPPPM_A_INotice___Z
>     out: (null)
>     exp: 
>     ./test-demangle: 895 tests, 1 failures
>     make[2]: *** [check-cplus-dem] Error 1
> 
> The patch was committed incompletely; I added the missing last line in
> r210803:
[snip]
> @@ -4347,3 +4347,4 @@ void post<std::function<void ()> >(std::function<void ()>&&)::{lambda()#1}*& std
>  --format=auto --no-params
>  _QueueNotification_QueueController__$4PPPPPPPM_A_INotice___Z
>  _QueueNotification_QueueController__$4PPPPPPPM_A_INotice___Z
> +_QueueNotification_QueueController__$4PPPPPPPM_A_INotice___Z

I thought that extra line was a mistake; I thought each test was
precisely three lines:

  # options
  # input to be demangled
  # expected output

What is the extra line here?

Thanks,
Gary

-- 
http://gbenson.net/

  reply	other threads:[~2014-05-22 16:02 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-09 14:35 Andrew Burgess
2014-05-09 20:53 ` Ian Lance Taylor
2014-05-10 19:14   ` Andrew Burgess
2014-05-12  5:40     ` Ian Lance Taylor
2014-05-14  9:01       ` Gary Benson
2014-05-14  9:30         ` Andrew Burgess
2014-05-14 14:20           ` Gary Benson
2014-05-22 11:58             ` Thomas Schwinge
2014-05-22 16:02               ` Gary Benson [this message]
2014-05-22 16:13                 ` Thomas Schwinge
2014-05-22 19:34                   ` Gary Benson
2014-05-28 22:17               ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140522160208.GC25201@blade.nx \
    --to=gbenson@redhat.com \
    --cc=aburgess@broadcom.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=iant@google.com \
    --cc=jason@redhat.com \
    --cc=thomas@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).