From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27852 invoked by alias); 22 May 2014 19:34:32 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 27841 invoked by uid 89); 22 May 2014 19:34:31 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 22 May 2014 19:34:30 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s4MJYQGj016760 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 22 May 2014 15:34:26 -0400 Received: from blade.nx (ovpn-116-100.ams2.redhat.com [10.36.116.100]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s4MJYOsF016592; Thu, 22 May 2014 15:34:25 -0400 Received: by blade.nx (Postfix, from userid 1000) id 90F30262416; Thu, 22 May 2014 20:34:23 +0100 (BST) Date: Thu, 22 May 2014 19:34:00 -0000 From: Gary Benson To: Thomas Schwinge Cc: Andrew Burgess , Ian Lance Taylor , gcc-patches , Jason Merrill , gdb-patches@sourceware.org Subject: Re: [PATCH] cplus-demangler, free resource after a failed call to gnu_special. Message-ID: <20140522193423.GA28232@blade.nx> References: <1399646123-9960-1-git-send-email-aburgess@broadcom.com> <536E7A72.1040203@broadcom.com> <20140514090125.GA4974@blade.nx> <537337AF.3020806@broadcom.com> <20140514142016.GA32660@blade.nx> <87a9aavxdr.fsf@kepler.schwinge.homeip.net> <20140522160208.GC25201@blade.nx> <87oayp7px9.fsf@schwinge.name> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87oayp7px9.fsf@schwinge.name> X-IsSubscribed: yes X-SW-Source: 2014-05/txt/msg01916.txt.bz2 Thomas Schwinge wrote: > On Thu, 22 May 2014 17:02:08 +0100, Gary Benson wrote: > > Thomas Schwinge wrote: > > > In GCC, I'm consistenly seeing the following new failure: > > > > > > ./test-demangle < ../../../source/libiberty/testsuite/demangle-expected > > > FAIL at line 4350, options --format=auto --no-params: > > > in: _QueueNotification_QueueController__$4PPPPPPPM_A_INotice___Z > > > out: (null) > > > exp: > > > ./test-demangle: 895 tests, 1 failures > > > make[2]: *** [check-cplus-dem] Error 1 > > > > > > The patch was committed incompletely; I added the missing last line in > > > r210803: > > [snip] > > > @@ -4347,3 +4347,4 @@ void post >(std::function&&)::{lambda()#1}*& std > > > --format=auto --no-params > > > _QueueNotification_QueueController__$4PPPPPPPM_A_INotice___Z > > > _QueueNotification_QueueController__$4PPPPPPPM_A_INotice___Z > > > +_QueueNotification_QueueController__$4PPPPPPPM_A_INotice___Z > > > > I thought that extra line was a mistake; I thought each test was > > precisely three lines: > > > > # options > > # input to be demangled > > # expected output > > > > What is the extra line here? > > I too had to look it up -- see the explanation at the beginning of > the file: > > # --no-params There are two lines of expected output; the first > # is with DMGL_PARAMS, the second is without it. Ah, I missed that. Thank you for fixing this! Gary -- http://gbenson.net/