From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15870 invoked by alias); 26 May 2014 00:54:23 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 15858 invoked by uid 89); 26 May 2014 00:54:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: nikam.ms.mff.cuni.cz Received: from nikam.ms.mff.cuni.cz (HELO nikam.ms.mff.cuni.cz) (195.113.20.16) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 26 May 2014 00:54:20 +0000 Received: by nikam.ms.mff.cuni.cz (Postfix, from userid 16202) id D58745413FD; Mon, 26 May 2014 02:54:17 +0200 (CEST) Date: Mon, 26 May 2014 00:54:00 -0000 From: Jan Hubicka To: Martin Jambor Cc: GCC Patches , Jan Hubicka Subject: Re: [PATCH 4/7] Break up determine_known_aggregate_parts Message-ID: <20140526005417.GA15226@kam.mff.cuni.cz> References: <20140521131634.178838544@virgil.suse.cz> <20140521131634.462975324@virgil.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140521131634.462975324@virgil.suse.cz> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-05/txt/msg02129.txt.bz2 > Hi, > > the main purpose of this patch is to break up function > determine_known_aggregate_parts so that the next patch can use the > standalone bits and to make the changes slightly easier for review. > > However, this patch also removes some of the offset checks which Honza > correctly thought superfluous and even possibly filtering out useful > information. > > Bootstrapped and tested and LTO-bootstrapped on x86_64-linux. > OK for trunk after the preceeding patches get in? > > Thanks, > > Martin > > > 2014-02-19 Martin Jambor > > * ipa-prop.c (get_place_in_agg_contents_list): New function. > (build_agg_jump_func_from_list): Likewise. > (determine_known_aggregate_parts): Renamed to > determine_locally_known_aggregate_parts. Moved some functionality > to the two functions above, removed bound checks. This is OK. Does it depend on part 4? Honza