From: Jonathan Wakely <jwakely@redhat.com>
To: ramrad01@arm.com
Cc: Jonathan Wakely <jwakely.gcc@gmail.com>,
David Edelsohn <dje.gcc@gmail.com>,
Cesar Philippidis <cesar@codesourcery.com>,
Sandra Loosemore <sandra@codesourcery.com>,
libstdc++ <libstdc++@gcc.gnu.org>,
GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [patch ping] libstdc++ testsuite cxxflags
Date: Fri, 30 May 2014 11:11:00 -0000 [thread overview]
Message-ID: <20140530111126.GF6953@redhat.com> (raw)
In-Reply-To: <CAJA7tRb=t9U64RLtp9tNeJSwaQfYc09Tz2R0eD5bYuD4odcxPA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 539 bytes --]
On 30/05/14 08:53 +0100, Ramana Radhakrishnan wrote:
>With all the other build breakages in the past week, I've just
>started seeing the first set of testresults from an auto-tester. It
>looks like on a cross test using rhe5 / x86_64 with the version of
>tcl8.4 I'm using I see the same errors that David saw.
>
>The testsuite starts running if I tried the above
>
>regexp ".*-O" $cxxflags
>
>Is this going to be applied - what gives ?
Fixed with the attached patch.
Tested x86_64-linux (but onnly with Tcl 8.5), committed to trunk.
[-- Attachment #2: p2.txt --]
[-- Type: text/plain, Size: 697 bytes --]
commit 8e72d35ed67a51df88c359249590e266c476044e
Author: Jonathan Wakely <jwakely@redhat.com>
Date: Fri May 30 11:10:57 2014 +0100
* testsuite/lib/libstdc++.exp (libstdc++_init): Adjust regexp to
work with previous versions of Tcl.
diff --git a/libstdc++-v3/testsuite/lib/libstdc++.exp b/libstdc++-v3/testsuite/lib/libstdc++.exp
index 2b2a38b..d91bed6 100644
--- a/libstdc++-v3/testsuite/lib/libstdc++.exp
+++ b/libstdc++-v3/testsuite/lib/libstdc++.exp
@@ -283,7 +283,7 @@ proc libstdc++_init { testfile } {
append cxxflags " "
append cxxflags [getenv CXXFLAGS]
- if ![regexp "\-O" $cxxflags] {
+ if ![regexp ".*-O" $cxxflags] {
append cxxflags " -g -O2"
}
next prev parent reply other threads:[~2014-05-30 11:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-24 16:07 David Edelsohn
2014-05-24 16:54 ` Jonathan Wakely
2014-05-25 19:16 ` David Edelsohn
2014-05-30 7:53 ` Ramana Radhakrishnan
2014-05-30 11:11 ` Jonathan Wakely [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-05-17 0:16 Sandra Loosemore
2014-05-17 4:56 ` Mike Stump
2014-05-17 9:50 ` Jonathan Wakely
2014-05-17 9:52 ` Jonathan Wakely
2014-05-17 10:07 ` Jonathan Wakely
2014-05-19 20:57 ` Sandra Loosemore
2014-05-20 9:11 ` Jonathan Wakely
2014-05-20 19:38 ` Cesar Philippidis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140530111126.GF6953@redhat.com \
--to=jwakely@redhat.com \
--cc=cesar@codesourcery.com \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jwakely.gcc@gmail.com \
--cc=libstdc++@gcc.gnu.org \
--cc=ramrad01@arm.com \
--cc=sandra@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).