From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18179 invoked by alias); 30 May 2014 11:11:35 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 18162 invoked by uid 89); 30 May 2014 11:11:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 30 May 2014 11:11:34 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s4UBBSVs027252 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 30 May 2014 07:11:28 -0400 Received: from localhost (vpn1-6-41.ams2.redhat.com [10.36.6.41]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id s4UBBRHv021670; Fri, 30 May 2014 07:11:27 -0400 Date: Fri, 30 May 2014 11:11:00 -0000 From: Jonathan Wakely To: ramrad01@arm.com Cc: Jonathan Wakely , David Edelsohn , Cesar Philippidis , Sandra Loosemore , libstdc++ , GCC Patches Subject: Re: [patch ping] libstdc++ testsuite cxxflags Message-ID: <20140530111126.GF6953@redhat.com> References: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="C01fF7hLGvN0zd9s" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-SW-Source: 2014-05/txt/msg02593.txt.bz2 --C01fF7hLGvN0zd9s Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline Content-length: 539 On 30/05/14 08:53 +0100, Ramana Radhakrishnan wrote: >With all the other build breakages in the past week, I've just >started seeing the first set of testresults from an auto-tester. It >looks like on a cross test using rhe5 / x86_64 with the version of >tcl8.4 I'm using I see the same errors that David saw. > >The testsuite starts running if I tried the above > >regexp ".*-O" $cxxflags > >Is this going to be applied - what gives ? Fixed with the attached patch. Tested x86_64-linux (but onnly with Tcl 8.5), committed to trunk. --C01fF7hLGvN0zd9s Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="p2.txt" Content-length: 697 commit 8e72d35ed67a51df88c359249590e266c476044e Author: Jonathan Wakely Date: Fri May 30 11:10:57 2014 +0100 * testsuite/lib/libstdc++.exp (libstdc++_init): Adjust regexp to work with previous versions of Tcl. diff --git a/libstdc++-v3/testsuite/lib/libstdc++.exp b/libstdc++-v3/testsuite/lib/libstdc++.exp index 2b2a38b..d91bed6 100644 --- a/libstdc++-v3/testsuite/lib/libstdc++.exp +++ b/libstdc++-v3/testsuite/lib/libstdc++.exp @@ -283,7 +283,7 @@ proc libstdc++_init { testfile } { append cxxflags " " append cxxflags [getenv CXXFLAGS] - if ![regexp "\-O" $cxxflags] { + if ![regexp ".*-O" $cxxflags] { append cxxflags " -g -O2" } --C01fF7hLGvN0zd9s--