From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25589 invoked by alias); 3 Jun 2014 16:07:15 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 25576 invoked by uid 89); 3 Jun 2014 16:07:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.8 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 03 Jun 2014 16:07:12 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s53G7AQD016326 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 3 Jun 2014 12:07:10 -0400 Received: from tucnak.zalov.cz (ovpn-116-17.ams2.redhat.com [10.36.116.17]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id s53G787U020350 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 3 Jun 2014 12:07:09 -0400 Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.14.8/8.14.7) with ESMTP id s53G76Bw015800; Tue, 3 Jun 2014 18:07:06 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.14.8/8.14.8/Submit) id s53G73hM015799; Tue, 3 Jun 2014 18:07:03 +0200 Date: Tue, 03 Jun 2014 16:07:00 -0000 From: Jakub Jelinek To: Marek Polacek Cc: GCC Patches , "Joseph S. Myers" Subject: Re: [C PATCH] Use inform for "shadowed decl" (PR c/48062) Message-ID: <20140603160703.GX10386@tucnak.redhat.com> Reply-To: Jakub Jelinek References: <20140603160157.GE29196@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140603160157.GE29196@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2014-06/txt/msg00251.txt.bz2 On Tue, Jun 03, 2014 at 06:01:57PM +0200, Marek Polacek wrote: > For "shadowed declaration" note we were calling warning_at, while we > should use inform. > > Regtested/bootstrapped on x86_64-linux, ok for trunk? Shouldn't you remember the return value from warning/warning_at calls which fall through into this spot and guard the inform call with that? Jakub